From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E18343E81; Tue, 16 Apr 2024 05:06:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA61E4028B; Tue, 16 Apr 2024 05:06:21 +0200 (CEST) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by mails.dpdk.org (Postfix) with ESMTP id 13D5D4027F for ; Tue, 16 Apr 2024 05:06:20 +0200 (CEST) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-434d0f63c31so17413551cf.1 for ; Mon, 15 Apr 2024 20:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713236779; x=1713841579; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fQQd+ei3WUfINz7ZeQNtU7+BxhJ5i1Nm49EqFdwoBFk=; b=Zs2pwlMi5ig+JvcRvw17l2U60Km+oxQcezH3Xr3Wlu8kgOhdW96jc85fRRZNtUJCpZ piKhq7yodsZ8k04Die0zjAXo9ffeHY9zGFJOOO6FC4kiEAA4YUbJf6A7IDA6MIp1BX1a qAtc3FUepwFC3kDiCoOTMapU1QfU9FtSpeudUxo9ED6b3J7rlubFari5hsCdakNGf7dd A2QFHDo9iXh9qWZ9Dn90PrP4YCfo6cfeMYswrjOqBWdQ0vaaKzQ/z9nMFB+HhMelhw8m igFILdGhZd393wBupMbEOYAjs8B3k2PXZS5OQVO2+ljgMoUNcivwZN9U3sbGC6or2skT 946g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713236779; x=1713841579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fQQd+ei3WUfINz7ZeQNtU7+BxhJ5i1Nm49EqFdwoBFk=; b=C+Vrz+Dex8iMtpLySEp6t//PjcdEbG3BMcp2BcBIawe29iuR+yiGVAB1nNVPA6Ar2l SiKKcEe3Wti+mYxyIFOLLRpCqlNcvGRZOdQ/ZedbSnCL2SWAcxMOJj1rqa/58uXr/2t4 c5y7v1TSpS3rXw85NXeI+Xa8aBeENB2NvPWKcLq7cAK/LKSbtQVS/29DdogCx8EQeNT8 9F9M7NYOiZQVEkU6mTwFKfwAf6XB5i9WiAbKVFzPe8qaxP6gKjYTMuI8gyte8AgBswD5 67rCjcSIwCDphgua98LEv1Yo14pDf0SZQwb6XL74i8v1I5s9EP2GNKIcOXBm9/7BdGOE T5Ew== X-Gm-Message-State: AOJu0YwTbMazHXSMovWiRyUIQDTJ6/F6ujtglX6QBxd3i47VM/ftpUlu GnpDj3iXkQ91GijjnIqjWxpFhxOfQWUZ+sTg5Rb5akcxD/6q/9OO8y91L07U4SusTtkjOhH811v LG/vtDOw9fI34Dm/ZWMGsuCOonUQ= X-Google-Smtp-Source: AGHT+IEG+Gcs2C3G+tiJlUdrvw+LjSLlHgjUAJZwzvBubBhj8BafRznyC9msGU0PaX2jUNOBqdmIsEd8DVOm0FrlK1Q= X-Received: by 2002:ac8:7c48:0:b0:436:89d4:d5c6 with SMTP id o8-20020ac87c48000000b0043689d4d5c6mr15329879qtv.54.1713236779072; Mon, 15 Apr 2024 20:06:19 -0700 (PDT) MIME-Version: 1.0 References: <20240412111317.3530529-1-sebastian.brzezinka@intel.com> <20240412111317.3530529-2-sebastian.brzezinka@intel.com> In-Reply-To: <20240412111317.3530529-2-sebastian.brzezinka@intel.com> From: Jerin Jacob Date: Tue, 16 Apr 2024 08:35:52 +0530 Message-ID: Subject: Re: [PATCH 2/2] ARM64: Cross-Compilation Support To: Sebastian Brzezinka Cc: dev@dpdk.org, Krishna Kanth Reddy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 12, 2024 at 4:43=E2=80=AFPM Sebastian Brzezinka wrote: > > From: Krishna Kanth Reddy > > Modified the Configuration file to use the latest ARM Cross-Compiler. > > Fixed the linker errors for the undefined references to the APIs > isal_deflate_init, isal_deflate, isal_inflate_init, isal_inflate, > isal_inflate_stateless, isal_deflate_stateless, > isal_deflate_set_hufftables in the case of ARM Cross-Compilation. > > Signed-off-by: Krishna Kanth Reddy > Signed-off-by: Sebastian Brzezinka There is comment[1] in v1. v2 is not addressed the comment nor provided any feedback. Also please add change log in patch(i.e what is changed from a version to another version) [1] https://patches.dpdk.org/project/dpdk/patch/20240405110700.3279213-1-sebast= ian.brzezinka@intel.com/ > --- > config/arm/arm64_armv8_linux_gcc | 10 +++++----- > drivers/compress/isal/meson.build | 4 ++++ > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_li= nux_gcc > index 529694b49d..6dfb8aa206 100644 > --- a/config/arm/arm64_armv8_linux_gcc > +++ b/config/arm/arm64_armv8_linux_gcc > @@ -1,9 +1,9 @@ > [binaries] > -c =3D ['ccache', 'aarch64-linux-gnu-gcc'] > -cpp =3D ['ccache', 'aarch64-linux-gnu-g++'] > -ar =3D 'aarch64-linux-gnu-gcc-ar' > -strip =3D 'aarch64-linux-gnu-strip' > -pkgconfig =3D 'aarch64-linux-gnu-pkg-config' > +c =3D ['ccache', 'aarch64-none-linux-gnu-gcc'] > +cpp =3D ['ccache', 'aarch64-none-linux-gnu-cpp'] > +ar =3D 'aarch64-none-linux-gnu-gcc-ar' > +strip =3D 'aarch64-none-linux-gnu-strip' > +pkgconfig =3D 'aarch64-none-linux-gnu-pkg-config' > pcap-config =3D '' > > [host_machine] > diff --git a/drivers/compress/isal/meson.build b/drivers/compress/isal/me= son.build > index 4b3eaa2274..b3cc990053 100644 > --- a/drivers/compress/isal/meson.build > +++ b/drivers/compress/isal/meson.build > @@ -5,6 +5,10 @@ dep =3D dependency('libisal', required: false, method: '= pkg-config') > if not dep.found() > build =3D false > reason =3D 'missing dependency, "libisal"' > + isal_dep =3D cc.find_library('libisal', required: false) > + if isal_dep.found() > + ext_deps +=3D isal_dep > + endif > endif > > deps +=3D 'bus_vdev' > -- > 2.34.1 >