From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43D3DA2F18 for ; Thu, 3 Oct 2019 16:38:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45D271C113; Thu, 3 Oct 2019 16:38:13 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id B5AF41C0CE; Thu, 3 Oct 2019 16:38:11 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id a1so6074721ioc.6; Thu, 03 Oct 2019 07:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1dXXRjnD+rFgvhu19DzpXt6wU6dKW736Q1/FD+x84hI=; b=VDE50MGAF71Y11TPNYRYbVicbSfrWYsHhcRVNCLJxVDzQZPtJop2Wp52n5NaP1o/eX ZDhBUIAE1SGE/qipYRdoln6bT481a1MhpLDxgNerGxmTrqISmyIhTVIPu2VS5A1Vg5Dk HnPFsWdQqQXy2RhUITDFgAHmkC/yZ9mvoX+0NnEwbgLWWIOnZBCneZOyNb8SyEweViZD mbrGw3lPyalYu1tpptVD2egWtYFy0sKvHA/G/FLFNAJzujuVpLZbAGFw5b2s4cMU3UNX mz6uqglU5B8oC3YD+cj+hGRQIHTrob/4mPvNwGlIkEUthNWl8PB/fpooT9lfdcO7eC8b /J8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1dXXRjnD+rFgvhu19DzpXt6wU6dKW736Q1/FD+x84hI=; b=Ztt0XJkuLgiGjK3MEPRyNwzEWfax2B5snaKtSLcW6mzX+w4YQ4eRSHT3ZRT+LDFoCW KJecdsfPtGizQPmcnBKzTryxWsAbq4iiQIZNazn6qFJ35Kf8Rk0Lh50IkDSCjz6K5W6i iDl4Yx2ykLE35Yya1PR4UQUlPajG8zHfwNwKnBJu5JEqwQEwI8GYpoPZ1Y20PiCjURcp ujhECZcEno9a7WRAiflEz5grvLgC9xKVlifaeCb35Oc+ubiRR9WUbZDwWjIAEE496cvA o8bNa7EL+6E1/3tK3Tnl1d5TqnG025dXMeL5KWOdlwouITrh/lX9w/DU2f+JwaiMnCSq 4Bgw== X-Gm-Message-State: APjAAAXm15/4sqfB+S22dQJXIm4OUoLAwp2h3JPtz6Ubj9990G5KnsNg LBLQsQryPXxA/apiKNPACsZhWZCg0edDAXLjLco= X-Google-Smtp-Source: APXvYqyzBYr4wz8cl3aHHzsplihkzVQ59Fbh/3kZqChempMVXnh/HxR637U7yerMPWBB+odKkNzuoFwzw5ZVx72zUz0= X-Received: by 2002:a92:1598:: with SMTP id 24mr9668348ilv.60.1570113490822; Thu, 03 Oct 2019 07:38:10 -0700 (PDT) MIME-Version: 1.0 References: <20191003063229.19892-1-skori@marvell.com> In-Reply-To: <20191003063229.19892-1-skori@marvell.com> From: Jerin Jacob Date: Thu, 3 Oct 2019 20:07:59 +0530 Message-ID: To: Sunil Kumar Kori Cc: Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , Kiran Kumar K , dpdk-dev , stable@dpdk.org, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] drivers/octeontx2: fix parser error to ol_flags translation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 12:03 PM Sunil Kumar Kori wrote: > > NPC errors were incorrectly translated to ol_flag as > error code enum was not in sync with NPC profile. > > Fixes: 371d3212cbed ("common/octeontx2: add build infrastructure and HW definition") > > Signed-off-by: Sunil Kumar Kori Changed subject to drivers/octeontx2: fix checksum flag translation Cc: stable@dpdk.org Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/common/octeontx2/hw/otx2_npc.h | 7 ++++--- > drivers/net/octeontx2/otx2_lookup.c | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h > index 0f85d7fdb..8045bed11 100644 > --- a/drivers/common/octeontx2/hw/otx2_npc.h > +++ b/drivers/common/octeontx2/hw/otx2_npc.h > @@ -132,6 +132,7 @@ enum npc_kpu_err_code { > NPC_EC_NOERR = 0, /* has to be zero */ > NPC_EC_UNK, > NPC_EC_IH_LENGTH, > + NPC_EC_EDSA_UNK, > NPC_EC_L2_K1, > NPC_EC_L2_K2, > NPC_EC_L2_K3, > @@ -245,9 +246,6 @@ enum npc_kpu_lf_ltype { > NPC_LT_LF_TU_3RD_NSH, > }; > > -/* Don't modify Ltypes upto SCTP, otherwise it will > - * effect flow tag calculation and thus RSS. > - */ > enum npc_kpu_lg_ltype { > NPC_LT_LG_TU_IP = 1, > NPC_LT_LG_TU_IP6, > @@ -255,6 +253,9 @@ enum npc_kpu_lg_ltype { > NPC_LT_LG_TU_ETHER_IN_NSH, > }; > > +/* Don't modify Ltypes upto SCTP, otherwise it will > + * effect flow tag calculation and thus RSS. > + */ > enum npc_kpu_lh_ltype { > NPC_LT_LH_TU_TCP = 1, > NPC_LT_LH_TU_UDP, > diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c > index 99199d08a..6cdca9b33 100644 > --- a/drivers/net/octeontx2/otx2_lookup.c > +++ b/drivers/net/octeontx2/otx2_lookup.c > @@ -272,13 +272,13 @@ nix_create_rx_ol_flags_array(void *mem) > val |= PKT_RX_IP_CKSUM_GOOD; > break; > case NPC_ERRLEV_NIX: > + val |= PKT_RX_IP_CKSUM_GOOD; > if (errcode == NIX_RX_PERRCODE_OL4_CHK) { > val |= PKT_RX_OUTER_L4_CKSUM_BAD; > val |= PKT_RX_L4_CKSUM_BAD; > } else if (errcode == NIX_RX_PERRCODE_IL4_CHK) { > val |= PKT_RX_L4_CKSUM_BAD; > } else { > - val |= PKT_RX_IP_CKSUM_GOOD; > val |= PKT_RX_L4_CKSUM_GOOD; > } > break; > -- > 2.17.2 >