From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5086EA0C47; Tue, 12 Oct 2021 11:27:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC34240151; Tue, 12 Oct 2021 11:27:10 +0200 (CEST) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id 16BB34003C for ; Tue, 12 Oct 2021 11:27:09 +0200 (CEST) Received: by mail-io1-f49.google.com with SMTP id m20so22128419iol.4 for ; Tue, 12 Oct 2021 02:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5NtTsIzweQqfZDc6UEl5pL67QiIL+iNSXjdNHxNuNI=; b=QQw6fxPpTWVOKugMpv+X/8p4R00Ynhx/28IZb37eguRQvhpiYgUEqx+9/ehvi+PIs1 NVn7hIny6QESV4ZVnWXvo5v9vaVfgE1mLMX7ddQlAkOIIKl83eCsgjNGXldRxTNMT0T2 hqvXQkaz0Ura1d3Fx8WEq801pAmowyCQHnPW9DgmRIBr6gEfdIyfiy474Vv30DEO77J8 tqHQCQqiTou6wmYYM2xwuoMEVbFhIz7LGwucZ2TRqaefknGBJenefYJgCvN+yRxkatKJ o3W6dfd4gUvKhY8FgRrykSOckVf5v6l+Rz6wkSrV/V5Jx9ZPIoKIS6dcuTC5HaNzQifO XNdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5NtTsIzweQqfZDc6UEl5pL67QiIL+iNSXjdNHxNuNI=; b=MuKAyxt3OdmQ8hFrBCHbvRF/iGtu102ox2V/Nrfs0PBWKHNhOEsT1qBBJYTOxmPEAD 9Aulo/GWvkzJEEIfmAZ0t7GGByWFM4YYAA6CLc4WrhZIs71YUiJSl9nwB2izYlHA+Nxh dQSZwpmQP/NdyuRtTuo+fmjvoeZFPxDir1ZHR50jN8tYIRebYhmwwfyXnT75fMv2yUUh 7SZ1+uswDJnoD5f/mb9wvMzjWq1ng/kA7vMv7bfTrN3ZFGR+tMPzTtjjW7OXGXIEekoc NwiYOZ5Zrys0J/4rA4tSI78U1yXDX5ook49BaUahEnD4xDrHwcjwvvKLEnuFzN8uvutk I3TA== X-Gm-Message-State: AOAM533OCEEIJHlbkGav8JZ2TsjU1ukeo+pAZ+dn0/1ouqzg9Zgk0QHP zprY6dHmR491XHqusd734F3V6s2nU/W81zqMl6A= X-Google-Smtp-Source: ABdhPJwuvP5Kvw7+sQX/wNXvn1uJeIObBApKsJrDfJJnMtPBhUFsCrWfmhZdD7aping+GbxZuDRHAQNmGUo7QPPf3Rw= X-Received: by 2002:a05:6638:339e:: with SMTP id h30mr23523887jav.99.1634030828051; Tue, 12 Oct 2021 02:27:08 -0700 (PDT) MIME-Version: 1.0 References: <20211007125734.2326512-1-ganapati.kundapura@intel.com> <1674729.iRVOSB7e9I@thomas> In-Reply-To: <1674729.iRVOSB7e9I@thomas> From: Jerin Jacob Date: Tue, 12 Oct 2021 14:56:42 +0530 Message-ID: To: Thomas Monjalon Cc: "Kundapura, Ganapati" , Ray Kinsella , David Marchand , dpdk-dev , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 12, 2021 at 2:40 PM Thomas Monjalon wrote: > > 12/10/2021 10:47, Jerin Jacob: > > On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati > > wrote: > > > From: Jerin Jacob > > > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > > > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > > > > > @@ -216,6 +216,10 @@ struct rte_event_eth_rx_adapter_stats { > > > > > /**< Eventdev enqueue count */ > > > > > uint64_t rx_enq_retry; > > > > > /**< Eventdev enqueue retry count */ > > > > > + uint64_t rx_event_buf_count; > > > > > + /**< Rx event buffered count */ > > > > > + uint64_t rx_event_buf_size; > > > > > > > > > > > > Isn't ABI breakage? CI did not warn this. Isn't this a public structure? > > > Please confirm if moving the above two members to end of the structure overcomes ABI breakage? > > > > > > + @Ray Kinsella @Thomas Monjalon @David Marchand > > > > It will still break the ABI. IMO, Since it is an ABI breaking release > > it is OK. If there are no other objections, Please move the variable > > to end > > of the structure and update release notes for ABI changes. > > Why moving since it breaks ABI anyway? There is no specific gain in keeping new additions in the middle of structure. > I think you can keep as is. > > >