From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53C7142F79; Fri, 18 Aug 2023 09:45:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A1EF40ED9; Fri, 18 Aug 2023 09:45:39 +0200 (CEST) Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by mails.dpdk.org (Postfix) with ESMTP id 860E540395 for ; Fri, 18 Aug 2023 09:45:37 +0200 (CEST) Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-48b2f5b9b08so209540e0c.2 for ; Fri, 18 Aug 2023 00:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692344737; x=1692949537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2k0+CRzzn0+hb63VYYeuhJaQa38L5n1QCdQ0ZWLhSAE=; b=WgjjmWSJV3h2o14ENwnhxNkBbtNsdEo5lQo4NazQvWbGPVmESCvgA9ZnHqbHdK8icl bB2JKvKiCy3FALyW/M+eROF7yJaoFrdRoO4Wh9dBefTSqKPw5mqWOw3e/h3C9+4lJ4LE GFEp6M3xYhvsPOJV+CW+b1N+QmRvGwELHoZCZF38dIih+StFivL3c52hW9eEdfusZ75W COPJmqr9KCLz+0tUWRXfjWQ3DlCc0beAh70/4lNzzIweKMbdjBAWQq6ziNg/oDWyl3lv mYvfbbJy6FjGg4mSf8b/OqR4HoaKtwc+iwFmSkI15jV9/fXxYaaKZ7eWPaKlg41gDVbC QI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692344737; x=1692949537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2k0+CRzzn0+hb63VYYeuhJaQa38L5n1QCdQ0ZWLhSAE=; b=Xh2kQugiOujSSCLwFC3r2TwgzAI4ZCe/FH9vDrC1vW2Ay/hoa0d+61KrmOXC+J9nxX Fb3HlxmaEWC+rLNBvuiKu2lFrI0JXruvUdHF8cfDhVxhXqjtkthOZ1dQZyITLYW/M3Qj IWzLXa/mg6HSaarEAVKMUdV1c+fs3gFO1HMyof8MLU+OLxOM6Z/G2XGl1wRDe+uTMyIy r5skX6RifumQIkromkalHAOeqes0/qsgVWZulchPA8FYkmNL/UiTufPGvM/NmFIWtVN7 dq9+Z0bpHjS3F5+8I2/oaCIbrqrY/YWaIh1dVZHkX4KB/+AgC5gaRG1YaUSZCaCnUgpC 5tmw== X-Gm-Message-State: AOJu0YyjBKLq6+w+47oVMR++Hav7IoGVp9or9pHLVxyaplLzNn4WExCF hSKIyMHK/K4o6oI64aKUZbvAMUHF5Y8tsprCNZE= X-Google-Smtp-Source: AGHT+IEuXRIlQ+P6xbhMvJ8obBTivFfj/3MIp61YBhub078bY1agJBwaGgAVbON1VagVgPF5dOpIenXe1IlZFueu798= X-Received: by 2002:a1f:c1cf:0:b0:488:b19e:9621 with SMTP id r198-20020a1fc1cf000000b00488b19e9621mr2391551vkf.5.1692344736759; Fri, 18 Aug 2023 00:45:36 -0700 (PDT) MIME-Version: 1.0 References: <20230724080744.1209290-1-amitprakashs@marvell.com> In-Reply-To: <20230724080744.1209290-1-amitprakashs@marvell.com> From: Jerin Jacob Date: Fri, 18 Aug 2023 13:15:10 +0530 Message-ID: Subject: Re: [RFC PATCH] eventdev: introduce DMA event adapter library To: Amit Prakash Shukla Cc: Jerin Jacob , dev@dpdk.org, s.v.naga.harish.k@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, pbhagavatula@marvell.com, timothy.mcdaniel@intel.com, hemant.agrawal@nxp.com, harry.van.haaren@intel.com, mattias.ronnblom@ericsson.com, liangma@liangbit.com, peter.mccarthy@intel.com, skori@marvell.com, thomas@monjalon.net, fengchengwen@huawei.com, bruce.richardson@intel.com, kevin.laatz@intel.com, conor.walsh@intel.com, radhac@marvell.com, g.singh@nxp.com, sachin.saxena@oss.nxp.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 24, 2023 at 1:39=E2=80=AFPM Amit Prakash Shukla wrote: > > Introduce event DMA adapter APIs. This patch provides information > on adapter modes and usage. Application can use this event adapter > interface to transfer packets between DMA device and event device. > > Signed-off-by: Amit Prakash Shukla > +/** > + * DMA event request structure will be filled by application to provide = event request information to > + * the adapter. > + */ > +struct rte_event_dma_request { > + > + int16_t dmadev_id; > + /**< DMA device ID to be used */ > + > + uint16_t queue_pair_id; > + /**< DMA queue pair ID to be used */ dmadev wont have queue pair. Use vchan_id or so > + > + uint32_t rsvd; > + /**< Reserved bits */ > +}; > + > +/** > + * Adapter configuration structure that the adapter configuration callba= ck function is expected to > + * fill out. > + * > + * @see rte_event_dma_adapter_conf_cb > + */ > +struct rte_event_dma_adapter_conf { > + uint8_t event_port_id; > + /** < Event port identifier, the adapter enqueues events to this = port and dequeues DMA > + * request events in RTE_EVENT_DMA_ADAPTER_OP_FORWARD mode. > + */ > + > + uint32_t max_nb; > + /**< The adapter can return early if it has processed at least ma= x_nb DMA ops. This isn't DMA -> dma > + * treated as a requirement; batching may cause the adapter to pr= ocess more than max_nb DMA > + * ops. > + */ > +}; > + > + rte_event_dma_adapter_create_ext; > + rte_event_dma_adapter_create; > + rte_event_dma_adapter_free; > + rte_event_dma_adapter_queue_pair_add; > + rte_event_dma_adapter_queue_pair_del; > + rte_event_dma_adapter_start; > + rte_event_dma_adapter_stop; > + rte_event_dma_adapter_stats_get; > + rte_event_dma_adapter_stats_reset; Fix the build issues in http://mails.dpdk.org/archives/test-report/2023-July/431120.html by have dummy functions. Since it is very similar to crypto adapter, Could not find more review comm= ents. If there are no review comments, Please send v1 with app changes and driver changes.