From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03A9EA2EDB for ; Tue, 1 Oct 2019 16:48:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ACB84CA6; Tue, 1 Oct 2019 16:48:14 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id B49BB271 for ; Tue, 1 Oct 2019 16:48:13 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id n197so48569111iod.9 for ; Tue, 01 Oct 2019 07:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0qN/zng93EdPrK4To/76YzksBKfJBpIRzaAmoa44K1E=; b=XPDD658LGIqqAyQgOyKdk+afmnQjoCJDaR5KY/lKJ4LcLZh9HTPl8WhdZt4oJ7TZ5G IvJh0WEguhB7HSA4KEt55RwpF7SibQDkRmAVW/zunQqPCWAvaT4AfrHK4P/kQ5FW1WsT jjvawfuvSEG4aA7YjXbfyaLTpC8h22xaj9oS4WdSoWU1GxBGUldGCUnNMQ1raDdyeBGe hbSsfPiD//+UuGFqFN2xHixbLhr7V3ThGo87Hk4zb43a8naG51R+VQUSao3gKFOFqYu8 bvd4sjRHm/ktckL4ZQ/VBZxSPk3UiTUrhwwnxgjSpgDc0kWlcKi48sASldp5xxYw5P6U OyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0qN/zng93EdPrK4To/76YzksBKfJBpIRzaAmoa44K1E=; b=O8RfUgeW/+39q0h/MiIN/y8O4GyRBan7I57m/pixXaUWXWECl5Vna8Xb1CpgpacMcT 3ohbuz37/Hwj2C2JS7fjAPxuBM6UvqiZQYdGnqwIuCWqpFluet6s8EbtbWn3n26xnDng LMz7iTLv/IdHwNNWr8g/yW9SRG+CkEWFLX4lHvkWAjWSQBZhXAsCCTzW92YXFdhGtndR ecXFN85iB+WsA0s03FKBTAzbKy2SnJW0xa3z7MMGpEU8RJJm6Hw7mYw/Tnr9IYobIb2G 8A0ACJUPV1KKEShWOAF+NsiKWy/F3S2enOogzcBVQMqSA3qhn0k3LUqbs1V3XMENcF6g Fw2A== X-Gm-Message-State: APjAAAVNFnj9g7cukMnitS/Z3vloXYN5n4bxK96rvHpF5Weg5srWelXf xNJJuwgSKrDuh0Aze5N3JUK2uTcSFIHI+NiXN5M= X-Google-Smtp-Source: APXvYqwy2TLrApwdPeqTzUa3tzhb/BlgtwRNSSJ1ttj/11y/PvFTngo/jwhDP3HNb405Dat9BfelyYoSh5/O8z/CW08= X-Received: by 2002:a05:6638:3d4:: with SMTP id r20mr25179168jaq.104.1569941292878; Tue, 01 Oct 2019 07:48:12 -0700 (PDT) MIME-Version: 1.0 References: <20190821204755.1990-1-pbhagavatula@marvell.com> <20190821204755.1990-6-pbhagavatula@marvell.com> In-Reply-To: <20190821204755.1990-6-pbhagavatula@marvell.com> From: Jerin Jacob Date: Tue, 1 Oct 2019 20:18:01 +0530 Message-ID: To: Pavan Nikhilesh Cc: arybchenko@solarflare.com, Jerin Jacob , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qi Zhang , Jingjing Wu , Wenzhuo Lu , Qiming Yang , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 22, 2019 at 2:18 AM wrote: > > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action > flag and mark. > > Signed-off-by: Pavan Nikhilesh > --- > diff --git a/drivers/net/octeontx2/otx2_flow_parse.c b/drivers/net/octeontx2/otx2_flow_parse.c > index 6670c1a70..6eb69a8b2 100644 > --- a/drivers/net/octeontx2/otx2_flow_parse.c > +++ b/drivers/net/octeontx2/otx2_flow_parse.c > @@ -979,7 +979,8 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev, > if (mark) > flow->npc_action |= (uint64_t)mark << 40; > > - if (rte_atomic32_read(&npc->mark_actions) == 1) { > + if (rte_atomic32_read(&npc->mark_actions) == 1 && npc->mark_actions was kind of emulating the DEV_RX_OFFLOAD_FLOW_MARK. Now that we have explicit DEV_RX_OFFLOAD_FLOW_MARK flag, We can remove npc->mark_actions. > + (hw->rx_offloads & DEV_RX_OFFLOAD_FLOW_MARK)) { > hw->rx_offload_flags |= > NIX_RX_OFFLOAD_MARK_UPDATE_F; > otx2_eth_set_rx_function(dev);