* [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet
@ 2020-01-29 1:43 Rasesh Mody
2020-01-29 14:17 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Rasesh Mody @ 2020-01-29 1:43 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit
Cc: Rasesh Mody, stephen, GR-Everest-DPDK-Dev, stable
For VLAN packet the tci is saved in rx_mb->vlan_tci, however the
STRIPPED offload flag is not set along with PKT_RX_VLAN flag.
Set the PKT_RX_VLAN_STRIPPED flag as well.
Fixes: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index ae97dfee36..ea2b53dff8 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -414,7 +414,7 @@ bnx2x_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
*/
if (cqe_fp->pars_flags.flags & PARSING_FLAGS_VLAN) {
rx_mb->vlan_tci = cqe_fp->vlan_tag;
- rx_mb->ol_flags |= PKT_RX_VLAN;
+ rx_mb->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
}
rx_pkts[nb_rx] = rx_mb;
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet
2020-01-29 1:43 [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet Rasesh Mody
@ 2020-01-29 14:17 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2020-01-29 14:17 UTC (permalink / raw)
To: Rasesh Mody
Cc: dpdk-dev, Jerin Jacob, Ferruh Yigit, Stephen Hemminger,
GR-Everest-DPDK-Dev, dpdk stable
On Wed, Jan 29, 2020 at 7:13 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> For VLAN packet the tci is saved in rx_mb->vlan_tci, however the
> STRIPPED offload flag is not set along with PKT_RX_VLAN flag.
> Set the PKT_RX_VLAN_STRIPPED flag as well.
>
> Fixes: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN")
> Cc: stable@dpdk.org
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
> index ae97dfee36..ea2b53dff8 100644
> --- a/drivers/net/bnx2x/bnx2x_rxtx.c
> +++ b/drivers/net/bnx2x/bnx2x_rxtx.c
> @@ -414,7 +414,7 @@ bnx2x_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> */
> if (cqe_fp->pars_flags.flags & PARSING_FLAGS_VLAN) {
> rx_mb->vlan_tci = cqe_fp->vlan_tag;
> - rx_mb->ol_flags |= PKT_RX_VLAN;
> + rx_mb->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
> }
>
> rx_pkts[nb_rx] = rx_mb;
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-29 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 1:43 [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet Rasesh Mody
2020-01-29 14:17 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).