From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDA3641DC9; Fri, 3 Mar 2023 16:34:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD32F40EE3; Fri, 3 Mar 2023 16:34:29 +0100 (CET) Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by mails.dpdk.org (Postfix) with ESMTP id E556A40ED9; Fri, 3 Mar 2023 16:34:28 +0100 (CET) Received: by mail-vs1-f49.google.com with SMTP id f31so2750823vsv.1; Fri, 03 Mar 2023 07:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RpSKB8BYFJV/ueeXu2gLHBxmS5rVkkjekiuwEZ5D6B8=; b=e5MJOsxLdKQeBtDOtiGO6iCb/KvCuhAtA+CeYUrDH/XuHKu8XnkgEyaV7lCIHQYqC0 fHqNc1CClJgYjVqp3zIRSGC7LtYn3cPkMac8xAeDVzoeqieh2bomXGkb4ybPTUwq79PO xzWhjBTUaizhP1DQed8/7iT0rkuZG+tN3X74Ha3QiY6stnH8a1md5Uba0wHxJcRLrE6p Skq0UlhRDkGUtYaPtv0KCF7bpESVAMfXolFWCSQ9ibMwO0+IoB9mFGsM2T8kMmeKvsXL JrfXvX9nk9YVTcouSWsI6NcxfRENm1Igs3nspRoN4aIe0RC88J01BzsD72WluiofBxAU MIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RpSKB8BYFJV/ueeXu2gLHBxmS5rVkkjekiuwEZ5D6B8=; b=VdcVUcL+S7LjMNE1O5M7GwrM+4rjRo3eiH3gL+VXjZxZwjVpn+UL3XwCmwmRLHxPdq d4Lr8ShheS29N69hRfmjbVZykXC6p9aVKhGGDNGFFWw3crG+rET2LhzHaOK/6JgQXDKT 3uPrX6yEivpVCUrQM9QF9VmN3NCszKRIbjy5pXytf4786Mbk1NUsgKUniYrOYDbNP+rh Ipjhf/6yMm7o0LQjJlTbzXPSH2v1xkovwNtYL28n+B9jgnblO62BDo/1iR7XCWDos4DS Iez2SGm8Yq1TSbtKNnLsJVINrEj7gk5kKFSGghh0REErDLc8+2Vm00B68leweJk1XT0A oDoA== X-Gm-Message-State: AO0yUKVfN/L1fnKVogQN743U1m24UqxqNfRGduyR2Gyo2W/ZoxyeQgdG kkfoH9RKl1vrExRUa+/yJ+wC6hjKLJeG/W5XzyQ= X-Google-Smtp-Source: AK7set9x6gU3PFjINNbVJxr+wJp8uhyQvHSAhvSGy3nkB3OHxHKmPRns95UJYy/9+xsVX4e+iRLAeqW+50kYYAAAETY= X-Received: by 2002:a67:1a87:0:b0:415:2063:e403 with SMTP id a129-20020a671a87000000b004152063e403mr1454786vsa.3.1677857668255; Fri, 03 Mar 2023 07:34:28 -0800 (PST) MIME-Version: 1.0 References: <20230302105832.3955684-1-vfialko@marvell.com> In-Reply-To: <20230302105832.3955684-1-vfialko@marvell.com> From: Jerin Jacob Date: Fri, 3 Mar 2023 21:04:02 +0530 Message-ID: Subject: Re: [PATCH] event/cnxk: fix SSO return code at fini To: Volodymyr Fialko Cc: dev@dpdk.org, Pavan Nikhilesh , Shijith Thotton , Ray Kinsella , jerinj@marvell.com, anoobj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 2, 2023 at 4:30=E2=80=AFPM Volodymyr Fialko wrote: > > dev_fini() can return EAGAIN in case if LF is active(used by other > devices). Ignoring return code leads to early free of resources that are > still in use. > > Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup") > Cc: stable@dpdk.org > > Signed-off-by: Volodymyr Fialko Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/event/cnxk/cnxk_eventdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk= _eventdev.c > index 9815e84c24..6aecccb45d 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -670,9 +670,8 @@ cnxk_sso_fini(struct rte_eventdev *event_dev) > > cnxk_tim_fini(); > roc_sso_rsrc_fini(&dev->sso); > - roc_sso_dev_fini(&dev->sso); > > - return 0; > + return roc_sso_dev_fini(&dev->sso); > } > > int > -- > 2.34.1 >