From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08EFDA04E0; Wed, 27 Nov 2019 12:44:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40B3F58C3; Wed, 27 Nov 2019 12:44:18 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id CFDA65596 for ; Wed, 27 Nov 2019 12:44:16 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id u24so22753038iob.5 for ; Wed, 27 Nov 2019 03:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OQqULcu7vPK618QmtweHbhyqD0AaB6OXmmqM/2zkieA=; b=u12DJgiqPen44fcT6Uj5kaMruXzeeUqsefMjEl+RLX0+M4wcRdzEOk9s9Ki70DGzVU esplY313Z1P7Q/Xa3RJf4pExRbJ+VEsPxnl1hrcewBzWY9l0B/os0HUCXjFEu7QQhKVO kxJmh1KJBfIidzSfFFKX70DuzOY9fFGvfZ451BjwY+IE6bthbkV8D+16PjK7k8PWtAuv XsTRqLMJsUJwcbzUzKxxxjOpGe40MytVcC3H7cy/xeCInHC3bplwKEoKt8Sykvmc+xmL PNUrtilfuDWznbCofsVJVUo2PRTM/gVR0VUoywl1UOiE6EhKFNmw1Vopcrsg6EhMZzA8 d5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OQqULcu7vPK618QmtweHbhyqD0AaB6OXmmqM/2zkieA=; b=r8OIIvWHZz9L/Dr1fKsHywffLERZbGveMWsjYUA1fid6HlVVaDxFROG9+gauqy8mjZ +eqhviq20HBdbyabU9GA/+OvaTOH837awySM6BemlBD7rEJ+jiDhjWbfnEdU6PVE4Muc EncFiO01AMNh1lTfncuLUzlj1Y7Gofqc43H/6jHvT2xbPvO1t5ClMW22g8TjBiKdC4gK hm8H+Of3vZgkAcF5Jh97e0y1iA/4OIjmbJaIHj2Pjn89zSS2KFC+zIIGS/tUQ71khNC1 Xu44jgjLclEc+e6T3Y7cQO/Dft8iQO+4y08Kfpubf/sQjmLgevI/rrFv1Sven+nK0Skx WJYA== X-Gm-Message-State: APjAAAVygRaFtknDbjxB0fmgeyYbYcZiGML8WH3CHXw/T9uNbLN4YRj+ 3STkSWtT8p7G/F6SLL75RdIgYx8dif1lKZ8Dog0= X-Google-Smtp-Source: APXvYqwRsv5Z22fiNlnDvPAoRVEvr1J9euEhHzI/r5cw2junLI3815NDsAoGfoMuULO/UH8dsNgSGUYZm+yD6b0AT5c= X-Received: by 2002:a5e:8516:: with SMTP id i22mr26708707ioj.130.1574855055902; Wed, 27 Nov 2019 03:44:15 -0800 (PST) MIME-Version: 1.0 References: <20191127110507.3599-1-pbhagavatula@marvell.com> In-Reply-To: <20191127110507.3599-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Wed, 27 Nov 2019 20:43:59 +0900 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/octeontx: handle partial receive packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 27, 2019 at 8:05 PM wrote: > > From: Pavan Nikhilesh > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > PKI aka 'net/octeontx' can forward packets directly to SSO aka > 'event/octeontx'. > When pumping traffic to PKI if flow control is disabled internal FIFOs > might be overrun causing partial l2 packets to be enqueued. > SSO receives <31:0> TAG tag calculated by PKI, in normal cases <31:28> > is always 0 which signifies RTE_EVENT_TYPE_ETHDEV. But in case of > partial received packets PKI sets the <31:0> TAG as 0xFFFFFFFF which > is an invalid event type. > > Add a check to see if TAG is 0xFFFFFFFF and free the partial receive > packet. > > Signed-off-by: Pavan Nikhilesh # Could you add Fixes: # Change the subject to "net/octeontx: fix partial Rx packet handling" # Cc stable # Fix the following check-git-log Wrong headline prefix: event/octeontx: handle partial receive packets Please see inline > --- > drivers/event/octeontx/ssovf_worker.h | 17 +++++++++++++++-- > drivers/net/octeontx/base/octeontx_pki_var.h | 2 +- > 2 files changed, 16 insertions(+), 3 deletions(-) > > ssows_get_work(struct ssows *ws, struct rte_event *ev) > { > @@ -59,9 +68,13 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev) > ws->cur_grp = sched_type_queue >> 2; > sched_type_queue = sched_type_queue << 38; > ev->event = sched_type_queue | (get_work0 & 0xffffffff); > + > if (get_work1 && ev->event_type == RTE_EVENT_TYPE_ETHDEV) { > ev->mbuf = ssovf_octeontx_wqe_to_pkt(get_work1, > (ev->event >> 20) & 0x7F); > + } else if ((get_work0 & 0xFFFFFFFF) == 0xFFFFFFFF) { Can we make it as unlikely()?