From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FEFE454DE; Mon, 24 Jun 2024 10:28:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D220402DA; Mon, 24 Jun 2024 10:28:39 +0200 (CEST) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id 393124026E for ; Mon, 24 Jun 2024 10:28:38 +0200 (CEST) Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3d23a0a32afso2010358b6e.3 for ; Mon, 24 Jun 2024 01:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719217717; x=1719822517; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fj+Szv3fSDR1pO/P0QT80q0b+HOFNmyNZxINH9Fduwg=; b=I0RfSqVF2pZdu9BZSSQ7txzcs9IjcN8d+wtXMNYxlWfZfallbktG2WPeNkDkzgLCP8 zSyZIkNTog5xNkrmzvJF/c+Xoy0F+z2JDN553bvPybXG1F3CXlOiK/pSVUYhvvW/NGPy 6sCkSMe9k7NVDcwznMAUH5DpvJkgsjfbv9oKLKwCm4bv2/Rxw5+anZUGRNDbPycq0yE5 Nlv/ebxsblh43DzEj/JT3KrNAy+1v5xSOS5izZRKxw3y1V7VkWWaUYybZ6e1PmtLB8jN bV+ezu6GO7qOXaoLMEKE7aFrP6x2t1VaAQgMD+piOx5oH7YjtBhKsTNxxbz9nerf+Lah /r5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719217717; x=1719822517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fj+Szv3fSDR1pO/P0QT80q0b+HOFNmyNZxINH9Fduwg=; b=NRgrKLZfc3fk6cF3bI1zy505jA5be9cCtsFADweoz2tD4IIZJhwlphzjuhog+4TIi1 RwLSuIsq+9/5Bpq6+VjBVVLWk2xlUaTzOgZ0HY6hz6DBRahy2QMJ3IWObbE4YuPqwcEu bLBYYBsyrbQNavwYo0wXKN4S7L/Y6dse2nI1nJKXIboLSRaf2n5J0uJ31NfEQcRvCQ7N 98av/HLsQMyQFfqvf822fBgppzOw6vJc7YAc32O90lh3byyANtvyNVtyo5U41B1S/hwl C+6oB5KYe/3s6691fzo4EpMnJGMFlctanjRYf/oZHJeW7ObrjEYGMmO1h9ygoZ9nevdF tGGg== X-Gm-Message-State: AOJu0YyL07mkmPeXhesHRPVd/BQ1uvAf+jLgSFqdHwuxA+7MynRega2a e62FFadDxuorsKEz1ZAtPSddkovOnbN99EVd6eyyCDZIzYtL61p+163DYKzO4FpJW9sHb/SQJ4j iDpflx82PcOMW1O/L78nukHGYWP8= X-Google-Smtp-Source: AGHT+IHwhPRppDZpZTxF7wd3GxYyCwG/NJVPD4JywXkLiBhgaxLWRuH4Fp7wcOJKmaNBa+IWQ0uOaA/ClFRR6W9Nvog= X-Received: by 2002:a05:6808:2207:b0:3d2:2749:6a8a with SMTP id 5614622812f47-3d54596378dmr5178964b6e.4.1719217715989; Mon, 24 Jun 2024 01:28:35 -0700 (PDT) MIME-Version: 1.0 References: <20240621201248.504989-2-abdullah.sevincer@intel.com> <20240621222408.583464-1-abdullah.sevincer@intel.com> <20240621222408.583464-3-abdullah.sevincer@intel.com> In-Reply-To: <20240621222408.583464-3-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Mon, 24 Jun 2024 13:58:09 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] eventdev: add support for enqueue reorder To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, bruce.richardson@intel.com, pravin.pathak@intel.com, mattias.ronnblom@ericsson.com, manish.aggarwal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jun 22, 2024 at 4:02=E2=80=AFAM Abdullah Sevincer wrote: > > This commit adds support flag to enable enqueue reorder > feature. > > When this flag is enabled in the port configuration PMD > restores dequeue order on enqueue if applications happen to > change it. > > Signed-off-by: Abdullah Sevincer > --- > lib/eventdev/rte_eventdev.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index 08e5f9320b..f4220dd5dc 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -1073,6 +1073,14 @@ rte_event_queue_attr_set(uint8_t dev_id, uint8_t q= ueue_id, uint32_t attr_id, > * @see rte_event_port_setup() > */ > > +#define RTE_EVENT_PORT_CFG_RESTORE_DEQ_ORDER (1ULL << 5) > +/**< Flag to enable feature enqueue reordering to dequeue. > + * The feature restores dequeue order on enqueue if applications > + * happen to change the order. # Is this feature or limitation? # What is the use case for this feature? # If application don't care about ORDER, they can use RTE_SCHED_TYPE_PARALLEL. Right? # Can you share the feature in the context of the below text in specificati= on? ---------------- /* Scheduler type definitions */ #define RTE_SCHED_TYPE_ORDERED 0 /**< Ordered scheduling * * Events from an ordered flow of an event queue can be scheduled to multip= le * ports for concurrent processing while maintaining the original event ord= er, * i.e. the order in which they were first enqueued to that queue. * This scheme allows events pertaining to the same, potentially large, flo= w to * be processed in parallel on multiple cores without incurring any * application-level order restoration logic overhead. * * After events are dequeued from a set of ports, as those events are re-enqueued * to another queue (with the op field set to @ref RTE_EVENT_OP_FORWARD), the event * device restores the original event order - including events returned fro= m all * ports in the set - before the events are placed on the destination queue= , * for subsequent scheduling to ports ----------------- > + * > + * @see rte_event_port_setup() > + */ > + > /** Event port configuration structure */ > struct rte_event_port_conf { > int32_t new_event_threshold; > -- > 2.25.1 >