DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rasesh Mody <rmody@marvell.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code
Date: Tue, 11 Jan 2022 17:34:00 +0530	[thread overview]
Message-ID: <CALBAE1OszP8z_44p6=PnUAk=vc8h6z-hOg_Bz_atsew44s3V4g@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB48326D008AD298D80CF30C4FB5509@PH0PR18MB4832.namprd18.prod.outlook.com>

On Mon, Jan 10, 2022 at 2:13 PM Rasesh Mody <rmody@marvell.com> wrote:
>
> > From: Anatoly Burakov <anatoly.burakov@intel.com>
> > Sent: Tuesday, November 30, 2021 10:29 PM
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Expression "a && 1" is equivalent to just "a", so fix the accidental inclusion of
> > a literal in code.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data
> > collection")
> > Cc: rmody@marvell.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Rasesh Mody <rmody@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks


>
> Thanks!
>
> > ---
> >
> > Notes:
> >     This isn't a bug, this is just a syntactic anomaly, likely a remnant of some
> >     kind of debugging code.
> >
> >     This issue was found with Control Flag [1], which i ran on DPDK codebase
> > just
> >     out of curiosity. This was the only issue worth addressing that the tool
> >     produced output for.
> >
> >     [1] https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__github.com_IntelLabs_control-
> > 2Dflag&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Vhi2FR3R84xPMUtUhj
> > NPxoiMSxcj1IW0xDKEoZ0F00o&m=OrZLdoVFyT0inpO-NpRW-
> > bqCiG9lrnzODBoic5Pwb8qrKh_6y0JbHFKrzJ6vHBQH&s=d76wgQiSey5O9D5N7
> > HhUGNvReAzVZpe4wmjHgXhJI78&e=
> >
> >  drivers/net/qede/qede_debug.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/qede/qede_debug.c
> > b/drivers/net/qede/qede_debug.c index 2297d245c4..ba807ea680 100644
> > --- a/drivers/net/qede/qede_debug.c
> > +++ b/drivers/net/qede/qede_debug.c
> > @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct
> > ecore_hwfn *p_hwfn,
> >
> >       /* Dump MCP HW Dump */
> >       if (qed_grc_is_included(p_hwfn,
> > DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
> > -         !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) &&
> > 1)
> > +         !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
> >               offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
> >                                                  p_ptt,
> >                                                  dump_buf + offset, dump);
> > --
> > 2.25.1
>

      reply	other threads:[~2022-01-11 12:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 16:59 Anatoly Burakov
2022-01-10  7:19 ` Jerin Jacob
2022-01-10  7:35   ` [EXT] " Devendra Singh Rawat
2022-01-10  8:15   ` Igor Russkikh
2022-01-10  8:43 ` [EXT] " Rasesh Mody
2022-01-11 12:04   ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OszP8z_44p6=PnUAk=vc8h6z-hOg_Bz_atsew44s3V4g@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ferruh.yigit@intel.com \
    --cc=irusskikh@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).