From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2699A034F; Tue, 11 Jan 2022 13:04:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 376C3426EF; Tue, 11 Jan 2022 13:04:30 +0100 (CET) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id B0F4F411AE; Tue, 11 Jan 2022 13:04:28 +0100 (CET) Received: by mail-io1-f46.google.com with SMTP id y11so22014900iod.6; Tue, 11 Jan 2022 04:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oM0pUfJIouwaMkJ48e4ZP9S+aZBWE3b2ZBG2uKYsOSI=; b=GNgVCQ26exVUcVwAQL303GTJHPW/Qz7XQhUtixBKclFeofu2a+E/dnUZYNLlFhxNjC AIJ146RL6xjZzWNg3ECQwim8Qu0Cw8HNfTecL8DES+rS9QSuFpBd91OTsGTcvCgE2b3f DSwbJTQ02hqdN4EQ/AaS5Brbz0L3WIY3ts6IBAvQKpNX5ZqdvwHFenFxJUqIZKY8h1Po pIDAMQKOdNY+ZNJHGiXzCXG6M3koDgIsVloYRreJD+8woagGQo6lvmg6Fvk3PzKnZhfi r4H0jKlUilgtvaM8FARM9zghmgMuQ88nHmUsDjYfV755I/J2cLpMi8KaFMd57oH2AhZ1 Bmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oM0pUfJIouwaMkJ48e4ZP9S+aZBWE3b2ZBG2uKYsOSI=; b=j1lTvPuhLepREc7TewFTY1lOT4Fj22P9FkfphwtEmJ0oNXW7MgV4kTW+deFg4JJlv8 4oqA2M3XrMbspPQ58CEBi3In3ebMtidSHHoUQffLXCdQl4G2DlWaYlhydx14xav6VT7O /ESXKujtE0v6w1yNi50Q4xiDI2UHp95vTP/R5h3DWDdAVWgT6XK1/RgAnerffS6YShWw HdntLqkPj6WmdXI4YGV64AY2fOuCeXtnF67n7Xp9tzmpnXXH3AM1ZkOnU16noVXz97PR 0gOAOZEe0Fuwrt7eLdVjhuqqnYwqSL1LaoGL9qGgN7iLa/u6xcTfMbsKg9qgii2/h8cT 07LQ== X-Gm-Message-State: AOAM532UAmEv3hrzBYREfEAiW6EjY5NeiDsO66hEbpHTmiooJP9tgQ4P +BpUhzEAIQbvOpbAK4CKmu9t5i9yBcnpY87RHoo= X-Google-Smtp-Source: ABdhPJzKl2b17MnkWej6YI1dhA6eGNpUJ2dPcAkOLE5BeB5LLzvE9okspz46Mpc6hekX+rpwgN+x3zPgMNvzgtdQoXc= X-Received: by 2002:a02:7048:: with SMTP id f69mr2027996jac.79.1641902666605; Tue, 11 Jan 2022 04:04:26 -0800 (PST) MIME-Version: 1.0 References: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 11 Jan 2022 17:34:00 +0530 Message-ID: Subject: Re: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code To: Rasesh Mody , Ferruh Yigit Cc: Anatoly Burakov , "dev@dpdk.org" , Devendra Singh Rawat , Igor Russkikh , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 10, 2022 at 2:13 PM Rasesh Mody wrote: > > > From: Anatoly Burakov > > Sent: Tuesday, November 30, 2021 10:29 PM > > > > External Email > > > > ---------------------------------------------------------------------- > > Expression "a && 1" is equivalent to just "a", so fix the accidental inclusion of > > a literal in code. > > > > Cc: stable@dpdk.org > > > > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data > > collection") > > Cc: rmody@marvell.com > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Rasesh Mody Applied to dpdk-next-net-mrvl/for-next-net. Thanks > > Thanks! > > > --- > > > > Notes: > > This isn't a bug, this is just a syntactic anomaly, likely a remnant of some > > kind of debugging code. > > > > This issue was found with Control Flag [1], which i ran on DPDK codebase > > just > > out of curiosity. This was the only issue worth addressing that the tool > > produced output for. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__github.com_IntelLabs_control- > > 2Dflag&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Vhi2FR3R84xPMUtUhj > > NPxoiMSxcj1IW0xDKEoZ0F00o&m=OrZLdoVFyT0inpO-NpRW- > > bqCiG9lrnzODBoic5Pwb8qrKh_6y0JbHFKrzJ6vHBQH&s=d76wgQiSey5O9D5N7 > > HhUGNvReAzVZpe4wmjHgXhJI78&e= > > > > drivers/net/qede/qede_debug.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/qede/qede_debug.c > > b/drivers/net/qede/qede_debug.c index 2297d245c4..ba807ea680 100644 > > --- a/drivers/net/qede/qede_debug.c > > +++ b/drivers/net/qede/qede_debug.c > > @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct > > ecore_hwfn *p_hwfn, > > > > /* Dump MCP HW Dump */ > > if (qed_grc_is_included(p_hwfn, > > DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) && > > - !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && > > 1) > > + !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP)) > > offset += qed_grc_dump_mcp_hw_dump(p_hwfn, > > p_ptt, > > dump_buf + offset, dump); > > -- > > 2.25.1 >