Re: [dpdk-dev] [PATCH] mempool/octeontx: fix error handling in initialization

[Jerin Jacob <jerinjacobk@gmail.com>]

On Thu, Dec 19, 2019 at 4:14 PM <kkanas@marvell.com> wrote:
>
> From: Krzysztof Kanas <kkanas@marvell.com>
>
> When octeontx_get_fpavf fails fpa pointer is used to get
> pool_stack_base, which is then freed.
>
> Coverity issue: 351263
>
> Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation")
> Cc: pbhagavatula@marvell.com

Cc: stable@dpdk.org

> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index c97267db3cc3..63f8fb3b500a 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -305,10 +305,8 @@ octeontx_fpapf_pool_destroy(unsigned int gpool_index)
>         int ret = -1;
>
>         fpa = octeontx_get_fpavf(gpool_index);
> -       if (fpa == NULL) {
> -               ret = -EINVAL;
> -               goto err;
> -       }
> +       if (fpa == NULL)
> +               return -EINVAL;
>
>         hdr.coproc = FPA_COPROC;
>         hdr.msg = FPA_CONFIGSET;
> --
> 2.21.0
>