From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDEBF42C3C; Tue, 6 Jun 2023 08:40:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6EE740A84; Tue, 6 Jun 2023 08:40:22 +0200 (CEST) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mails.dpdk.org (Postfix) with ESMTP id A2E1640697 for ; Tue, 6 Jun 2023 08:40:20 +0200 (CEST) Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-461b6c85a28so1440321e0c.0 for ; Mon, 05 Jun 2023 23:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686033620; x=1688625620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=khOujbBWtD3aSFokG3o7HhHC7WANrCUIY/f9IwHdc8o=; b=UvtjfJbIyGBzOAirWERDjE7GFH20CQ8LV+35obCaHIpEo4adj1XXy4DezbC1EhvUxW KgxQ/jvTvQks3Xa05mleSN84LsHAJ8IkZIwnISCswkklwvHZgZsfVWWyYdoMqy9QUotL LBA+qzYphn89G5CZ7wtE/FQrRNJTFCgbY+GE7oURSSRUnwUKfDYoK09PwAft0aK9c6gE bemg0JXfdWw68+v9iLkScqZ8yn5Ka6LWc+FpzeBINoK3a0z33ifFDZWH3vdNrs34u/gV kifx1W47+9cQepK2EQLm0yEgE9W5pigf2p2p8Ewd+e1le8/COKaiuAHUk8XyWlG36LCI 1c0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686033620; x=1688625620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=khOujbBWtD3aSFokG3o7HhHC7WANrCUIY/f9IwHdc8o=; b=N88kbLMFtlwRHEbxWBXkudRhr0uwI7Ghh4f62EXR/DERAbCBt7HykAxvvd5O/SbckL zZZHTQhHGI6sdhmozNaqVOLWNP6EgKEwcB/Ob0gex0j8SryQ1UKE+e10I65ZnBoLxO2f HN9QINE35ZGGIkXieamQZYMtY6KA7uqiFPGLuxTkReZp4J1BllDylKvWmU/oProPzRfB 6IzoghAMahCh0jLvgxGqti7TTcNXobuI59cxDhlRsnsCeJPi/srWIIuT7KPIjcerIW4s nPsiG3JXTXN+DVRtEu+5lqiM22rancHz9Sk/2eFd4BnKTWB8BNYem4WIrtTTEuFS992t z4iA== X-Gm-Message-State: AC+VfDwS+aUb+5HGJGIE5QGVEMeUOj4Xsua/TW613zCl9Y+MTvG38ZRX M6HDaIb+hPlyB8k0bavLmhAT9RYmVJ+UzV6wf8Q= X-Google-Smtp-Source: ACHHUZ6FSKfWiUlYgOKFSYW20srQFEDVvoDCp271P+dGlmlVstRsY78OouSLPWZz+4G7/erDs2Mtu1SqDLY5YSvj0U0= X-Received: by 2002:a05:6102:2e3:b0:439:4112:814 with SMTP id j3-20020a05610202e300b0043941120814mr772831vsj.2.1686033619760; Mon, 05 Jun 2023 23:40:19 -0700 (PDT) MIME-Version: 1.0 References: <20230509060347.1237884-1-zhirun.yan@intel.com> <20230605111923.3772260-1-zhirun.yan@intel.com> <20230605111923.3772260-5-zhirun.yan@intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 6 Jun 2023 12:09:53 +0530 Message-ID: Subject: Re: [PATCH v7 04/17] graph: add get/set graph worker model APIs To: "Yan, Zhirun" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 6, 2023 at 12:04=E2=80=AFPM Yan, Zhirun = wrote: > > > > > > > > > And change it to > > > > > > If (!graph_model_is_valid()) { > > > model =3D RTE_GRAPH_MODEL_DEFAULT; > > > > Since it returning from below, Do we need to update model? > > > No, no need to update it. I reset model here cause I want to reset all gr= aph->model, > But miss the graph loop. I think it is no need to update all graph->model= also. > I will remove it and return directly. > > > > return -EINVAL; > > > } > > > STAILQ_FOREACH(graph, graph_head, next) > > > graph->graph->model =3D model; > > > > graph->model =3D model. Right? > No. This graph is struct graph, and we put model into struct rte_graph. > So it is > (struct graph) graph -> (struct rte_graph *) graph -> model Got it.