From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C405A0C43; Tue, 16 Nov 2021 08:07:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95FC140141; Tue, 16 Nov 2021 08:07:34 +0100 (CET) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 6DDA340040 for ; Tue, 16 Nov 2021 08:07:33 +0100 (CET) Received: by mail-io1-f43.google.com with SMTP id z26so24721790iod.10 for ; Mon, 15 Nov 2021 23:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KKGo+DHX5ULQEgIAXgRkcMsV0GVV644XCMOZ6G0dwws=; b=VM3XBe+EsTPiiQLy45df8EjlKAqcP4BoicXhKESx7Pd8NG3rLG2+MOy7xHIrk3RAlQ TGaaRoWrrREUeuGKE22iDZ0r9g/A8hT7hIl19PvwNBlqlBO/Zu0/UJagSI/pZCpeOb8J bNz0fKEuXbJBrz4y5TC1MVZqFTZ+4vW0Mx334ULIweSAhxfgkKIbj7kjl3UHRrEPFDIz IY5MD6sT9sTz6HbNREEYVVdiXo2ZNj87wWKkj5oEwc9HJzwADKPDXQMiY10mrshAreve fICvqhwfRVCDsi2PnBWCaePYxn4i2iQ4hC2FQFMjAG5n+fI5Fi9BCRpxxx5ZHrIcn5IE 9Dow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KKGo+DHX5ULQEgIAXgRkcMsV0GVV644XCMOZ6G0dwws=; b=f2CKazycFKvRFqBLm/JUPiR4xP8RBlo+CnTYrt6RrubayCrZ2TsQpL10GhGy5s9kNI NK/o+NIk207NpSt4R5HxWthJKPEdTMh6YpoXK7tdVcfrYFLDlcAu+HbATNuhjccM9Hg7 1PBJIi67TNtO/PmnsQGBdba8ueZCeTHWda/y/D6YRECeNcfZ8HothnLKAihtYJ7b/PaC +4RQLGVyUbx0kYpvn6eIsXsMtA4MB9YFVdfv9diQ69Y77T+2DDf5qe1DoszZSb+TeTLE rhnC0XHqL4Vp+sOGQ6ptYGDo5ljIJ5kETMMWxXUQn9DXjdMAsA9jdMgv2n/D1k2GWKfC pcAg== X-Gm-Message-State: AOAM532Js/1n96ykWGTtRKyst/CJ+tiO70Dvco5iXLmLhl0o9Cgg1HXk mCX+kxdxS+Mu3j39VXlTfcmisO1Md/72Ra3cfgTkMua1DQg= X-Google-Smtp-Source: ABdhPJyYwUi99TEgbg86nkLyJuFBTMJHBcPgp4f5oxLe6WlkkhVaTIA7OfeHuP9BigHg683upP3D/v2MXWhlol3B2Gw= X-Received: by 2002:a05:6638:1346:: with SMTP id u6mr3768369jad.126.1637046452639; Mon, 15 Nov 2021 23:07:32 -0800 (PST) MIME-Version: 1.0 References: <20211112194857.1342664-1-rashmi.shetty@intel.com> <20211115163445.1438809-1-rashmi.shetty@intel.com> In-Reply-To: <20211115163445.1438809-1-rashmi.shetty@intel.com> From: Jerin Jacob Date: Tue, 16 Nov 2021 12:37:06 +0530 Message-ID: Subject: Re: [PATCH v2] event/dlb2: fix delayed_pop test in dlb2_selftest To: Rashmi Shetty Cc: dpdk-dev , Jerin Jacob , "Van Haaren, Harry" , "Pathak, Pravin" , "Chen, Mike Ximing" , "McDaniel, Timothy" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 15, 2021 at 10:04 PM Rashmi Shetty wrote: > > Number of events scheduled and available for dequeue > after token pop was set to dequeue_depth-1 instead of > dequeue_depth in test_delayed_pop. The expectation is > that all dequeue_depth number of events can be dequeued > once the last event is released. > > Fixes: a10e8e96865f ("event/dlb2: add delayed token pop logic") > > Signed-off-by: Rashmi Shetty > > --- > > v2: > - Updated commit message with 'Fixes' tag (Jerin) Update git commit as Author: Rashmi Shetty Date: Mon Nov 15 10:34:44 2021 -0600 event/dlb2: fix delayed pop test in selftest Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1 instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of events can be dequeued once the last event is released. Fixes: 07d55c418d47 ("event/dlb2: add delayed token pop logic") Cc: stable@dpdk.org Signed-off-by: Rashmi Shetty Reviewed-by: Mike Ximing Chen Applied to dpdk-next-net-eventdev/for-main. Thanks > > --- > drivers/event/dlb2/dlb2_selftest.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c > index 5cf66c552c..2113bc2c99 100644 > --- a/drivers/event/dlb2/dlb2_selftest.c > +++ b/drivers/event/dlb2/dlb2_selftest.c > @@ -1354,7 +1354,7 @@ test_delayed_pop(void) > } > > /* Release one more event. This will trigger the token pop, and > - * dequeue_depth - 1 more events will be scheduled to the device. > + * dequeue_depth more events will be scheduled to the device. > */ > ev.op = RTE_EVENT_OP_RELEASE; > > @@ -1366,7 +1366,7 @@ test_delayed_pop(void) > > timeout = 0xFFFFFFFFF; > > - for (i = 0; i < port_conf.dequeue_depth - 1; i++) { > + for (i = 0; i < port_conf.dequeue_depth; i++) { > if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) { > printf("%d: event dequeue expected to succeed\n", > __LINE__); > @@ -1374,14 +1374,6 @@ test_delayed_pop(void) > } > } > > - timeout = 0x10000; > - > - if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) { > - printf("%d: event dequeue expected to fail\n", > - __LINE__); > - goto err; > - } > - > cleanup(); > return 0; > > -- > 2.25.1 >