From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4473DA0588; Tue, 21 Apr 2020 11:17:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DE151D951; Tue, 21 Apr 2020 11:17:29 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id F3E8F1C21E for ; Tue, 21 Apr 2020 11:17:27 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id o127so14290319iof.0 for ; Tue, 21 Apr 2020 02:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JpLYVe0zJiS+yiQbIqlRGlMGR0BlogPfITJCy0X3Hv0=; b=BCVXKKZuyeItmcFVGIXqSv4uU3x+3D5aEFCknb2zMxIFdjC1Bli9Ymta048Ymz2C4h Z4xW9HDGiPbw/BsAiXbtDpBog9jSPWoXjgR0SO8o81Z4p8nRcmyOGI6I/8aSeIoMzFwc EFom1WAhSEqVNmfjn5PUeOvNsPxOu34p+NmYYQLWTWZ210U9USKOBn6tZEe5rStaeId5 46gEtqB86+c56V99H3CmhajRc33ljg3860qWmMzfTy3PsWJS2WqZYUGbrcxsrDgqCbqY WyOydwvDH5mIKJXy8BriwCQtjr0OysYrBU0TDufRtrWBUFVuqbgUB3JinME5uKDoRInu FEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JpLYVe0zJiS+yiQbIqlRGlMGR0BlogPfITJCy0X3Hv0=; b=IE11wT2knFDjPcsDmpeTMe0DcWC9ltPOVWbh73kedVBSD+oqJ/jU3HY/a8MxRoiYYZ v2RqacXsYG3KbAtOo1TehHuVSxJ1VS7lzzFQM391xa/vo+G9cs7wvfP1njfp69+atF13 M7b6jy3UtsFvxvH2rpLs5BFwZw48rb/EYREheUS2Xkdlb7gVNgIYeQmHN2JeaeDb4IuE 5B+Y20OtZZv1teymOzonxcu/rZv7+4b2JYQIXWJ7wFXZh4dnorbOxL+/bMCaxwi1nXVh R6kIUkgzi6d4xnfYyr59WAX1mzsFcor3ZHEdUofAkruDwrVm28Cf/f+XtR0aOzwox+1l 6EKw== X-Gm-Message-State: AGi0PuZtkMetj92xUXitZ4ma5vYoLzY7vvnkkkJKHApQ+guZu/0+3z40 6TwJDlVPGXRZYXghhPg7TI61Blrm2lwWgxB7suc= X-Google-Smtp-Source: APiQypIw5V0VzW7iFRxGBWceKFf/gtf49XtXBwHN1aaNtm6tVfzJ6TKk00Yrp1yfTPaFulMzyWeoxgOLucF2Z5R5HHA= X-Received: by 2002:a05:6602:21c6:: with SMTP id c6mr19453663ioc.163.1587460647248; Tue, 21 Apr 2020 02:17:27 -0700 (PDT) MIME-Version: 1.0 References: <20200413150116.734047-1-jerinj@marvell.com> <3354690.gORTcIGjah@thomas> <9680747.nUPlyArG6x@thomas> In-Reply-To: <9680747.nUPlyArG6x@thomas> From: Jerin Jacob Date: Tue, 21 Apr 2020 14:47:11 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , dpdk-dev , "Richardson, Bruce" , David Marchand , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 21, 2020 at 2:41 PM Thomas Monjalon wrote: > > 21/04/2020 07:47, Jerin Jacob: > > On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > > > > > Hi, > > > > > > Below is a doc review. > > > General comment: it is better to split lines after punctuation signs > > > in order to make future patches easier to read. > > > > Thanks for the review. > > Except below two comments, Everything else accepted and fixed in v7. > > > > > > + > > > > +Register the tracepoint > > > > +~~~~~~~~~~~~~~~~~~~~~~~ > > > > + > > > > +.. code-block:: c > > > > + > > > > + #define RTE_TRACE_POINT_REGISTER_SELECT /* Select trace point register macros */ > > > > > > I don't understand this #define. > > > > See the headerfile. > > /** > > * Macro to select rte_trace_point_emit_* definition for trace register function > > * > > * rte_trace_point_emit_* emits different definitions for trace function. > > * Application must define RTE_TRACE_POINT_REGISTER_SELECT before including > > * rte_trace_point.h in the C file where RTE_TRACE_POINT_REGISTER used. > > * > > * @see RTE_TRACE_POINT_REGISTER > > */ > > #define RTE_TRACE_POINT_REGISTER_SELECT > > Please add an explanation in the doc about why it is needed, the rationale. As you wish. > > > > > > +Trace file location > > > > +------------------- > > > > + > > > > +On ``rte_trace_save()`` or ``rte_eal_cleanup()`` invocation, the library saves > > > > +the trace buffers to the filesystem. By default, library saves trace files at > > > > +``$HOME/dpdk-traces/rte-yyyy-mm-dd-[AP]M-hh-mm-ss/``. It can be overridden by > > > > > > Please don't create a specific directory, but use rte_eal_get_runtime_dir(). > > > > Trace files are huge in size, /var/run is not the correct place to store it. > > User needs to have control over where the trace file generated.It can > > be different than rte_eal_get_runtime_dir(). > > Multiple DPDK application running case has been taken care of by using > > eal_get_hugefile_prefix() in trace session creation. > > At least, the default directory should be the runtime_dir I think. > It's not good to create new directories without user approval. Nobody adds log or trace files in /var/run. It is the place to store pid specific low volume information. I checked the LTTng, it creates the $HOME/lttng-traces/ as default. So the current scheme looks good to me. > > > > > +the ``--trace-dir=`` EAL command line option. > > > > > > I don't think this option is needed. > > > XDG_RUNTIME_DIR environment variable can do the same. > > >