From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3895EA058A;
	Fri, 17 Apr 2020 11:38:51 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7E82D1DEEE;
	Fri, 17 Apr 2020 11:38:50 +0200 (CEST)
Received: from mail-io1-f65.google.com (mail-io1-f65.google.com
 [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 7B3731DEE2
 for <dev@dpdk.org>; Fri, 17 Apr 2020 11:38:49 +0200 (CEST)
Received: by mail-io1-f65.google.com with SMTP id f3so1663661ioj.1
 for <dev@dpdk.org>; Fri, 17 Apr 2020 02:38:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=486sVZJPyMQHEIgFAav4nkfPsYXCr5njYWXXk3OVPzM=;
 b=saGcH8I3Vbh0ttI0VGlrjbB6KfGbGSBMKNUl6pAyBOTQ0I0rf/c0A/ccdfBwjJvH+x
 rRgq3BXg8UQ9nTbNoC0uFmnKZD4jrGU6TeONu5f7vkVwtgf5YuCHJrqgXMtkHCo3UDI+
 LQMASzJuq0bggSjuIKBn+2w5SycD8nzGJPToqq/jBZnL5iZIwmpiRCTasOJpnmUjWH+j
 JIQkrhn2WO3pgJX3UjPfvBMdccQNv9eCR8NcniksH6EVKOfdRk1u6UcD0kZ4TlnaniSj
 rlSAcA9TjNII4oDLID1JiDO6PkrcNkT3hz0DeSo23Ii6B7OSMHzD4mimie/drHfPT2BQ
 o7CQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=486sVZJPyMQHEIgFAav4nkfPsYXCr5njYWXXk3OVPzM=;
 b=m6VW/lpNTpuY7tgHTQmXNQqQhW2ZDXQoAMh869p0mtHOq5InuLM4sIQHeDoltfexKW
 HYEj2n/Q6EG7ejzLuIF8PlTG/pIKpExJ/UmcgWq3VK5HZ+hScKGouGosw73TZuyz1h62
 nxrrlyEEBmoueAA3Iu+ihHcLpoIZuctM3mM7mgHGs5KDyA5BAP6+xtXIxpGVuWRfuYuH
 cDX60XkdSaUehUbjgM+uDiCcqTeBgdO2KnyGXHW/YDkXGEz36Zp7huX1Jj5HQ+cXC0o8
 9xMBqukt5QEcHlUIXr3QWNXokqW7GWkXUlqWj7mhlSyyFDzxyvVm8RB7apvSH/HZ+KmH
 0kgA==
X-Gm-Message-State: AGi0PuZRIKa05pqgkTwoQWW9sdyoYcBVN1z9X4sEXdQ0Il4h9epJTGvJ
 2yTa6Px7tah2UUxhDmiE2kQVsqlKEwKo/0XAswY=
X-Google-Smtp-Source: APiQypIfY0Yd7w5bw+seObP4soto6jE8Ve7nyblhY8RG8iI/5SN4rQkZ5rwqFfX6P6jOBRni4KuRpKJNDwEr55AEUqk=
X-Received: by 2002:a05:6602:2f87:: with SMTP id
 u7mr2130056iow.94.1587116328715; 
 Fri, 17 Apr 2020 02:38:48 -0700 (PDT)
MIME-Version: 1.0
References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com>
 <20200416053853.440-1-joyce.kong@arm.com>
 <20200416053853.440-2-joyce.kong@arm.com>
In-Reply-To: <20200416053853.440-2-joyce.kong@arm.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Fri, 17 Apr 2020 15:08:32 +0530
Message-ID: <CALBAE1OyD42JwuscUSqFnk7WKFDe4-Dhfrhy3Zt+JTD4LO30Gw@mail.gmail.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Stephen Hemminger <stephen@networkplumber.org>, 
 David Marchand <david.marchand@redhat.com>,
 =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, 
 Jerin Jacob <jerinj@marvell.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, 
 Ravi Kumar <ravi1.kumar@amd.com>, Rasesh Mody <rmody@marvell.com>, 
 Shahed Shaikh <shshaikh@marvell.com>, Ziyang Xuan <xuanziyang2@huawei.com>, 
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, 
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Gavin Hu <gavin.hu@arm.com>, 
 Phil Yang <phil.yang@arm.com>, nd <nd@arm.com>, dpdk-dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of
 common bit operation APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 16, 2020 at 11:09 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Bitwise operation APIs are defined and used in a lot of PMDs,
> which caused a huge code duplication. To reduce duplication,
> this patch consolidates them into a common API family.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>
> ---
>  MAINTAINERS                         |   4 +
>  doc/api/doxy-api-index.md           |   5 +-
>  lib/librte_eal/include/meson.build  |   1 +
>  lib/librte_eal/include/rte_bitops.h | 258 ++++++++++++++++++++++++++++
>  4 files changed, 266 insertions(+), 2 deletions(-)
>  create mode 100644 lib/librte_eal/include/rte_bitops.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4800f6884..1d5fad28b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -241,6 +241,10 @@ M: Cristian Dumitrescu <cristian.dumitrescu@intel.co=
m>
>  F: lib/librte_eal/include/rte_bitmap.h
>  F: app/test/test_bitmap.c
>
> +Bitops
> +M: Joyce Kong <joyce.kong@arm.com>
> +F: lib/librte_eal/include/rte_bitops.h
> +
>  MCSlock - EXPERIMENTAL
>  M: Phil Yang <phil.yang@arm.com>
>  F: lib/librte_eal/include/generic/rte_mcslock.h
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index dff496be0..b63e782ec 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -9,6 +9,7 @@ API {#index}
>  The public API headers are grouped by topics:
>
>  - **device**:
> +  [bitops]             (@ref rte_bitops.h),

IMO, It may not come in "device" section, instead  existing "**basic**
section is more appropriate.