From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17943A0543; Mon, 13 Jun 2022 07:58:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08113410DD; Mon, 13 Jun 2022 07:58:51 +0200 (CEST) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mails.dpdk.org (Postfix) with ESMTP id 0E25540150; Mon, 13 Jun 2022 07:58:50 +0200 (CEST) Received: by mail-qt1-f182.google.com with SMTP id i25so3275648qtq.0; Sun, 12 Jun 2022 22:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=METFEZxtdMn1tCZrMonQF6Lmogm1nvkGhIDPPHJWb6I=; b=Ne9MtwGXZIPgOSmCN+BUfZfl1yliGqlGBU7dr1owtl8ZBG4JzkSw0Edu/DkauMz6Mu CNaEaH+fh0Z+5iIY/rzghX4VWAuKl1kjckwy+TtsMJdmfeCYrINoG6KznDgVG3Ydr2ZJ 4pJj+V3jdqEooc9dhXuxgMCKT2owxsxs5lDk+ztzNrlasCWODzElr9gwilx140DeYLGR WjgcRri9iwumu5gwMBDwhs+z7yilWzvakjpMwRzY0E7OEp6DPDwMFC2jvWg4sQ7Zy9yS ahernIKxsk7DCigmzSAjaxxlzwTge3t8iOdDVMaGSFY+hXuYJRGh81NfUTK0M0HfaH+A nsEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=METFEZxtdMn1tCZrMonQF6Lmogm1nvkGhIDPPHJWb6I=; b=5NPldFHR3yVrzoR22JsmZMiAAkZfc7LHgrE71dWL+7Rgt6GyABPfdSmMIVjGVtAlKo GPh0C/VSuZef4NUpxF5nIjy3pCjoskwbrd0svcqVnU+8GP9sEuy+YyA4n+1JNPc5xkCz G7AuJjIpMAxBdmR+vEwIBBfrsU60ffFOyy5gHnx6tOIuoSt3OIf/VWbHAL5vckFgpd/y cWpzn3f6kVGwhys/gGdx42Trc0nuAH9NotJZKRjeScmrKDd1liaBXsHzdhhbJahNc+2A WsSSoBMeh0LlnTdRuQ9UZyNRsxbn7MrH0tLYQvaHIEw0tNKAcbFelxIjbGy9610zZtAC vTUQ== X-Gm-Message-State: AOAM531sh31SY0+xgGNE9OWPFLrAM+VlBuc+znDc/gWqx/b8IQssYrAU XUrCFdlrdb7aRK9oSMrT2rKuDfS3ADkFAskuo70= X-Google-Smtp-Source: ABdhPJyRYy8nwbnhj/UoSu3RpDx4NzrkjQ0PJJLoC9LtfxnkEwurRprntTaIKOK9pUlcvrmcvSDSaPMZatUmBbr8hL4= X-Received: by 2002:a05:622a:15d3:b0:304:ef40:9477 with SMTP id d19-20020a05622a15d300b00304ef409477mr29186047qty.502.1655099929481; Sun, 12 Jun 2022 22:58:49 -0700 (PDT) MIME-Version: 1.0 References: <9da85a53252e304aef90f0e54805feaee61b75c5.1653030578.git.sthotton@marvell.com> In-Reply-To: <9da85a53252e304aef90f0e54805feaee61b75c5.1653030578.git.sthotton@marvell.com> From: Jerin Jacob Date: Mon, 13 Jun 2022 11:28:23 +0530 Message-ID: Subject: Re: [PATCH] drivers: fix cnxk event qos devarg processing To: Shijith Thotton Cc: dpdk-dev , Jerin Jacob , Pavan Nikhilesh , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 20, 2022 at 12:41 PM Shijith Thotton wrote: > > Fixed qos parameters getting over written and IAQ/TAQ threshold > calculation. > > Fixes: 910da32c53a9 ("event/cnxk: add device start") > Cc: stable@dpdk.org > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/common/cnxk/roc_sso.c | 4 ++-- > drivers/event/cnxk/cnxk_eventdev.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c > index 358d37a9f2..8251c967fb 100644 > --- a/drivers/common/cnxk/roc_sso.c > +++ b/drivers/common/cnxk/roc_sso.c > @@ -406,10 +406,10 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos, > } > req->grp = qos[i].hwgrp; > req->xaq_limit = (nb_xaq * (xaq_prcnt ? xaq_prcnt : 100)) / 100; > - req->taq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK * > + req->iaq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK * > (iaq_prcnt ? iaq_prcnt : 100)) / > 100; > - req->iaq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK * > + req->taq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK * > (taq_prcnt ? taq_prcnt : 100)) / > 100; > } > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c > index b66f241ef8..2455b7be2d 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -513,10 +513,10 @@ cnxk_sso_start(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn, > > plt_sso_dbg(); > for (i = 0; i < dev->qos_queue_cnt; i++) { > - qos->hwgrp = dev->qos_parse_data[i].queue; > - qos->iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt; > - qos->taq_prcnt = dev->qos_parse_data[i].taq_prcnt; > - qos->xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt; > + qos[i].hwgrp = dev->qos_parse_data[i].queue; > + qos[i].iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt; > + qos[i].taq_prcnt = dev->qos_parse_data[i].taq_prcnt; > + qos[i].xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt; > } > rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt, > dev->xae_cnt); > -- > 2.25.1 >