From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD6C0A0531; Mon, 27 Jan 2020 17:17:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D90E41BFC1; Mon, 27 Jan 2020 17:17:45 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 3F6121BFB6 for ; Mon, 27 Jan 2020 17:17:44 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id z8so10639354ioh.0 for ; Mon, 27 Jan 2020 08:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O5mr8Ukle7MVMA7VMau5p0DXA6gBO+oZHbGRhUv97s8=; b=VxydPWrvG/h/a6TgMZGtr3RNpq5nJdKXIy3Y6Xc5uSsrWftMOXe01e+4JxKxgT9qIx xo+J+j8t53M8BPEkSzC//DvjfY05tOTWwDIgnnh8ymybErrjSxdxzBW6cPaurgo7XaDO dHzqDihCwY5VCDLIj7+wAR+7BuuCeMDdV2nZEJMdgGjlQVGK9hSpLp6qKKBlesJ4jUL0 hClGX6D319wKhcy0ZQn7pRUfxe3EzA38nsPT3+dYIUmpgLoHZmZCehwiWfjHndgCWPFV qQeH+dafG0BMqO16TgYlz/WNog2RrzqkJwY9XDWlRD2jqcFmjxPldOJdI/EF5gRMySO0 V/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O5mr8Ukle7MVMA7VMau5p0DXA6gBO+oZHbGRhUv97s8=; b=pkdDE+0sf1UvN+vJpMIBBjDBIu0f1VbbllsmtFE8q8IRxA3M02pGFAFiBfjLIjFXkV ssGxweKLwbmWS2RdthYX8UuVbpMRlOMp8dEqfoTm1QbAQZQFqKHvJJcl0J84jK3jrkzp rmABlIW24qfHr0DPeW0WZ5ZJxaqVzr83qkkHpbAWMtvK0Co3a5212VwLF8FxbeqIF94M iLzaVwrsNSnasilUibG1KlSzPFhixIGmWmrAunz25y1uE38UmLTl+NRJVIpuxhKKVZdK qCG6/jn1Ed4JfDaK7OgE3o8uX6arh/MsPLNazeixJviEf9lC6DP0Pr5F4MvcCxSMYBed NPZg== X-Gm-Message-State: APjAAAXoMJ+Zjg+Rk7nyMJx49eXR0A67ATXq6aMiddlJys3jW0cJfF7k WsYn9fQS69lniVLYnZExcjIu+QJjHj6hmt1xe6g= X-Google-Smtp-Source: APXvYqzdq1gbZGwJfj52BqvHfB6i5S1KUKSv/tBxVo4WyXcd2Gj9nlUmzRuHHyLJ3lg1LJzlc/PswQLqLjhsVWm1a78= X-Received: by 2002:a6b:c742:: with SMTP id x63mr13180502iof.162.1580141862933; Mon, 27 Jan 2020 08:17:42 -0800 (PST) MIME-Version: 1.0 References: <20200122182817.1667-1-pbhagavatula@marvell.com> <20200124040542.2360-1-pbhagavatula@marvell.com> In-Reply-To: <20200124040542.2360-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Mon, 27 Jan 2020 21:47:26 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , "Ananyev, Konstantin" , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 00/11] example/l3fwd: introduce event device support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 24, 2020 at 9:35 AM wrote: > > From: Pavan Nikhilesh > > This patchset adds support for event mode in l3fwd. > The poll mode is still the default mode of operation. > > The following new command line parameters are added: > --mode: Dictates the mode of operation either poll or event. If unset then > by default poll mode is used. > --eventq_sched: Dictates event synchronization mode i.e. either ordered, > atomic or parallel. > --event-eth-rxqs: Number of ethernet RX queues per device. > > Based on event device capability the configuration is done as follows: > - A single event device is enabled. > - The number of event ports is equal to the number of worker > cores enabled in the core mask. Additional event ports might > be configured based on Rx/Tx adapter capability. > - The number of event queues is equal to the number of ethernet > ports. If Tx adapter doesn't have internal port capability then > an additional single link event queue is used to enqueue events > to Tx adapter. > - Each event port is linked to all existing event queues. > - Dedicated Rx/Tx adapters for each Ethernet port. This series looks good to me. I have verified that there is no poll mode per core performance impact with this change. I will merge the next version on Tuesday for rc2 if there are no more comments from the mailing list. With below changes, Series-Acked-by: Jerin Jacob # Please rebase the release note to next-eventdev # Fix the following typos ### examples/l3fwd: add event device configuration WARNING:TYPO_SPELLING: 'configurtion' may be misspelled - perhaps 'configuration'? #119: FILE: examples/l3fwd/l3fwd_event_generic.c:34: + /* Event device configurtion */ WARNING:TYPO_SPELLING: 'configurtion' may be misspelled - perhaps 'configuration'? #207: FILE: examples/l3fwd/l3fwd_event_internal_port.c:34: + /* Event device configurtion */ total: 0 errors, 2 warnings, 230 lines checked ### examples/l3fwd: add event eth Rx/Tx adapter setup WARNING:TYPO_SPELLING: 'memery' may be misspelled - perhaps 'memory'? #67: FILE: examples/l3fwd/l3fwd_event_generic.c:208: + rte_panic("Failed to allocate memery for Rx adapter\n"); WARNING:TYPO_SPELLING: 'memery' may be misspelled - perhaps 'memory'? #111: FILE: examples/l3fwd/l3fwd_event_generic.c:252: + rte_panic("Failed to allocate memery for Rx adapter\n"); WARNING:TYPO_SPELLING: 'memery' may be misspelled - perhaps 'memory'? #198: FILE: examples/l3fwd/l3fwd_event_internal_port.c:207: + rte_panic("Failed to allocate memery for Rx adapter\n"); WARNING:TYPO_SPELLING: 'memery' may be misspelled - perhaps 'memory'? #236: FILE: examples/l3fwd/l3fwd_event_internal_port.c:245: + rte_panic("Failed to allocate memery for Rx adapter\n"); total: 0 errors, 4 warnings, 239 lines checked > > v5 Changes: > ---------- > - Update release notes and MAINTAINERS file. > - Fix typo in doc. > > v4 Changes: > ---------- > - Update documentation about --event-eth-rxqs. (Jerin) > - Add validation for command line options that are specific to event/poll mode. > - Fix event device service initialization. > > v3 Changes: > ---------- > - Unify argument parsing. > - Segregate poll mode and event mode initialization. > - Simplify event resource creation and accesses. > - Integrate http://patches.dpdk.org/project/dpdk/list/?series=8002 series. > - Reduce code duplication in lpm. > > v2 Changes: > ---------- > - Shorten the structure name `s/event_rsrc/evt_rsrc` `s/l2fwd_rsrc/rsrc`. > - Use rte_panic instead of rte_exit. > - Rebase on top of Tx adapter change http://patches.dpdk.org/patch/60971. > - Add parallel mode support. > - Fix missing eventdev args parsing. > > Pavan Nikhilesh (7): > examples/l3fwd: add event device configuration > examples/l3fwd: add event eth Rx/Tx adapter setup > examples/l3fwd: add service core setup based on caps > examples/l3fwd: add event lpm main loop > examples/l3fwd: add event em main loop > examples/l3fwd: add graceful teardown for eventdevice > doc: update l3fwd user guide to support eventdev > > Sunil Kumar Kori (4): > examples/l3fwd: add framework for event device > examples/l3fwd: split pipelines based on capability > examples/l3fwd: add ethdev setup based on eventdev > examples/l3fwd: add event port and queue setup > > MAINTAINERS | 1 + > doc/guides/rel_notes/release_20_02.rst | 5 + > doc/guides/sample_app_ug/l3_forward.rst | 79 ++++- > examples/l3fwd/Makefile | 3 +- > examples/l3fwd/l3fwd.h | 30 ++ > examples/l3fwd/l3fwd_em.c | 177 +++++++++++ > examples/l3fwd/l3fwd_em.h | 159 +++++++--- > examples/l3fwd/l3fwd_em_hlm.h | 131 ++++++++ > examples/l3fwd/l3fwd_em_sequential.h | 26 ++ > examples/l3fwd/l3fwd_event.c | 263 ++++++++++++++++ > examples/l3fwd/l3fwd_event.h | 86 ++++++ > examples/l3fwd/l3fwd_event_generic.c | 303 ++++++++++++++++++ > examples/l3fwd/l3fwd_event_internal_port.c | 279 +++++++++++++++++ > examples/l3fwd/l3fwd_lpm.c | 203 ++++++++++++ > examples/l3fwd/main.c | 341 +++++++++++++++++---- > examples/l3fwd/meson.build | 5 +- > 16 files changed, 1976 insertions(+), 115 deletions(-) > create mode 100644 examples/l3fwd/l3fwd_event.c > create mode 100644 examples/l3fwd/l3fwd_event.h > create mode 100644 examples/l3fwd/l3fwd_event_generic.c > create mode 100644 examples/l3fwd/l3fwd_event_internal_port.c > > -- > 2.17.1 >