From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8023AA0C4B; Tue, 16 Nov 2021 20:21:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1923641142; Tue, 16 Nov 2021 20:21:42 +0100 (CET) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by mails.dpdk.org (Postfix) with ESMTP id D915B40141 for ; Tue, 16 Nov 2021 20:21:40 +0100 (CET) Received: by mail-il1-f178.google.com with SMTP id x9so259615ilu.6 for ; Tue, 16 Nov 2021 11:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GKpfmSkBR0jU/6/scfbYne8Uz8MkYlx4BsxGdGhT3t0=; b=px70mE8Sbkb5kYM0S8SDeZ+KvrHoV1lvddfyu1EvVp6jhRuY0eJqh1dBaqEmPCsIX4 YgmlY1u0EnOJ1ANUvx1Mrf3I4dvqnuHP27dZL536FBTk/VxJHrUI4yny+ZWgPJ6VBAdE m0icBVVNifofjjrpQzzcw6L4nzw2wI5ZWqugJawArE6WGBN5s2fvhSFjddOsnZ4TBcSt YewxdbpbFosmOzJqlm/rQEHEOxx/8nhGLM9wmRolgaT0LkFdane3pG9QKseYGvPUDYF/ PZjH9kS7uPkwSyWcDRv6ugAaQ4/RMGrR0D3Ulne1980mT/+HwsR6Wpq69CESoTKd3VZY s2+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GKpfmSkBR0jU/6/scfbYne8Uz8MkYlx4BsxGdGhT3t0=; b=3C7WaDFVn8vMkFT+FyEfcbNBpXtMHCxGWxD1WVwofx0QLyZQvdUcX1mNAweJgpsHjq ezSZelUJB8EkhM0J0ZWFnxXjWpKFB47kkwqpY6zLiUJ8SpdwzOYvZxfYeA8+VTkLZkMl B1DztXB++56rMle23UXJMfN7L4TxBknJSvM06CRTOCRLh3pA/K5kPRxXdoo7eA6ZkSQ2 3/gg5Y7jOh/h+MHZYXIkBhhqz4ioyneEnSkxwDIbexJdhQ/LoMGOj+QduINqIVBs23gn APU24A46fMMJ+wUFnX1MtsW0fg6mDcAWh0j+Ilc2Lgg88mtJNEP/tO+fYHPfJinD3xQN ANqQ== X-Gm-Message-State: AOAM5325gTvDCzwGjKjYmFX5s374cSpDwzVUlxHPEKhGIBCeIhe8zYqj rcRTtLD38MaoWjiybr/8E4ZujVWu+S/fOrZziHk= X-Google-Smtp-Source: ABdhPJwqtXcTxe3TFBE38duKESz9XKzST7dsKaCX+HiBM6pAbXWTcLocNAx8SaMvecIvnauFvRfl8ERWKEEB5nTCBHg= X-Received: by 2002:a05:6e02:1bcb:: with SMTP id x11mr5874260ilv.94.1637090500114; Tue, 16 Nov 2021 11:21:40 -0800 (PST) MIME-Version: 1.0 References: <20211029204909.21318-1-eagostini@nvidia.com> <20211111214141.26612-1-eagostini@nvidia.com> <20211111214141.26612-2-eagostini@nvidia.com> <569619d5-12fc-4338-3042-3581074ad3a9@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 17 Nov 2021 00:51:13 +0530 Message-ID: Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine To: Elena Agostini Cc: Ferruh Yigit , "dev@dpdk.org" , Slava Ovsiienko Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 12:44 AM Elena Agostini wrote: > > > From: Jerin Jacob > > > Date: Tuesday, 16 November 2021 at 20:09 > > > To: Ferruh Yigit > > > Cc: Elena Agostini , dev@dpdk.org , Slava Ovsiienko > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > > > External email: Use caution opening links or attachments > > > > > > > > > On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit wrote: > > > > > > > > On 11/16/2021 6:06 PM, Elena Agostini wrote: > > > > > > From: Ferruh Yigit > > > > > > > > > > > Date: Tuesday, 16 November 2021 at 19:00 > > > > > > > > > > > To: Elena Agostini > > > > > > > > > > > Cc: dev@dpdk.org , Slava Ovsiienko > > > > > > > > > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > > > > > > > > > > > External email: Use caution opening links or attachments> > > > > > > > > > > > > > > > > > > > > > > On 11/11/2021 9:41 PM, eagostini@nvidia.com wrote: > > > > > > > > > > > > --- a/app/test-pmd/meson.build > > > > > > > > > > > > +++ b/app/test-pmd/meson.build > > > > > > > > > > > > @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON') > > > > > > > > > > > > ext_deps += jansson_dep > > > > > > > > > > > > endif > > > > > > > > > > > > > > > > > > > > > > > > -deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci'] > > > > > > > > > > > > +deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci', 'gpudev']> > > > > > > > > > > > I didn't review the set, but in a very high level do we want to add > > > > > > > > > > > 'gpudev' as dependency? Isn't this like adding 'rawdev' as dependency. > > > > > > > > > > gpudev is a library that can be built without a gpu driver as all the other libraries > > > > > > > > > > and itis actually used only in case of GPU memory mempool. > > > > > > > > > > Reasons for this patch are: > > > > > > > > > > - Have an upstreamed benchmark tool to measure network metrics using GPU memory > > > > > > > > > > - Test some DPDK features not really tested anywhere like the external memory mempool feature > > > > > > > > > > > > > I can see the reason, that is obvious, yet again why we are not adding rawdev > > > > testing to the testpmd? But adding gpudev. > > > > It is easier to add it to the testpmd, and for some testing perspective it > > > > makes sense, but still I am not quite sure about this new dependency, I would > > > > like to get more feedback. > > > > > > I had the similar concern earlier. IMO, It is better to have a > > > separate test application for gpudev like > > > other device classes. For eventdev cases when it needs to work with > > > ethdev for Rx adapter cases, > > > We have enabled such code in app/test-eventdev to make testpmd focus on ethdev. > > > > gpudev already has a test app in app/test-gpudev. > > > > gpudev needs to be also test with network card and today another application > > decidated to test gpudev over the network would be very similar to testpmd io. > > > > At this stage, there is no point in reinventing the wheel I think, it is not about not reinventing the wheel, It is about maintenance of testpmd, currently, the feature are specific to ethdev. Adding more cross-device-specific features will populate the testpmd. I had a similar case when it network cases need to be integrated to eventdev, I choose to have it test-eventdev so that testpmd focus remains for ethdev.