From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BA9DA0C43; Mon, 15 Nov 2021 09:29:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 092DB40E01; Mon, 15 Nov 2021 09:29:44 +0100 (CET) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 99B9C40141 for ; Mon, 15 Nov 2021 09:29:42 +0100 (CET) Received: by mail-io1-f48.google.com with SMTP id m9so20260932iop.0 for ; Mon, 15 Nov 2021 00:29:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nahOzGTIIWGF4IWjCBJSgM0OWWQUtO/Q4ck+Y5IOeC8=; b=FNHpBNYf0dGJVszh7X3cZS+N1/PJL54IRP1pgsYCw5lUTCZLY5XaOpUr4NdADbmqJ9 /Q27nc1HcdfqxUAw7Sjat8qpWXiXdg27ncN2JrwEadgh2D9jKXxTBMmx0HI1q+T0myFu KbCYHJzau6QQ0M/4zoIFLk2t8bB+KxbGK9HB9bu8QMvOqUN+eHRpHKMLE6+kuJQM+x3D hp4M72DT0awO44/+Ret1091TNZ0SK8/u8GVxZbDERxFLnQVOOinbF8buoZPM67IWH8RS rWGM+0OHjQz4kjnVTxj8RN01Shf2KJqgscr80J9eSlW4amEECzjwZfKP4l+C4dNceaLy O4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nahOzGTIIWGF4IWjCBJSgM0OWWQUtO/Q4ck+Y5IOeC8=; b=emq/p3Wsp8zVoGoV+5pCyHEFdR2xlIVLUaWs0DU+DSvwyKRxKj2Is2+93Tb7Yh7t8S rwm+o71lxpexAvQ55FvjD0b4LMhZvU3a63898ZE/1q3KpoZKChpF4P4R+DE1TuCZ5TTp QrSbSG4LpzOdSeMrXCmyiaHIcWJiFYMsbNxxzkqqW9B2/YOkCbWVjw7YwJ47bEAbzxRx S5L/4isy38NyOpbV0RRXv4W7Ly+4ULbNeJ6pII/d0JxXIFkxDyRklJRHZu9hcu5YF/e+ m1kox2ob89kIm/Z9Ovsa01FGKywXtY8QW4CuQjoI16Cg7YuHNP/tio+fMPretxzFBKng xE1g== X-Gm-Message-State: AOAM533VO0P9FlY0Ee77RGP3DRT63R3GWMqo3jNvzynEiBPvTN+t/VEz QfP1LzKAblr/HX+dNnkREd+70LkekbbVVbjA5Fg= X-Google-Smtp-Source: ABdhPJxPochZitRvEXHVzTUQcMbUSO1NKIuyTRcDlp68rXJpZtfaWjjEBqd27nxFA7+RVMkYeVT18stBOju/viF6SUE= X-Received: by 2002:a05:6638:2395:: with SMTP id q21mr27564475jat.48.1636964981694; Mon, 15 Nov 2021 00:29:41 -0800 (PST) MIME-Version: 1.0 References: <20211112194857.1342664-1-rashmi.shetty@intel.com> In-Reply-To: From: Jerin Jacob Date: Mon, 15 Nov 2021 13:59:15 +0530 Message-ID: Subject: Re: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest To: "Chen, Mike Ximing" Cc: "Shetty, Rashmi" , "dev@dpdk.org" , "jerinj@marvell.com" , "Van Haaren, Harry" , "Pathak, Pravin" , "McDaniel, Timothy" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Nov 13, 2021 at 2:33 AM Chen, Mike Ximing wrote: > > > > > -----Original Message----- > > From: Shetty, Rashmi > > Sent: Friday, November 12, 2021 2:49 PM > > To: dev@dpdk.org > > Cc: jerinj@marvell.com; Van Haaren, Harry ; Pathak, Pravin > > ; Chen, Mike Ximing ; McDaniel, Timothy > > ; Shetty, Rashmi > > Subject: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest > > > > Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1 > > instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of > > events can be dequeued once the last event is released. > > > > Signed-off-by: Rashmi Shetty > > --- > > drivers/event/dlb2/dlb2_selftest.c | 12 ++---------- > > 1 file changed, 2 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c > > index 5cf66c552c..2113bc2c99 100644 > > --- a/drivers/event/dlb2/dlb2_selftest.c > > +++ b/drivers/event/dlb2/dlb2_selftest.c > > @@ -1354,7 +1354,7 @@ test_delayed_pop(void) > > } > > > > /* Release one more event. This will trigger the token pop, and > > - * dequeue_depth - 1 more events will be scheduled to the device. > > + * dequeue_depth more events will be scheduled to the device. > > */ > > ev.op = RTE_EVENT_OP_RELEASE; > > > > @@ -1366,7 +1366,7 @@ test_delayed_pop(void) > > > > timeout = 0xFFFFFFFFF; > > > > - for (i = 0; i < port_conf.dequeue_depth - 1; i++) { > > + for (i = 0; i < port_conf.dequeue_depth; i++) { > > if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) { > > printf("%d: event dequeue expected to succeed\n", > > __LINE__); > > @@ -1374,14 +1374,6 @@ test_delayed_pop(void) > > } > > } > > > > - timeout = 0x10000; > > - > > - if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) { > > - printf("%d: event dequeue expected to fail\n", > > - __LINE__); > > - goto err; > > - } > > - > > cleanup(); > > return 0; > > > > -- > > 2.25.1 > > Looks good. > Reviewed-by: Mike Ximing Chen Please fix [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1 Wrong headline format: event/dlb2: fix delayed_pop test in dlb2_selftest Missing 'Fixes' tag: event/dlb2: fix delayed_pop test in dlb2_selftest