From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D933EA04F3; Fri, 20 Dec 2019 04:45:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 112A11BE3D; Fri, 20 Dec 2019 04:45:41 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 168DF1BDFD; Fri, 20 Dec 2019 04:45:40 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id i11so7995850ioi.12; Thu, 19 Dec 2019 19:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6aMs799pi20HmMojKx9GefbXVU69ZN8XWMzPBzRLDnA=; b=ipa1Y3PAYTgZt6eg3oEPccTKLJfhNuR4Jf75eOJQeaDZLpO+V+jAh3nLJb03Hg2Y3+ eqeohfy+ANU7WcfpVzCs7N2SayajveaFJS+hZ240gxltFWk/srDvZYsUSoIUoq5SUueM aho6SNa/zRZF4hdpNnXqbnTuJBv2k5KuKSQLjNqTRXexNU88ccON8Nw9cqdEoWU1eqGQ p9n793byOjXAwUuHHgmiQRWr0qrsv1ZUYVGY3SQQwRAAV0yD/EEDn25/+QRlR/qxLm6x Uco7iBfJFXGAwbiJUOQ0HyvbheRQKiyl7sdrs9IEjc0heTw9MUwBt5uZ+D1wAerv55dc RyQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6aMs799pi20HmMojKx9GefbXVU69ZN8XWMzPBzRLDnA=; b=ZpbFY95lYGZy5LZc5liaj4eZvubs0VeAHhgiw0JyV+bc0ugfB6GlRF9GyWYNQqdcKm dzEGqd9221Va0i0i9rtwuc/7EefuyaVjmYI/SKMX5lnlBD2Cxvi+wcjw7UwKk0KXLgaD X3ScE0WHXLhOQcYlRY2Ffyrswyg2dxet+jcrOvGDU68HAFAj4aymHXRJQCjBq4jKg8FE p2zpigoPxGDahccxNfcJf1h2hmY9kYfRLSOioadoqqussX30gw9CXpwJ1Q/HSBfgBzry DrnRpm1AIx4fO7VYzUmHxGMQJTDPpK/D+4oZjQsJCZuXVrvvaAjgnIG04WLnTyOVyJkP g3YA== X-Gm-Message-State: APjAAAU7Y20cMbe4G9RH6scUQVr2yAaXeddvKFrGe43xreGmo81E50Hx k6jiZfy+uhgIb1w/nGH23CT8goyEd3SxV1Jye6c= X-Google-Smtp-Source: APXvYqyxvFYSR1Zu9TGhmcNHBy1wuUpBEm35HmhGT3U9RWALf2H+6nt1pNXlo8KsCn5srUm57Co3CYTXY+LLzn8a1Nk= X-Received: by 2002:a5e:8b44:: with SMTP id z4mr8578186iom.271.1576813539326; Thu, 19 Dec 2019 19:45:39 -0800 (PST) MIME-Version: 1.0 References: <20191219134227.3841799-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 20 Dec 2019 09:15:23 +0530 Message-ID: To: Gavin Hu Cc: "jerinj@marvell.com" , "dev@dpdk.org" , "thomas@monjalon.net" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "hemant.agrawal@nxp.com" , "shahafs@mellanox.com" , Honnappa Nagarahalli , "viktorin@rehivetech.com" , "drc@linux.vnet.ibm.com" , "anatoly.burakov@intel.com" , "stable@dpdk.org" , Jerry Hao , nd Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Dec 20, 2019 at 8:56 AM Gavin Hu wrote: > > Hi Jerin, > > It got two coding style warnings, otherwise, > Reviewed-by: Gavin Hu Thanks Gavin for review. Since the existing code is using "unsigned" in that file, I thought of not change by this patch. If someone thinks, It is better to change then I can send v2 by fixing "unsigned" to "unsigned int" across the file as a first patch in the series. > > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' > #144: FILE: lib/librte_mempool/rte_mempool.c:84: > +arch_mem_object_align(unsigned obj_size) > > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' > #154: FILE: lib/librte_mempool/rte_mempool.c:106: > +arch_mem_object_align(unsigned obj_size)