From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB9AA0C50; Mon, 12 Jul 2021 09:59:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69A1F4069E; Mon, 12 Jul 2021 09:59:30 +0200 (CEST) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id 865CB40685 for ; Mon, 12 Jul 2021 09:59:29 +0200 (CEST) Received: by mail-io1-f50.google.com with SMTP id g22so21522161iom.1 for ; Mon, 12 Jul 2021 00:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=D0UizuW0SWRznmHo5v5SejdP9XrN17CYJtgxp2Pz8kc=; b=nLKph3iqPxnEO0yIcIv4YPinjTp5n8yKB6+SIrbAp6VKRD2oGZa4Ff9/gpgiRvUD0i uPGnQhx0+Tq6pm9Dd8T77dY/3R5s4eqBscTXJ/t5aZfimG6XVvmr8ydKoso/ItVdNJHv nDbu/8QjsVF1WnAWE+pv4LEJObepa43mNnbxybzmj3re0rM2HFm60ZqbuhkVHuWZ10zv yENew4ZszFA0PfSRXtr5ZQ8KZB9gTr5l5Af4eBMhUC6KZSEvSDQHjLlc/7FX9YtL44jX +qHZGewj+k+K+dhjODa+CpX2TOrgdArtWO213F64GkvOptoBmVWTacyRZ8no/WhTESEC N/FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=D0UizuW0SWRznmHo5v5SejdP9XrN17CYJtgxp2Pz8kc=; b=XpcAS4zw0OV5xEIT0NdxZPBBvJxgiDuS32HzsQr6qr19KC1V1i9ce6AnPerTcggpE4 0PMkMnJxLXPZGvkCl6FCWbZf02ynC9wcUlnEA3J5/miPoSsmW5HFjTLRhiiwyQFkVVGe 3XJs9/PZZ+KddwWqGd8qcgb6gTM+bBy6yoskMzKvXCsBgteWdKV+kkk6Xibe5v3A/9Gw WM/jDEt/rRTx9gVANV8mKYNy2e3Mx6bC+28uADjmO5uUswZPIKPEkceZ3Qx+b73978Uk gZCbVEzUMLbowUOUaXcSPQIkA2yCUImPO/Nmz/ynUHrTjwjZQz18rcbumbt96qzEaoIm 5yRg== X-Gm-Message-State: AOAM530kJ765zY/wdLWPhRAObqo1MZaBgrtQpgIvbqypj+Zzr2lF+Jry XJYScetFjyCKvozPtDdpQaz2lD4lLW2RI5jgR5Q= X-Google-Smtp-Source: ABdhPJyRSSxkd2EkhPTRxPsT2NSnEypm0MK6meXT/U4lbTOubejb4blybu3xfoN+O77PpcAedr2ggCUDHPPqwHSPqmI= X-Received: by 2002:a5e:a514:: with SMTP id 20mr28688703iog.163.1626076768942; Mon, 12 Jul 2021 00:59:28 -0700 (PDT) MIME-Version: 1.0 References: <9b063d9f-5b52-8e1b-e12a-f24f4ea3b122@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35C618EE@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C618EE@smartserver.smartshare.dk> From: Jerin Jacob Date: Mon, 12 Jul 2021 13:29:02 +0530 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Bruce Richardson , fengchengwen , Thomas Monjalon , Ferruh Yigit , Jerin Jacob , dpdk-dev , Nipun Gupta , Hemant Agrawal , Maxime Coquelin , Honnappa Nagarahalli , David Marchand , Satananda Burla , Prasun Kapoor , "Ananyev, Konstantin" , liangma@liangbit.com, Radha Mohan Chintakuntla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 12, 2021 at 12:31 PM Morten Br=C3=B8rup wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > > Probably we can remove rte_dmadev_fill_sg() variant and keep sg only > > for copy to save 8B. > > Perhaps the scatter/gather functions can be on a separate cache line, fol= lowing the cache line with the simple functions? > Of course, this is only beneficial if the SG functions are not used with = simple functions. > This means that we reserve space for 8 simple functions and 8 SG function= s. Currently, there are only two SG and normal ops functions. IMO, should be to keep all fastpath functions in the same CL irrespective of it is simple or not. My suggestion was more like, if there is no HW support for rte_dmadev_fill_sg() we can remove it from spec. > > And if one or two functions are used with both simple and SG functions, i= t/they can be present in both cache lines. (This is somewhat dirty, but wou= ld be a typical implementation for a DPDK flow data structure.) > > -Morten