From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAA33A04E0; Thu, 28 Nov 2019 12:01:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69D962B96; Thu, 28 Nov 2019 12:01:38 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 1367A293C for ; Thu, 28 Nov 2019 12:01:37 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id b26so26600544ion.7 for ; Thu, 28 Nov 2019 03:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dCSoj3vRBUjnqeXDokYtjeIJeG/SUJ5QSXAR6vnrubs=; b=SMxoHzimFGv0y+z4a7Nk+nxMsg02O0N5mq/dMec7g+qb9E3V7qe/cLMB/pk7DVPiw/ z7HBisoU6CG1iLdUPJzNUTnc/l9kv6ldsRLxsNtsf/EV+FYVCSresT4P+ntxZ6C/+BLs Lji0nVnTJwyxEDGpu6u4WmjuBPwKK8KW85cnswJUBvNAkkFmDlJNN37DM58MnhVTwglE 74eIkeiSoHtdUyVEFdNzKlX2yyKh3TC+sL9h8YrxJmkkBwfr/M/twEwGWkf1FSjueZ8S zSy5ozGv8ozDDg66eUd71AOu1hdnoT/6/mnM6xqN11CbfPb1cHThIXPZZVH87QPWjO4+ ZHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dCSoj3vRBUjnqeXDokYtjeIJeG/SUJ5QSXAR6vnrubs=; b=rLwm8+aK3TsKbfJAARD3q6Rkcl0ZVTjHETMw6NQL4s4X5mZpTsssczM9Ssf9mFNUUC +RN5oR8jpOyO4WBNuPc+/nZQY5mF/SQjzVbv0cLdbk5ReqJ/xs4NtseRYJmuijoioXlh Lva2o11dorIU9IvJigorSQBWr9JnBASIzqnm5BvDotZu+Xey4ip0n8FW0PSzVghoV4KS e2jLz5SNAEL9PVFUJ+n0ZZsk/9KHn00ozQWRvolx2cLYks7fRIYFJ2dXRGyiY/2qpo/S OHF5SSYsnDUeRL+Ok6S/vix0K4PHLkTNWKhn4RXsq4piNHd78FwEEFKegox2+Z6TRvPE 9kXQ== X-Gm-Message-State: APjAAAW3CnYcqMvF9biybRObsD6qA2g4v9S+yfBHi1EQxyxaz/Cmr6P0 k2UxGq4mfUMynJtjMDZMz6IiLfT2r9dN+4jJGdc= X-Google-Smtp-Source: APXvYqzAYUANB1j/kPlPnGb9t4kyGGdmX1hGmsMT0Pac3i9YmD3Is8T3E/wzqaDtWp9fjNiXzwvYExzROCjrCHuyKsk= X-Received: by 2002:a5d:8056:: with SMTP id b22mr37202300ior.60.1574938896119; Thu, 28 Nov 2019 03:01:36 -0800 (PST) MIME-Version: 1.0 References: <20191120160009.46270-1-ferruh.yigit@intel.com> <20191120172227.42798-1-ferruh.yigit@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 28 Nov 2019 20:01:20 +0900 Message-ID: To: Andrew Rybchenko Cc: David Marchand , Vamsi Attunuru , Jerin Jacob , Ferruh Yigit , John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 28, 2019 at 7:45 PM Andrew Rybchenko wrote: > > On 11/21/19 1:30 AM, David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:28 PM David Marchand > > wrote: > >> On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit = wrote: > >>> A build error reported related to the selected > >>> 'get_user_pages_remote()' kernel API: > >>> > >>> .../kernel/linux/kni/kni_dev.h:113:8: > >>> error: too few arguments to function =E2=80=98get_user_pages_remote= =E2=80=99 > >>> ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > >>> ^~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Currently there are three version of the 'get_user_pages_remote()' > >>> supported, based on kernel version > >>> < 4.9, =3D 4.9, > 4.9 > >>> > >>> These version based checks are not working fine with the distro kerne= ls > >>> which is the cause of reported build error. The error reported by the > >>> kernel version 4.8, but it is using API defined in > 4.9. > >>> > >>> To be able to take control of this, and possible more, related build > >>> error, increasing the minimum supported kernel version for iova=3Dva = with > >>> KNI to kernel version 4.9. > >>> > >>> This leaves us with single version of the kernel API and more > >>> manageable. > >>> > >>> Signed-off-by: Ferruh Yigit > > Reviewed-by: David Marchand > > > > We need this change to fix compilation issues for -rc3. > > Applied, thanks. > > The build is still broken on Debian 9 stretch which has Linux 4.9.189, > but corresponding function still has no the last argument. > It looks like requirements should be bumped to >=3D4.10.0. +1 > >