From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3CC342C4D; Wed, 7 Jun 2023 15:58:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50CD240ED5; Wed, 7 Jun 2023 15:58:36 +0200 (CEST) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id 6F99C40A84 for ; Wed, 7 Jun 2023 15:58:35 +0200 (CEST) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-62b67937a6cso8244476d6.3 for ; Wed, 07 Jun 2023 06:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686146314; x=1688738314; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=40BCZzWUXzW1u5ksArOXpqmki9P+EN2XtciGnmPCPA0=; b=If5CayRP/H8ErSjsfGKZsJ5WAnPz9ugWfSatUy3p6YcMq54ph+bkshhftjccT+ibBs +2AGDT9onZt2SwRT3DFsHWAwqpwZ6XJ51GuaoiC2cxf1F7vZhaf5J6D19cSNgxQgOPir xmx+oZTsJP7Rm5oqrkLdiuErGXxzPAuJ1iiZpdOaz9hx3f7Em0ndActq1eyVNojrYIxh 7JIDRc6UVyHxoG9NGHmZ0JWDOAZ2lRInQCYWSHy+x59nU73K7WquPx1vtGLJK8s5HVhQ WMJKAuxOqx8dMKncUmirrJ/C/X4yLNNOzuLeimBoCZzOr+8C6FsSC6gE3Aoy12gxFQsB Ewkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686146314; x=1688738314; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=40BCZzWUXzW1u5ksArOXpqmki9P+EN2XtciGnmPCPA0=; b=lN9SOAt7ISjGFM8w2lEsE8BXvGp7vjLqx5yrtR3nJ51TML+7NzxrR/l1DwyzZGn99o 8EDc2KZy8JFxqRrMH9eGbTK6XcMmq809hjt8v51ZSCqMGS+CO/oWbIpf8LSJYcakyW2O emmlb/yuC5eLleZTLEyZZeL9Wz2N2O5SKgwUb80UffLuO613jdZTlZa0jE/m1TbxAdW3 brPGNuxejQAix2icj3LrxHubXOApxyo7wgSlxQ7V3dKVlh9V5AG8yYH/STbK3NF3lwdH l3dqCwUCnyK8sGXGf3viz+9bSiyDBdo0KfGAmk+gla7UsRUhUMDLAIWtO9+42W1Qw4qJ VUug== X-Gm-Message-State: AC+VfDwk8M8hm3MLBVnnfx2ZZqh9bBQ532pGOgpn5HdGb5v9mt4VkCp1 9ITjTcIu7cGO92P5CYmpE3m/+2axjUTo0Laik+g= X-Google-Smtp-Source: ACHHUZ5g2PwcqwpIZVEo96tOOJydY/fy4C7FfJvNdq0yztbCRpyuMV0RxuErNBETcGwvLA2kHvwYXRtFmI/0Nkjyplk= X-Received: by 2002:a05:6214:628:b0:625:aa1a:9382 with SMTP id a8-20020a056214062800b00625aa1a9382mr3137633qvx.62.1686146314611; Wed, 07 Jun 2023 06:58:34 -0700 (PDT) MIME-Version: 1.0 References: <20230606144746.708388-1-zhirun.yan@intel.com> <20230607035144.1214492-1-zhirun.yan@intel.com> <20230607035144.1214492-16-zhirun.yan@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 7 Jun 2023 19:28:08 +0530 Message-ID: Subject: Re: [PATCH v9 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model To: "Yan, Zhirun" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 7, 2023 at 5:56=E2=80=AFPM Yan, Zhirun w= rote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, June 7, 2023 4:27 PM > > To: Yan, Zhirun > > Cc: dev@dpdk.org; jerinj@marvell.com; kirankumark@marvell.com; > > ndabilpuram@marvell.com; stephen@networkplumber.org; > > pbhagavatula@marvell.com; Liang, Cunming ; Wan= g, > > Haiyue ; mattias.ronnblom > > > > Subject: Re: [PATCH v9 15/17] examples/l3fwd-graph: introduce multicore > > dispatch worker model > > > > On Wed, Jun 7, 2023 at 9:30=E2=80=AFAM Zhirun Yan wrote: > > > > > > Add new parameter "model" to choose mcore dispatch or rtc model. > > > And in dispatch model, the node will affinity to worker core successi= vely. > > > > > > Note: > > > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must > > set > > > model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore > > > dispatch explicitly. GRAPH_MODEL_MCORE_RUNTIME_SELECT means it could > > > choose by model in runtime. > > > > Now no GRAPH_MODEL_MCORE_RUNTIME_SELECT. Right? it same > > as !RTE_GRAPH_MODEL_SELECT > > GRAPH_MODEL_MCORE_RUNTIME_SELECT is defined in app. And it will hit rte_g= raph_walk() > "else" case to get model and select walk_rtc()/walk_dispatch(). Got it. But I think, You can treat !RTE_GRAPH_MODEL_SELECT as GRAPH_MODEL_MCORE_RUNTIME_SELECT without introducing new one by ifndef RTE_GRAPH_MODEL_SELECT. No strong opinion. > > It is not the same as !RTE_GRAPH_MODEL_SELECT. > GRAPH_MODEL_MCORE_RUNTIME_SELECT means to select in runtime. > !RTE_GRAPH_MODEL_SELECT means to use the default rtc_walk(), it will hit = the first case in #define RTE_GRAPH_MODEL_SELECT RTE_GRAPH_MODEL_RTC -> means rtc_walk() #define RTE_GRAPH_MODEL_SELECT RTE_GRAPH_MODEL_MCORE_DISPATCH -> means mcore_dispatch_walk() #undef RTE_GRAPH_MODEL_SELECT or not defined - it reads graph->model to pick the model Could you tell any issue with it? > rte_graph_walk() in patch 13(http://patchwork.dpdk.org/project/dpdk/patch= /20230607035144.1214492-14-zhirun.yan@intel.com/) > > Should I put it with other model definition? > If yes, I prefer to put it the first one in patch 04, like: > > +#define GRAPH_MODEL_MCORE_RUNTIME_SELECT 0 > #define RTE_GRAPH_MODEL_RTC 1 > #define RTE_GRAPH_MODEL_MCORE_DISPATCH 2 > #define RTE_GRAPH_MODEL_DEFAULT RTE_GRAPH_MODEL_RTC >