From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85474A0562; Wed, 14 Apr 2021 21:47:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14B85161CE6; Wed, 14 Apr 2021 21:47:51 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id B5FF7161CD5 for <dev@dpdk.org>; Wed, 14 Apr 2021 21:47:50 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id z22so5608471plo.3 for <dev@dpdk.org>; Wed, 14 Apr 2021 12:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IbV5xr+2vb3NFKJO8pSS3Aky4v88xNb8LX03Y5Njk2c=; b=gVOLu356GQBESX0MKCR9CRjqVjVx8N0jh7CN6hzP1JgA+ioc6d1tu69WNgTi3l6C2K FYqSeYWNN4yWJd8qqGmJaCRS6esFO6U3ANniN1rOphxNe4QR89QIEtYuwtyhZ/qC6qob bLtmagAy2hyNww1Qlp9YppP6ozK2Ij+Zi5XtGcqoYmfUGVr0OvDkCHJJ0dEdzqKDzTTA R+vU9jrpcVHAbGz1fcZuJ+q81VKR68L5FRByyue9bBk81r7eZPYrXt+WqDjcRG7LPJft 0KBWNqdGVbLMqKdshtpQT+AB9heUsJ/Jyzg8ENU4Mh+LGdVrfhNtkYjFjcVxPd2MW++C eVAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IbV5xr+2vb3NFKJO8pSS3Aky4v88xNb8LX03Y5Njk2c=; b=lWbdmM/dklapdoZNTKz7m5UXgF+0w36n1zKW+ubJ7rbnMYIx9wd7+O4Pu+ONPuOXEZ p/9v9eyym4IZOfhIcuZI0ZhS7ZzH8nOkJ9RMOD9mXU1Ev7ZsC6fIGGiLu7N/FFI/YMHh 6u3lUtkR6/Ap2HQPn5pSS+vCi8i5m2DHVDLKBSoH4EG57NRAwvqnUBtgitdyDVfbJprI Ag7+m4bRISzrxDcJ+EFLC4Sa60kobja+q0xdLMWhyBapbSLTTUtXG2UCinIoTyGlLokI v3cduY48lJZLvRCD5cXyG4DTpUmTI/Yq//W0HrrbEMyd2KDA8YcpRnVvxm3jPm1DiKM8 8U6w== X-Gm-Message-State: AOAM530lt9VlMqLNMziTWTwjZrh8v6ZdJ92DRkA2dsK9s+iy0ygBtNui MJhxqBKnye3MN3EgzoHglANOO401FunLxyHfG6o= X-Google-Smtp-Source: ABdhPJyP5Qrpa4SYgT89cBf8jUb7RqW6VBIe5YYfrHPskV9g/7sJ5aBNo1DhQuToaumuyB8s2SaS6wUoPN6rVwOgQcs= X-Received: by 2002:a17:902:b705:b029:e6:f027:adf8 with SMTP id d5-20020a170902b705b02900e6f027adf8mr40201634pls.72.1618429670007; Wed, 14 Apr 2021 12:47:50 -0700 (PDT) MIME-Version: 1.0 References: <20210316221857.2254-2-timothy.mcdaniel@intel.com> <1618344896-2090-1-git-send-email-timothy.mcdaniel@intel.com> <1618344896-2090-2-git-send-email-timothy.mcdaniel@intel.com> <CALBAE1N6o=_RajM46-rkTko3OLA02k2u0m3DdnwHZeO2oYef0g@mail.gmail.com> <SN6PR11MB3103C5E802D5F48B21361BB99E4E9@SN6PR11MB3103.namprd11.prod.outlook.com> In-Reply-To: <SN6PR11MB3103C5E802D5F48B21361BB99E4E9@SN6PR11MB3103.namprd11.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Thu, 15 Apr 2021 01:17:34 +0530 Message-ID: <CALBAE1P2RVNqqWH-+4+tKx2ZkEaT20PXX3-QzANB6ktOGRwf9w@mail.gmail.com> To: "McDaniel, Timothy" <timothy.mcdaniel@intel.com> Cc: dpdk-dev <dev@dpdk.org>, "Carrillo, Erik G" <erik.g.carrillo@intel.com>, Gage Eads <gage.eads@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>, Jerin Jacob <jerinj@marvell.com>, Thomas Monjalon <thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 01/26] event/dlb2: add v2.5 probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Apr 15, 2021 at 1:11 AM McDaniel, Timothy <timothy.mcdaniel@intel.com> wrote: > > > > > -----Original Message----- > > From: Jerin Jacob <jerinjacobk@gmail.com> > > Sent: Wednesday, April 14, 2021 2:16 PM > > To: McDaniel, Timothy <timothy.mcdaniel@intel.com> > > Cc: dpdk-dev <dev@dpdk.org>; Carrillo, Erik G <erik.g.carrillo@intel.com>; Gage > > Eads <gage.eads@intel.com>; Van Haaren, Harry > > <harry.van.haaren@intel.com>; Jerin Jacob <jerinj@marvell.com>; Thomas > > Monjalon <thomas@monjalon.net> > > Subject: Re: [dpdk-dev] [PATCH v3 01/26] event/dlb2: add v2.5 probe > > > > On Wed, Apr 14, 2021 at 1:46 AM Timothy McDaniel > > <timothy.mcdaniel@intel.com> wrote: > > > > > > This commit adds dlb v2.5 probe support, and updates > > > parameter parsing. > > > > > > The dlb v2.5 device differs from dlb v2, in that the > > > number of resources (ports, queues, ...) is different, > > > so macros have been added to take the device version > > > into account. > > > > > > > Please move the original source cleanup (the below items) to separate patch > > > > > This commit also cleans up a few issues in the original > > > dlb2 source: > > > - eliminate duplicate constant definitions > > > - removed unused constant definitions > > > - remove #ifdef FPGA > > > - remove unused include file, dlb2_mbox.h > > All in all it was quite minor, but I'll try to do this if you think its necessary. Yes, please. As it does not match the subject "event/dlb2: add v2.5 probe" > > Thanks, > Tim