From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99247A0C4D; Mon, 6 Sep 2021 10:51:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58AEF40E32; Mon, 6 Sep 2021 10:51:28 +0200 (CEST) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id 3B13740C35 for ; Mon, 6 Sep 2021 10:51:27 +0200 (CEST) Received: by mail-io1-f50.google.com with SMTP id z1so7785829ioh.7 for ; Mon, 06 Sep 2021 01:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eVAweXR7kvJmwX4JpSVR4gVJpfwMuZdjZPkPnspwozo=; b=ZjBcbyPgzNjhXakWDos7WaqLW25yE/6DBkQcdlTFndYz7oaoqYLsymOO4W50V3O3cl VD6CRZHsOupFCPSrElYP8gKZW8pxTsmXhhKfg+b/CkMzTPkaUVUy1UM9o1izJWz5Q1Fx Bvs1kvm8Yj5MOtKP0a0Dk3+8Vo8NtsFlyM19i15pXB5c/rMjYKY4AOttp7wUcoCt9tiQ CPpYHQBYPFEKq2mTe0uahEDSAdpC4VEONr8GhfyRq2/f5KoQlcp34mMKbXsXAC+7aRBR uuD2RQQTUOarT+sQgWs46rXTmb2vj7NF6edp3eT3GzKsOED151DR0IGFkjGdDTQXGGmY u4ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eVAweXR7kvJmwX4JpSVR4gVJpfwMuZdjZPkPnspwozo=; b=mlG2P5q/zg0QxwqsLTNQTiRwFOjQCSxXv7nPMoShdJsJYPTaLHoizMsIrLp9ZSty/n WSx3/aw0p/EUt6fzHWQ/5v9eAoeRuX9fm9GrBpvS7iY8O+I8b4Zi4hd+xttw4ZU9M/xX O+NEhAJrS9VIThwJcWfypsbDAaads015kzdi90a3zqFEMxTu9iUDAfrilE+VkQ97LOIL UTmTEUNnGsrgFjy/5U/nEj/5PE0LvmA6ymNaXe4/smpNY0MmqaExSxe1q/a5Z7ipsoN8 h9FIdI+o/vy0HpUsGySINhV+hSLHY6poUwxvLat7XBPEpkb7KgW3ECv/dwvN30Sca6zl NjFw== X-Gm-Message-State: AOAM531Voc0x+4gwhJ5AHte01XynC1dyD+YCYau3P3m2qZYgRAK6CWQ6 aimkh72PnKGoaa+8s9I/6Ue/hgFMZX2eY6cTh+FgIj/1Q7g5TA== X-Google-Smtp-Source: ABdhPJwJo8Zb3CgdT1masvK2zmTRkPrrwrTje3xvu6KdDtGLnnu95yoRFW9SYMQ9ZuLL0rcN4BzIJQ0rjwLnIjRtqnQ= X-Received: by 2002:a05:6638:d85:: with SMTP id l5mr9845903jaj.2.1630918286512; Mon, 06 Sep 2021 01:51:26 -0700 (PDT) MIME-Version: 1.0 References: <7b6c2f7a5e4b130204c7fdca92daf921631e479d.1628253156.git.sthotton@marvell.com> <208cb9f2657e889a9b750dcdf4ccf2f039333899.1630339233.git.sthotton@marvell.com> In-Reply-To: <208cb9f2657e889a9b750dcdf4ccf2f039333899.1630339233.git.sthotton@marvell.com> From: Jerin Jacob Date: Mon, 6 Sep 2021 14:21:00 +0530 Message-ID: To: Shijith Thotton Cc: dpdk-dev , Jerin Jacob , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] event/cnxk: fix SSO and TIM argument parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 30, 2021 at 9:37 PM Shijith Thotton wrote: > > Type of kvargs value and handler function argument should match to avoid > spilling memory. > > Fixes: 7ffa7379965e ("event/cnxk: add option to configure getwork mode") Cc: stable@dpdk.org > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > v2: > * Rebased. > > drivers/event/cnxk/cnxk_eventdev.c | 6 +++--- > drivers/event/cnxk/cnxk_tim_evdev.h | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c > index cfd7fb971c..be682bb0df 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -571,11 +571,11 @@ cnxk_sso_parse_devargs(struct cnxk_sso_evdev *dev, struct rte_devargs *devargs) > &dev->xae_cnt); > rte_kvargs_process(kvlist, CNXK_SSO_GGRP_QOS, &parse_sso_kvargs_dict, > dev); > - rte_kvargs_process(kvlist, CNXK_SSO_FORCE_BP, &parse_kvargs_value, > + rte_kvargs_process(kvlist, CNXK_SSO_FORCE_BP, &parse_kvargs_flag, > &dev->force_ena_bp); > - rte_kvargs_process(kvlist, CN9K_SSO_SINGLE_WS, &parse_kvargs_value, > + rte_kvargs_process(kvlist, CN9K_SSO_SINGLE_WS, &parse_kvargs_flag, > &single_ws); > - rte_kvargs_process(kvlist, CN10K_SSO_GW_MODE, &parse_kvargs_value, > + rte_kvargs_process(kvlist, CN10K_SSO_GW_MODE, &parse_kvargs_flag, > &dev->gw_mode); > dev->dual_ws = !single_ws; > rte_kvargs_free(kvlist); > diff --git a/drivers/event/cnxk/cnxk_tim_evdev.h b/drivers/event/cnxk/cnxk_tim_evdev.h > index c369f6f472..8e25cef0c4 100644 > --- a/drivers/event/cnxk/cnxk_tim_evdev.h > +++ b/drivers/event/cnxk/cnxk_tim_evdev.h > @@ -90,8 +90,8 @@ struct cnxk_tim_evdev { > uint32_t chunk_sz; > /* Dev args */ > uint8_t disable_npa; > - uint16_t chunk_slots; > - uint16_t min_ring_cnt; > + uint32_t chunk_slots; > + uint32_t min_ring_cnt; > uint8_t enable_stats; > uint16_t ring_ctl_cnt; > struct cnxk_tim_ctl *ring_ctl_data; > -- > 2.25.1 >