From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DD7BA3160 for ; Sat, 12 Oct 2019 15:52:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A73C41EA4E; Sat, 12 Oct 2019 15:52:18 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id B37941E9DE for ; Sat, 12 Oct 2019 15:52:16 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id w12so27360713iol.11 for ; Sat, 12 Oct 2019 06:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CRw7poWUYAKKyNV51yTMVaZTzs6Q6xrwVx2yAl2kKrg=; b=YCmvTDCdYrMoP9nlOq90uyJuB+OflHJJOEHgSSgn0zpj7EoNXLyR7/P01rxVh0Edll 5axjDDXaK5ckbbADbBcqiZYmsHX9n/BbeMx6jykAG1Y7tjYM98gebZ+3KvsSmUQfY6f0 zOZWtpk9EZK9js1NARjtmCDdIs0fbfB19gMyAGgZkeySbflc4Fs2srhonK1qhq9SxKuT zrVUQ5mfMenYmbjvkBsCrJQCmBWN5r3vaElpW4dayqF6UhM4jrILSS11p5p0BBohAR0/ dRNdgHXGskT2h8T14YLm2pq11uRqW/4kQOD95KboSsjM3g8T7x/AwLsjFtEIFEJX9iMa izig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CRw7poWUYAKKyNV51yTMVaZTzs6Q6xrwVx2yAl2kKrg=; b=htnliqBHfLCTntFxnxVhJL0Ek9kroxC2D6T4ighf1+xA3FQv9Zgy2t4wmmSO12j/x5 x/fa0Zvyqe96/d0V4tdrIh5I7Nt8GE6qbfOLihwcxcWLClf3JGZMdqUGh0HsagSHI+z4 t8/mVFCvJX2Qm0/3uZ+q4hfAWgMViIUt6W5ClmVDgXDxsO+GeqG55dRMls9YzxnzaWQD +JabR2pRcI7UQeX4L2bU3l9iXcGwUe0CPbRapPcSdbwGnyV3YMrnKEV6g2FML75ZYjZB PsKkM48XZG2wH/IfFWiJlZ7qedmP9Rp0rIDryuLhRlDCQrrkimgDrz/D6Cbd3w68Iwaf B7cA== X-Gm-Message-State: APjAAAU1nvxdoYzOxPp8FTeliwjrcqxgvHFVij/DxxbkPlOcpWoDG7gF SRG6DJBisnE/jrFsxk4CoD7ygYHxXPFW74/6p+M= X-Google-Smtp-Source: APXvYqybm3CYT1SruYG3Ydi1c+KBwD+b3VQGhDQeGJOehrpogmQUF7h7zX7N6HWdlRo6o20gKvEiM1cYdf1X87wmVqA= X-Received: by 2002:a6b:7609:: with SMTP id g9mr2553386iom.130.1570888335808; Sat, 12 Oct 2019 06:52:15 -0700 (PDT) MIME-Version: 1.0 References: <20190917075754.8310-1-amo@semihalf.com> <20190917075754.8310-4-amo@semihalf.com> In-Reply-To: <20190917075754.8310-4-amo@semihalf.com> From: Jerin Jacob Date: Sat, 12 Oct 2019 19:22:04 +0530 Message-ID: To: Andrzej Ostruszka Cc: dpdk-dev , Jerin Jacob , mattias.ronnblom@ericsson.com, Stephen Hemminger , Andrzej Ostruszka Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 03/10] app/eventdev: fix maybe-uninitialized warnings for LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 17, 2019 at 1:28 PM Andrzej Ostruszka wrote: > > During LTO build compiler reports some 'false positive' warnings about > variables being possibly used uninitialized. This patch silences these > warnings. > > Signed-off-by: Andrzej Ostruszka # Please fix check-git-log.sh errors. Missing 'Fixes' tag: app/eventdev: fix maybe-uninitialized warnings for LTO build # Please add the compiler 'false positive' warning output in git commit. # Since it is a slow path change, IMO there is no harm in introducing this change to make compiler happy. With the above fix: Reviewed-by: Jerin Jacob > --- > app/test-eventdev/test_perf_common.c | 2 +- > app/test-eventdev/test_pipeline_common.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c > index aa925a7ef..a974685cb 100644 > --- a/app/test-eventdev/test_perf_common.c > +++ b/app/test-eventdev/test_perf_common.c > @@ -439,7 +439,7 @@ perf_event_timer_adapter_setup(struct test_perf *t) > > if (!(adapter_info.caps & > RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT)) { > - uint32_t service_id; > + uint32_t service_id = -1U; > > rte_event_timer_adapter_service_id_get(wl, > &service_id); > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 16c49b860..813d0cf44 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -306,7 +306,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, uint8_t stride, > } > > if (!(cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT)) { > - uint32_t service_id; > + uint32_t service_id = -1U; > > rte_event_eth_rx_adapter_service_id_get(prod, > &service_id); > @@ -358,7 +358,7 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, > } > > if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { > - uint32_t service_id; > + uint32_t service_id = -1U; > > rte_event_eth_tx_adapter_service_id_get(consm, > &service_id); > -- > 2.17.1 >