From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E80E4A0577; Mon, 6 Apr 2020 11:32:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20FE01BED8; Mon, 6 Apr 2020 11:32:04 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 86A932BE9 for ; Mon, 6 Apr 2020 11:32:02 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id a6so14000156ilr.4 for ; Mon, 06 Apr 2020 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xbJMnG43+fOwDikKZLYjq8flsM/j5KcQg7zyd6PRFoo=; b=VNKKmmoQxGQXttaB4yjAPesgYiqEtg0m2btpeeT7XQSV9VPBiyyjXs85mlrrNkhzFv 4wmYmKut/MS7UEOB40+uVSRmkXazhTx9hrYjFi+cnXoks6at5gBMyCsIqBQY6e1d3aHP sF7Hbdjyn7c2MXqN43YcqbMD/vZWaT2K4tBX67oolPIddw2wacqbcVu+VD+9aC8azIoA zmj5yX3u+VMoId3h4km338sqSQej2l9wuecLp5pvzZPECOxO6ynapxXcp6Yf+SBpfSh7 BfxAWlmqBkPhWsR3CQ9cZ1b9h8cQ34j2j1u3nAaBtv7cuPBtk+Dj6ILhF9hVpxkzgheu n2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xbJMnG43+fOwDikKZLYjq8flsM/j5KcQg7zyd6PRFoo=; b=V1Tpiu2UNpoaJi0s8EMcmyJiNcVnCUZJtMOpwb3BsAy4N21DQZNFJp919rgzY5mknW ml944fRJg5nZyst11jP0BGEgSWeem2dtxk6R0rQQPABhaqQnVZAs/MBN+bJN73vKh6Rj 16G8wp4RgUE9E0i47vUAb9o/KiqSuS6GcDE21eGu5NafL/4mGRfOwB6KgruKoVqz2/bJ kMOdosoxZbLdMmY/KLnr6oljWLMxyzFnE0MPle86kDGmlJ6b8mvSGiCmep3qdx2QUvHA BFDJixL7WDtFK1SyYW+lpQYGsI9t1e399gVlWAqNlYhVK2CSnexjzr0Qo6PiUcoJGdO6 RWlg== X-Gm-Message-State: AGi0PubGSDUNH0dhHcqVXJFIuHMUFZ/zf9recP8G2t3udVOKd6PJwCZu R+ryQO2kYTtUTKeBM4ykhMNj27L54huW7X86oAo= X-Google-Smtp-Source: APiQypJndhUQXTRIFzpa7psIWBHMC+DHi14deGHo+Dowd3jCz3cHE/1rs4bHe1zHLXcbbGbGy01huTfVFYgz/KOjFV4= X-Received: by 2002:a05:6e02:90:: with SMTP id l16mr21003053ilm.294.1586165521855; Mon, 06 Apr 2020 02:32:01 -0700 (PDT) MIME-Version: 1.0 References: <20200312111907.31555-1-ndabilpuram@marvell.com> <20200403085216.32684-1-nithind1988@gmail.com> <20200403085216.32684-12-nithind1988@gmail.com> <20200406091441.GA20599@outlook.office365.com> In-Reply-To: <20200406091441.GA20599@outlook.office365.com> From: Jerin Jacob Date: Mon, 6 Apr 2020 15:01:45 +0530 Message-ID: To: Nithin Dabilpuram Cc: Nithin Dabilpuram , Jerin Jacob , Kiran Kumar K , John McNamara , Marko Kovacevic , dpdk-dev , Krzysztof Kanas Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 11/11] net/octeontx2: add tm capability callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 6, 2020 at 2:45 PM Nithin Dabilpuram wrote: > > > > > > diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini > > > index 473fe56..fb13517 100644 > > > --- a/doc/guides/nics/features/octeontx2.ini > > > +++ b/doc/guides/nics/features/octeontx2.ini > > > @@ -31,6 +31,7 @@ Inline protocol = Y > > > VLAN filter = Y > > > Flow control = Y > > > Flow API = Y > > > +Rate limitation = Y > > > > Definition this "Rate limitation" and TM rate limitation functionally > > the same. But the interface is different. > > Following is the interface for the above "Rate limitation" feature. > > So, Above "Y" is not applicable. > > Actually support to this feature is added via Patch 10/11. My bad, > I added the document update in 11/11 which caused the confusion. > Another reason is rate limit support depends on TM support in OCTEON TX2. > I also missed to update octeontx2_vec.ini and octeontx2_vf.ini file. > Can the above change be put back into Patch 10/11 ? Sure. I moved the update to the 10/11 patch from the 11/11 patch. > > Thanks for other corrections.