From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6070A328D for <public@inbox.dpdk.org>; Wed, 23 Oct 2019 04:50:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6A211BE96; Wed, 23 Oct 2019 04:50:32 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id B96C21BE95 for <dev@dpdk.org>; Wed, 23 Oct 2019 04:50:31 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id t5so17450074ilh.10 for <dev@dpdk.org>; Tue, 22 Oct 2019 19:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vqw/RqJp09zruehBMLeWhUgWo1Es87wCKf9yvJAbmaA=; b=Mh7NaBTRGR5ms/BYSG1JFDDCyojJj7HSRHUoNmA/mei7egsin5gj0GKLRsCwQUvwwR qJxBtmbtjF1jG6ReoFhmZVxOAeFPCxPJHPUhlT5iyrUMpJEXRId4tlFZD04du9zI0cuo qt6a4VBKo0Q0wISwIEOFsOQdln5S4iJrKLSmuCck4S55IoHTCOPaYc/Gda9UzsTrLw0B 4kiNKnv5Iyz53SyTKBVsg8SHBiMRcVhXMXzKVEN9OvPintNwe2eh8Qk8/kBCiVTYbQdl bz4PitawsIs50NrB0SbAqpdz1l+thftY5RNeQvEwPe2s1iMOMuH5qM6akuo9OcmSVrJh OG0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vqw/RqJp09zruehBMLeWhUgWo1Es87wCKf9yvJAbmaA=; b=W3hN1RG0qsB5q0dDr9eI8xhBel4as9K5HrlmII3Uti+O4wRel7mVCAwJtAyYYbl/xy Dck6kX8m07XECDN9Q+O8vle/3aRhS/m29EZ0W+KLjkyCi2hehXcH7MidjASoWrMe6/2j gbShNIzLO3nNViiHTVgaCyjOG/VOSTTPyq/x0R6FaVYb0OgkmlQ47/cVJf3aS5zg33Hr HSyROadPdwhETZgXqBEDt2fIwiCotQHqmlD39aW8xEVhgWRpJSW81vQoy47rmUVgp+zc 4P/+zEc+Ij50JAE3hdo1wr0wsln5ZCl0vAqArYSf9bOq3oWMds+Cg4+VDaSa29PeAsHw p9Sg== X-Gm-Message-State: APjAAAWGKS+deKoJJohYR3wYQeBx2hFDRbmxeEI3x/YpHKkHptSBsJx2 5Uztpa7bG+FN2NnC/Iz7yACGSZb5A2vBwCkRIrc= X-Google-Smtp-Source: APXvYqxG/646GNO9u/CuMW4mE/Oj1RBq7AHqZYogLT3KaVh+8nG8rKzdP6eXbP962MDqn7We1RTq/b8FNI77UPyI2Io= X-Received: by 2002:a92:2c03:: with SMTP id t3mr36138698ile.271.1571799030902; Tue, 22 Oct 2019 19:50:30 -0700 (PDT) MIME-Version: 1.0 References: <20191012073421.44748-1-jerinj@marvell.com> <VE1PR08MB5149EDA5C5FD3A513B815BEC98680@VE1PR08MB5149.eurprd08.prod.outlook.com> In-Reply-To: <VE1PR08MB5149EDA5C5FD3A513B815BEC98680@VE1PR08MB5149.eurprd08.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 23 Oct 2019 08:20:22 +0530 Message-ID: <CALBAE1P5XUyLn-1gDqLsgjFSLVCpgwtO7BM9ZZUCxPMBicAqhw@mail.gmail.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> Cc: dpdk-dev <dev@dpdk.org>, "Akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "anoobj@marvell.com" <anoobj@marvell.com>, "pathreya@marvell.com" <pathreya@marvell.com>, "pkapoor@marvell.com" <pkapoor@marvell.com>, "jerinj@marvell.com" <jerinj@marvell.com>, nd <nd@arm.com> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, < Honnappa.Nagarahalli@arm.com> wrote: > <snip> > > > > > From: Jerin Jacob <jerinj@marvell.com> > > > > Update the armv8 crypto PMD maintainership. > > > > https://github.com/caviumnetworks/armv8_crypto external crypto the > library > > will not be maintained and probably removed soon therefor updating the > PMD > > documentation to reflect the same. > > > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> > > --- > > > > This patch is based on the discussion of the following thread > > http://mails.dpdk.org/archives/dev/2019-October/146005.html > > > > In summary, > > # ARMv8 crypto PMD depends on an external library owned by Marvell, > > specifically crafted to the DPDK performance use case. > > # There is no upstream path to this library and it will not be > maintained due to > > that fact that it > > a) Creates fragmentation of the SW > > b) Contribution policy concerning external Github Repos > > c) None other than Marvell can contribute to this library and this makes > > difficult for other stakeholder to use it. > > > > # As the maintainer, I would like to make forward progress by providing > the > > following options. None of the options are converging as the result I > would like > > to step down from the maintainership of the incomplete PMD as I don't see > > any options for collaboration, improvement in the library nor follows > the open > > source philosophy in the way it is structured out now. > > > > option 1) Move external library(BSD-3 license) to dpdk.org so that > every armv8 > > vendors can contribute, improve and avoid SW fragmentation and therefore > > better quality. > I do not see any issues with this approach. This patch should be changed > to reflect this option? > In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid? > > > > option 2) If option 1 is not possible, remove the incomplete PMD from > > dpdk.org and maintain the existing PMD as the external one by each > vendor. > > This won't change much in the existing situation as this PMD is not > standalone > > and anyway depended on an external code base. > IMHO, DPDK defines an interface to integrate an external crypto library. > This might be under use by applications. Removing the PMD will break those > applications. > DPDK does not define any such interface. It was pushed to external library for the reason mentioned above. If no one is ready to host the actual code, how is even possible to have floating PMD which can not even build by community. I propose to take this to TB to reach to consensus as we are going in circles in mailing list. > > > > I am glad/help to execute option 1 or 2 or help to a new maintainer if > he/she > > would like to step up and take ownership. > > > > --- > > MAINTAINERS | 1 - > > doc/guides/cryptodevs/armv8.rst | 3 +-- > > 2 files changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index b02066270..8096d93c4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst > > F: doc/guides/cryptodevs/features/ccp.ini > > > > ARMv8 Crypto > > -M: Jerin Jacob <jerinj@marvell.com> > > F: drivers/crypto/armv8/ > > F: doc/guides/cryptodevs/armv8.rst > > F: doc/guides/cryptodevs/features/armv8.ini > > diff --git a/doc/guides/cryptodevs/armv8.rst > > b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644 > > --- a/doc/guides/cryptodevs/armv8.rst > > +++ b/doc/guides/cryptodevs/armv8.rst > > @@ -28,8 +28,7 @@ Installation > > > > In order to enable this virtual crypto PMD, user must: > > > > -* Download ARMv8 crypto library source code from > > - `here <https://github.com/caviumnetworks/armv8_crypto>`_ > > +* Use ARMv8 crypto library source code from vendor SDK > > > > * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with > > the path where the ``armv8_crypto`` library was downloaded > > -- > > 2.23.0 > >