[dpdk-dev] [PATCH] test/event_crypto: fix mempool name

[dpdk-dev] [PATCH] test/event_crypto: fix mempool name

[Hemant Agrawal]

The longer mempool name size is causing error in
rte_mempool_create_empty for dpaa1

ret = snprintf(mz_name, sizeof(mz_name), RTE_MEMPOOL_MZ_FORMAT, name);
This patch reduce the size of mempool name string

Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/test/test_event_crypto_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 73655020d..cff7ad61f 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -536,7 +536,7 @@ configure_cryptodev(void)
 			"session mempool allocation failed\n");
 
 	params.session_priv_mpool = rte_mempool_create(
-				"CRYPTO_ADAPTER_SESSION_MP_PRIV",
+				"CRYPTO_AD_SESS_MP_PRIV",
 				MAX_NB_SESSIONS,
 				session_size,
 				0, 0, NULL, NULL, NULL,
-- 
2.17.1

[dpdk-dev] [PATCH] test/event_crypto: change the SEC cipher algo

[Hemant Agrawal]

The existing code usages NULL as the cipher algo
for testing crypto event adapter.
DPAA1/DPAA2 do not support NULL algo. Hence changing
is to the most common algo AES-CBC, which is supported
by all crypto drivers implementing event crypto adapter.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/test/test_event_crypto_adapter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index cff7ad61f..83f3214ca 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
 
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
 	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
@@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
 
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
 	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
-- 
2.17.1

Re: [dpdk-dev] [PATCH] test/event_crypto: change the SEC cipher algo

[Gujjar, Abhinandan S]

Acked-by: abhinandan.gujjar@intel.com


> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: change the SEC cipher algo
> 
> The existing code usages NULL as the cipher algo for testing crypto event
> adapter.
> DPAA1/DPAA2 do not support NULL algo. Hence changing is to the most
> common algo AES-CBC, which is supported by all crypto drivers implementing
> event crypto adapter.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test/test_event_crypto_adapter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index cff7ad61f..83f3214ca 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> 
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
>  	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
> @@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> 
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
>  	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] test/event_crypto: change the SEC cipher algo

[Jerin Jacob]

On Fri, Sep 27, 2019 at 3:41 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com


Changed to  Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.


>
>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 27, 2019 1:46 PM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: change the SEC cipher algo
> >
> > The existing code usages NULL as the cipher algo for testing crypto event
> > adapter.
> > DPAA1/DPAA2 do not support NULL algo. Hence changing is to the most
> > common algo AES-CBC, which is supported by all crypto drivers implementing
> > event crypto adapter.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index cff7ad61f..83f3214ca 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
> >       cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >       cipher_xform.next = NULL;
> >
> > -     cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > +     cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> >       cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> >       op = rte_crypto_op_alloc(params.op_mpool,
> > @@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
> >       cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >       cipher_xform.next = NULL;
> >
> > -     cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > +     cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> >       cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> >       op = rte_crypto_op_alloc(params.op_mpool,
> > --
> > 2.17.1
>

[dpdk-dev] [PATCH] test/event_crypto: add check for adapter failure

[Hemant Agrawal]

Return err if the adapter creation is failed.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/test/test_event_crypto_adapter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 83f3214ca..275729ba6 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -814,7 +814,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
-	test_crypto_adapter_conf(mode);
+	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
+				"Failed to config crypto adapter");
 
 	return TEST_SUCCESS;
 }
@@ -825,7 +826,9 @@ test_crypto_adapter_conf_op_new_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
-	test_crypto_adapter_conf(mode);
+	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
+				"Failed to config crypto adapter");
+
 	return TEST_SUCCESS;
 }
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH] test/event_crypto: add check for adapter failure

[Gujjar, Abhinandan S]

Acked-by: abhinandan.gujjar@intel.com

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: add check for adapter failure
> 
> Return err if the adapter creation is failed.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test/test_event_crypto_adapter.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 83f3214ca..275729ba6 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -814,7 +814,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
>  	enum rte_event_crypto_adapter_mode mode;
> 
>  	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
> -	test_crypto_adapter_conf(mode);
> +	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> +				"Failed to config crypto adapter");
> 
>  	return TEST_SUCCESS;
>  }
> @@ -825,7 +826,9 @@ test_crypto_adapter_conf_op_new_mode(void)
>  	enum rte_event_crypto_adapter_mode mode;
> 
>  	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
> -	test_crypto_adapter_conf(mode);
> +	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> +				"Failed to config crypto adapter");
> +
>  	return TEST_SUCCESS;
>  }
> 
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] test/event_crypto: add check for adapter failure

[Jerin Jacob]

On Fri, Sep 27, 2019 at 3:40 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com


Changed to  Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.



>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 27, 2019 1:46 PM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: add check for adapter failure
> >
> > Return err if the adapter creation is failed.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 83f3214ca..275729ba6 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -814,7 +814,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
> >       enum rte_event_crypto_adapter_mode mode;
> >
> >       mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
> > -     test_crypto_adapter_conf(mode);
> > +     TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> > +                             "Failed to config crypto adapter");
> >
> >       return TEST_SUCCESS;
> >  }
> > @@ -825,7 +826,9 @@ test_crypto_adapter_conf_op_new_mode(void)
> >       enum rte_event_crypto_adapter_mode mode;
> >
> >       mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
> > -     test_crypto_adapter_conf(mode);
> > +     TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> > +                             "Failed to config crypto adapter");
> > +
> >       return TEST_SUCCESS;
> >  }
> >
> > --
> > 2.17.1
>

Re: [dpdk-dev] [PATCH] test/event_crypto: fix mempool name

[Gujjar, Abhinandan S]

Acked-by: abhinandan.gujjar@intel.com


> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: stable@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: fix mempool name
> 
> The longer mempool name size is causing error in rte_mempool_create_empty
> for dpaa1
> 
> ret = snprintf(mz_name, sizeof(mz_name), RTE_MEMPOOL_MZ_FORMAT,
> name); This patch reduce the size of mempool name string
> 
> Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test/test_event_crypto_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 73655020d..cff7ad61f 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -536,7 +536,7 @@ configure_cryptodev(void)
>  			"session mempool allocation failed\n");
> 
>  	params.session_priv_mpool = rte_mempool_create(
> -				"CRYPTO_ADAPTER_SESSION_MP_PRIV",
> +				"CRYPTO_AD_SESS_MP_PRIV",
>  				MAX_NB_SESSIONS,
>  				session_size,
>  				0, 0, NULL, NULL, NULL,
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] test/event_crypto: fix mempool name

[Jerin Jacob]

On Fri, Sep 27, 2019 at 3:45 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com

Changed to  Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.

>
>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 27, 2019 1:46 PM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: stable@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: fix mempool name
> >
> > The longer mempool name size is causing error in rte_mempool_create_empty
> > for dpaa1
> >
> > ret = snprintf(mz_name, sizeof(mz_name), RTE_MEMPOOL_MZ_FORMAT,
> > name); This patch reduce the size of mempool name string
> >
> > Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 73655020d..cff7ad61f 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -536,7 +536,7 @@ configure_cryptodev(void)
> >                       "session mempool allocation failed\n");
> >
> >       params.session_priv_mpool = rte_mempool_create(
> > -                             "CRYPTO_ADAPTER_SESSION_MP_PRIV",
> > +                             "CRYPTO_AD_SESS_MP_PRIV",
> >                               MAX_NB_SESSIONS,
> >                               session_size,
> >                               0, 0, NULL, NULL, NULL,
> > --
> > 2.17.1
>