From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB42FA04B0; Fri, 7 Aug 2020 16:01:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 189A22C39; Fri, 7 Aug 2020 16:01:57 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 6E3432BF2 for ; Fri, 7 Aug 2020 16:01:55 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id z6so1981997iow.6 for ; Fri, 07 Aug 2020 07:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uxvarVwyUKzId8vFB/wRWAPpWLLpPv0y+vITTRWzezg=; b=Cew94ZQWfsbCxuVxLchZaDn2YE7BuK8yzLXUWLe8MoBVIXsRZhhrc5QQ+3jeaDsDJ6 sXpGuv5AHizilWExoKEC6Vs9i/9MPz5EAE5168erH6rL+daMWnauqNIMawB6AJiUeds3 Ty0B9GDDqdlEmWQE7Sbn3zgn0RqHA3OZ4WgSMGPsMl+u1Fm5/NpsQdXvoCj4pTInB7Db SjwmwcnLa9BrbwceS/Q4Y1JDT5iCAQhLoDCJ3WYt5aTWR9yKRDVZOlkubISfffjRTr9X yx9HPagGecpGi6BC7NICqkkRQvL2pLyN6V6D0kljxIITAGw6JIQCAT0RI0xVBFGPx9Be E/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uxvarVwyUKzId8vFB/wRWAPpWLLpPv0y+vITTRWzezg=; b=nt8nhZwCjgBBaiw4Xx4EoVbWNCuDQHdkWRoNZTDhdYYyIS6k1JP3Oxl+MpenuzlZCY CecuV6CiZDQjA1oGVhC58J/T9fDWmYVQRJyNC4M8ANWLide5s50cevyaJoM67QvP2y6x pKjnRIXN3/w8ERXGYAikhCRp8G8E1An8S32BO4QUWcbQHuTntmaEHZXGv3Fuk3GG/24d 4ZjNaYsRQ5MY32rCE3iANqFTTs9oGzuEAehY6+MvMAK25eUYWbyFjjw7NSiuD5RPaOuT JAXrIxF2u3IvaRmkpGYOEkjot4BUUyeBQNLK31qWuewsrSwf0a4Xw5EVgzwIxWSV7y0d VLEQ== X-Gm-Message-State: AOAM5313RQ+iFN792rOE8B7/NWQrs5z3WVRCThdmBYw5pHplPDs32szA 0fidKeap8j+rWLZSoNbvnJRrqzM35XqsIUoGSH3JZ8E1Zps= X-Google-Smtp-Source: ABdhPJwOMo7x/HY/Zh++DaHPRLezQ6k0ddrWg4T2IvU8nC/7ur8t7rrLI2jqc4NexVvEIiMqnuYz8qWbP1wl+X4PuCw= X-Received: by 2002:a6b:e40b:: with SMTP id u11mr4808378iog.123.1596808914504; Fri, 07 Aug 2020 07:01:54 -0700 (PDT) MIME-Version: 1.0 References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-3-ciara.power@intel.com> <20200807124536.GA302@bricha3-MOBL.ger.corp.intel.com> <20200807132343.GA306@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 7 Aug 2020 19:31:37 +0530 Message-ID: To: Ferruh Yigit Cc: Bruce Richardson , Ciara Power , dpdk-dev , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 20.11 02/19] build: remove makefiles and mk directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 7, 2020 at 7:04 PM Ferruh Yigit wrote: > > On 8/7/2020 2:23 PM, Bruce Richardson wrote: > > On Fri, Aug 07, 2020 at 06:49:47PM +0530, Jerin Jacob wrote: > >> On Fri, Aug 7, 2020 at 6:15 PM Bruce Richardson > >> wrote: > >>> > >>> On Fri, Aug 07, 2020 at 01:29:52PM +0100, Ciara Power wrote: > >>>> It was decided [1] to no longer support Make in DPDK, this patch > >>>> removes all Makefiles that do not make use of pkg-config, along with > >>>> the mk directory previously used by make. > >>>> > >>>> [1] https://mails.dpdk.org/archives/dev/2020-April/162839.html > >>>> > >>>> Signed-off-by: Ciara Power > >>>> --- > >>>> GNUmakefile | 17 - > >>>> Makefile | 4 - > >>> > >>> Open question from me: > >>> Do we want to leave a dummy top-level makefile that prints instructions on > >>> build with meson and ninja - or even runs a build using them if they are > >>> installed? > >> > >> Maybe we can keep "make tags" as well in top-level Makefile. > > > > Is it better to point people directly to the script? My concern about > > having a makefile is that it may confuse people as to how to build DPDK. > > On the other side, there is a convenience aspect to having a makefile, so > > I'm open to being convinced either way. I was looking more of a convenience point of view. Can we check how other meson based projects deal with similar problems? > > > > A dummy Makefile to print instructions may be helpful for people missed the > change, I am for having it. > > But I am dubious on extending it, like for tags, although I found it useful I > think we should integrate it to meson instead. I think, we can not integrate such stuff with meson. If we can with meson, I agree we should take that path.