From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2338A0350; Thu, 7 May 2020 15:54:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53F131DCB6; Thu, 7 May 2020 15:54:34 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id E38D51DCB4 for ; Thu, 7 May 2020 15:54:31 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id r2so5362978ilo.6 for ; Thu, 07 May 2020 06:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d/eFA3ZFBpoSzn5IXwqI4bxCSFELGrTw3AoAIw4ECMw=; b=CY9y9FPPdT/Y6jn5ns/Uk3FcYh96QzVG42PLkOZdX3FpX+tzQrpRaivdLvArZRbEEA GntXXMyRY8I9+coNtKxnd/RRUsC21NrkPO7i0xDYOqIibGUkcbzZJO1wYyYsNx3Ydp0V 3lC3ZSqjK5gJ5VTZWF13qr/71ujNjyCR3OIWnJfv7N/mCMg9MiOWI01VvNpkx6ivwNRV EmRVqqOtTlOQnyrnMVh2DsVrLfxQlN4zdilHFTs86RdyT6ixjKbLcBNpoNFnYikMFyk4 SJxME2StwgpM3Rb4VzYotcDcsblrSvg833UI65lXvw4jBr3ytUxmx6ROFodIKe+b7p6w O6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d/eFA3ZFBpoSzn5IXwqI4bxCSFELGrTw3AoAIw4ECMw=; b=qfgonBQloVFpRpPyRk46NOAGSytV9s0Pi0aQTTAF+km6ev8olNazGYqjKYRvtTK+GT IMCfhzVE0/bHlyIPXb3Xrw0Igs1oTsEDX5e2nuOV3llf6LGxweqE4IWI1LuMg/kvjCq7 pbmoYkqyOjtbNanmQhhgulc/kVvCk66qBzuOtHemyS8Af++kh323g6p1QCjmHbyAnucT IYBNOVt0vEUL93kN//dKf33ZJhONLLYH9oy2pEoo+9Xhc6dQFe/wC/yuht6pJkr3zH7n EmdeeqVoWJ6xGpDftJDur8TA85OsMUb15UZvFW4Tby5/uyGKHz1W1aNK0gAQA4nZwVOO y7JQ== X-Gm-Message-State: AGi0PuaEO8H9TQ7HhwmLOjBSIcB/9mMnUB7Q058eRJGsn0xrCVSP5Pot qA1xbGnUQWf6YmWIg2tm+TBpvZVo8qKCqeTUzd8= X-Google-Smtp-Source: APiQypK1IBtvib+2/OzwjOSTphazjpFfH6Oyd804QnI9Vt4tlXHA2EYMCGieQQBEbF0OCpwTxDM9yEhpw5H/QSzKifE= X-Received: by 2002:a92:9edb:: with SMTP id s88mr15110636ilk.294.1588859665914; Thu, 07 May 2020 06:54:25 -0700 (PDT) MIME-Version: 1.0 References: <20200121080021.2835490-1-jerinj@marvell.com> <20200504132653.3668706-1-jerinj@marvell.com> In-Reply-To: <20200504132653.3668706-1-jerinj@marvell.com> From: Jerin Jacob Date: Thu, 7 May 2020 19:24:08 +0530 Message-ID: To: Jerin Jacob Cc: dpdk-dev , Thomas Monjalon , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 4, 2020 at 6:56 PM wrote: > > From: Jerin Jacob > > Some machines may have a lot of PCI devices and all of them are > not bound to DPDK. In such case the logs from EAL creates a lot of > clutter on boot-up, typically one needs to scroll the screen to > find other issues in boot-up. > > This patch changes the following to reduce the clutter in > the default boot-up logs. > > - Change the log-level of PCI probes to `debug` > - Introduce new driver probe as `info` log-level for the successful probe. > > Signed-off-by: Jerin Jacob > --- > v2: > - Introduce new driver probe as `info` log-level for the successful > probe(Thomas) Thomas, Could you review and merge this for RC2. I have addressed the comments. Limited the default prints to successful probe(). > > drivers/bus/pci/pci_common.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index 3f5542076..6585a4b47 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -136,7 +136,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > /* Match of device and driver failed */ > return 1; > > - RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n", > + RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n", > loc->domain, loc->bus, loc->devid, loc->function, > dev->device.numa_node); > > @@ -161,7 +161,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > return -EEXIST; > } > > - RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id, > + RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id, > dev->id.device_id, dr->driver.name); > > /* > @@ -195,6 +195,10 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > } > } > > + RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n", > + dr->driver.name, dev->id.vendor_id, dev->id.device_id, > + loc->domain, loc->bus, loc->devid, loc->function, > + dev->device.numa_node); > /* call the driver probe() function */ > ret = dr->probe(dr, dev); > if (already_probed) > -- > 2.26.2 >