From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 183DF42FB1; Tue, 1 Aug 2023 12:29:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0B9740F16; Tue, 1 Aug 2023 12:29:24 +0200 (CEST) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by mails.dpdk.org (Postfix) with ESMTP id 3A2F140A89 for ; Tue, 1 Aug 2023 12:29:23 +0200 (CEST) Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-79a41b1bccfso1725362241.0 for ; Tue, 01 Aug 2023 03:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690885762; x=1691490562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GHfFVfjxbjvNM9JDG7AGKW+EIypykEZqtL1xWkrsD14=; b=VSYZcVA4JOLTtuL3Hvz4lo6mjQd9fh7DoNZuiV+m7od31ATPnrSxS4dmyzZjyIsBfk tCnBK7x+m2hPOWejMiiNKgWLgExTUgoihNDP4Y6yFZhGcFddXl5bCQNkLmtPcSamGC27 u4Nv+wnwxCQdzvTXbbFHjwJX31Vz0aOG/2tOCaprTECQc5bH34V9l13xaSHBlfMZaqrx ZvxzCyPUDPY0aF7xniYc+4fav3zsu6c5XuCS5mN4U5xTFxtYFxM7JzeblctgkINCFYZj q7K+qlXlWk0uTZsl3SOvrNU+kqiZPOx6vUO2ZAMre7k4kkQy1yah59hoPNp/0S7XtNJp CB7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690885762; x=1691490562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHfFVfjxbjvNM9JDG7AGKW+EIypykEZqtL1xWkrsD14=; b=RYWGY34JgG+J2fJ/EoSF8bLidgXFuL1LrwCnrLNrk67tZgeSkygEDU7vkmym5UD9/Z rMp3pDXJPDHBfBhirzZMWPfr7vRlPT2XbOwaRbk4svbsY2Upj5uPjER2f46WNh+DDrLp 37ZDct0Iw3eVWwzKG0hqfxFcuGFAqWZuVMogQljWPWXGOHukXvOJKDUViFJ7mt4KXGDu 7r9VWO6g+/cTziNbgz4yYC2DYuCACCImBSv4cyHpTL3eIbS2/3Yb6MfmNdlOUqoCH7Jv EMFSl1uvCrrcJ16PSDzSHWeF9TdLCI4m6D0L6Hdu/SEcHhtgRjxwRrjB/OnZvM0q8Kzt 5BGA== X-Gm-Message-State: ABy/qLbkvn87Vj0MNYhO/0VfDAduhclZFzyQFhhueLPQNovT3dh6DfPh +iQOK9saNaLWATx3u8kBWaKDvKbccXtU46zYjDHnE/hk1d8= X-Google-Smtp-Source: APBJJlFQUO/eyq+goLXhM0R26dVY5CK2+2r0LKkuZiql8ESSWOIY9ZDDGgBbI2iw9UJRCGTPLCl7dlVR5xEm6T0BYjY= X-Received: by 2002:a05:6102:142:b0:440:b7df:767b with SMTP id a2-20020a056102014200b00440b7df767bmr1917149vsr.11.1690885762316; Tue, 01 Aug 2023 03:29:22 -0700 (PDT) MIME-Version: 1.0 References: <20230801094004.51939-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20230801094004.51939-1-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Tue, 1 Aug 2023 15:58:56 +0530 Message-ID: Subject: Re: [RFC] eventdev/eth_rx: update adapter create APIs To: Naga Harish K S V Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 3:10=E2=80=AFPM Naga Harish K S V wrote: > > The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and > rte_event_eth_rx_adapter_create() are updated to take additional argument > as a pointer of type struct rte_event_eth_rx_adapter_params. Please avod API prototype changes . It will be pain for application which needs to manage both. IMO, It is not worth it. > > The API rte_event_eth_rx_adapter_create_with_params() is > deprecated. > > Signed-off-by: Naga Harish K S V > --- > app/test-eventdev/test_perf_common.c | 2 +- > app/test-eventdev/test_pipeline_common.c | 2 +- > app/test/test_event_eth_rx_adapter.c | 22 ++--- > app/test/test_security_inline_proto.c | 2 +- > .../pipeline_worker_generic.c | 2 +- > .../eventdev_pipeline/pipeline_worker_tx.c | 2 +- > examples/ipsec-secgw/event_helper.c | 2 +- > examples/l2fwd-event/l2fwd_event_generic.c | 2 +- > .../l2fwd-event/l2fwd_event_internal_port.c | 2 +- > examples/l3fwd/l3fwd_event_generic.c | 2 +- > examples/l3fwd/l3fwd_event_internal_port.c | 2 +- > lib/eventdev/rte_event_eth_rx_adapter.c | 96 ++++++++----------- > lib/eventdev/rte_event_eth_rx_adapter.h | 34 +------ > lib/eventdev/version.map | 1 - > 14 files changed, 67 insertions(+), 106 deletions(-) > > diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/tes= t_perf_common.c > index 5e0255cfeb..0c6c252f7d 100644 > --- a/app/test-eventdev/test_perf_common.c > +++ b/app/test-eventdev/test_perf_common.c > @@ -1002,7 +1002,7 @@ perf_event_rx_adapter_setup(struct evt_options *opt= , uint8_t stride, > } > queue_conf.ev.queue_id =3D prod * stride; > ret =3D rte_event_eth_rx_adapter_create(prod, opt->dev_id= , > - &prod_conf); > + &prod_conf, NULL); > if (ret) { > evt_err("failed to create rx adapter[%d]", prod); > return ret; > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev= /test_pipeline_common.c > index b111690b7c..5ae175f2c7 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -571,7 +571,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *o= pt, uint8_t stride, > } > queue_conf.ev.queue_id =3D prod * stride; > ret =3D rte_event_eth_rx_adapter_create(prod, opt->dev_id= , > - &prod_conf); > + &prod_conf, NULL); > if (ret) { > evt_err("failed to create rx adapter[%d]", prod); > return ret; > diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_e= th_rx_adapter.c > index 52d146f97c..42edcb625a 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -401,7 +401,7 @@ adapter_create(void) > rx_p_conf.dequeue_depth =3D dev_info.max_event_port_dequeue_depth= ; > rx_p_conf.enqueue_depth =3D dev_info.max_event_port_enqueue_depth= ; > err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID= , > - &rx_p_conf); > + &rx_p_conf, NULL); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > return err; > @@ -427,17 +427,17 @@ adapter_create_with_params(void) > rxa_params.use_queue_event_buf =3D false; > rxa_params.event_buf_size =3D 0; > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > rxa_params.use_queue_event_buf =3D true; > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D -EEXIST, "Expected -EEXIST got %d", err); > > @@ -567,15 +567,15 @@ adapter_create_free(void) > }; > > err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID= , > - NULL); > + NULL, NULL); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID= , > - &rx_p_conf); > + &rx_p_conf, NULL); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > - TEST_DEV_ID, &rx_p_conf); > + TEST_DEV_ID, &rx_p_conf, NULL); > TEST_ASSERT(err =3D=3D -EEXIST, "Expected -EEXIST %d got %d", -EE= XIST, err); > > err =3D rte_event_eth_rx_adapter_free(TEST_INST_ID); > @@ -605,20 +605,20 @@ adapter_create_free_with_params(void) > .event_buf_size =3D 1024 > }; > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, NULL, NULL); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D -EEXIST, "Expected -EEXIST %d got %d", -EE= XIST, err); > > rxa_params.event_buf_size =3D 0; > - err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + err =3D rte_event_eth_rx_adapter_create(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > diff --git a/app/test/test_security_inline_proto.c b/app/test/test_securi= ty_inline_proto.c > index 45aa742c6b..fc240201a3 100644 > --- a/app/test/test_security_inline_proto.c > +++ b/app/test/test_security_inline_proto.c > @@ -1872,7 +1872,7 @@ event_inline_ipsec_testsuite_setup(void) > > /* Create Rx adapter */ > ret =3D rte_event_eth_rx_adapter_create(rx_adapter_id, eventdev_i= d, > - &ev_port_conf); > + &ev_port_conf, NULL); > if (ret < 0) { > printf("Failed to create rx adapter %d\n", ret); > return ret; > diff --git a/examples/eventdev_pipeline/pipeline_worker_generic.c b/examp= les/eventdev_pipeline/pipeline_worker_generic.c > index 783f68c91e..74510338ba 100644 > --- a/examples/eventdev_pipeline/pipeline_worker_generic.c > +++ b/examples/eventdev_pipeline/pipeline_worker_generic.c > @@ -436,7 +436,7 @@ init_adapters(uint16_t nb_ports) > init_ports(nb_ports); > /* Create one adapter for all the ethernet ports. */ > ret =3D rte_event_eth_rx_adapter_create(cdata.rx_adapter_id, evde= v_id, > - &adptr_p_conf); > + &adptr_p_conf, NULL); > if (ret) > rte_exit(EXIT_FAILURE, "failed to create rx adapter[%d]", > cdata.rx_adapter_id); > diff --git a/examples/eventdev_pipeline/pipeline_worker_tx.c b/examples/e= ventdev_pipeline/pipeline_worker_tx.c > index 98a52f3892..88619d6c2e 100644 > --- a/examples/eventdev_pipeline/pipeline_worker_tx.c > +++ b/examples/eventdev_pipeline/pipeline_worker_tx.c > @@ -793,7 +793,7 @@ init_adapters(uint16_t nb_ports) > uint32_t service_id; > > ret =3D rte_event_eth_rx_adapter_create(i, evdev_id, > - &adptr_p_conf); > + &adptr_p_conf, NULL); > if (ret) > rte_exit(EXIT_FAILURE, > "failed to create rx adapter[%d]"= , i); > diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/e= vent_helper.c > index 89fb7e62a5..28d6778134 100644 > --- a/examples/ipsec-secgw/event_helper.c > +++ b/examples/ipsec-secgw/event_helper.c > @@ -1035,7 +1035,7 @@ eh_rx_adapter_configure(struct eventmode_conf *em_c= onf, > > /* Create Rx adapter */ > ret =3D rte_event_eth_rx_adapter_create(adapter->adapter_id, > - adapter->eventdev_id, &port_conf); > + adapter->eventdev_id, &port_conf, NULL); > if (ret < 0) { > EH_LOG_ERR("Failed to create rx adapter %d", ret); > return ret; > diff --git a/examples/l2fwd-event/l2fwd_event_generic.c b/examples/l2fwd-= event/l2fwd_event_generic.c > index 1977e23261..4360b20aa0 100644 > --- a/examples/l2fwd-event/l2fwd_event_generic.c > +++ b/examples/l2fwd-event/l2fwd_event_generic.c > @@ -235,7 +235,7 @@ l2fwd_rx_tx_adapter_setup_generic(struct l2fwd_resour= ces *rsrc) > } > > ret =3D rte_event_eth_rx_adapter_create(rx_adptr_id, event_d_id, > - &evt_rsrc->def_p_conf); > + &evt_rsrc->def_p_conf, NULL= ); > if (ret) > rte_panic("Failed to create rx adapter\n"); > > diff --git a/examples/l2fwd-event/l2fwd_event_internal_port.c b/examples/= l2fwd-event/l2fwd_event_internal_port.c > index 717a7bceb8..542890f354 100644 > --- a/examples/l2fwd-event/l2fwd_event_internal_port.c > +++ b/examples/l2fwd-event/l2fwd_event_internal_port.c > @@ -253,7 +253,7 @@ l2fwd_rx_tx_adapter_setup_internal_port(struct l2fwd_= resources *rsrc) > } > > ret =3D rte_event_eth_rx_adapter_create(adapter_id, event= _d_id, > - &evt_rsrc->def_p_conf); > + &evt_rsrc->def_p_conf, NU= LL); > if (ret) > rte_panic("Failed to create rx adapter[%d]\n", > adapter_id); > diff --git a/examples/l3fwd/l3fwd_event_generic.c b/examples/l3fwd/l3fwd_= event_generic.c > index c80573fc58..88e7af538e 100644 > --- a/examples/l3fwd/l3fwd_event_generic.c > +++ b/examples/l3fwd/l3fwd_event_generic.c > @@ -217,7 +217,7 @@ l3fwd_rx_tx_adapter_setup_generic(void) > } > > ret =3D rte_event_eth_rx_adapter_create(rx_adptr_id, event_d_id, > - &evt_rsrc->def_p_conf); > + &evt_rsrc->def_p_conf, NULL= ); > if (ret) > rte_panic("Failed to create rx adapter\n"); > > diff --git a/examples/l3fwd/l3fwd_event_internal_port.c b/examples/l3fwd/= l3fwd_event_internal_port.c > index 32cf657148..dc8b5013cb 100644 > --- a/examples/l3fwd/l3fwd_event_internal_port.c > +++ b/examples/l3fwd/l3fwd_event_internal_port.c > @@ -246,7 +246,7 @@ l3fwd_rx_tx_adapter_setup_internal_port(void) > } > > ret =3D rte_event_eth_rx_adapter_create(adapter_id, event= _d_id, > - &evt_rsrc->def_p_co= nf); > + &evt_rsrc->def_p_co= nf, NULL); > if (ret) > rte_panic("Failed to create rx adapter[%d]\n", > adapter_id); > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index f7f93ccdfd..263d6f54b7 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2485,90 +2485,78 @@ rxa_create(uint8_t id, uint8_t dev_id, > return 0; > } > > -int > -rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, > - rte_event_eth_rx_adapter_conf_cb conf_cb, > - void *conf_arg) > +static int __rte_cold > +rxa_config_params_validate(struct rte_event_eth_rx_adapter_params *rxa_p= arams, > + struct rte_event_eth_rx_adapter_params *temp_p= arams) > { > - struct rte_event_eth_rx_adapter_params rxa_params =3D {0}; > - > - /* use default values for adapter params */ > - rxa_params.event_buf_size =3D ETH_EVENT_BUFFER_SIZE; > - rxa_params.use_queue_event_buf =3D false; > - > - return rxa_create(id, dev_id, &rxa_params, conf_cb, conf_arg); > -} > - > -int > -rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id, > - struct rte_event_port_conf *port_config, > - struct rte_event_eth_rx_adapter_params *rxa_param= s) > -{ > - struct rte_event_port_conf *pc; > - int ret; > - struct rte_event_eth_rx_adapter_params temp_params =3D {0}; > - > - if (port_config =3D=3D NULL) > - return -EINVAL; > - > if (rxa_params =3D=3D NULL) { > /* use default values if rxa_params is NULL */ > - rxa_params =3D &temp_params; > - rxa_params->event_buf_size =3D ETH_EVENT_BUFFER_SIZE; > - rxa_params->use_queue_event_buf =3D false; > - } else if ((!rxa_params->use_queue_event_buf && > - rxa_params->event_buf_size =3D=3D 0) || > - (rxa_params->use_queue_event_buf && > - rxa_params->event_buf_size !=3D 0)) { > - RTE_EDEV_LOG_ERR("Invalid adapter params\n"); > + temp_params->event_buf_size =3D ETH_EVENT_BUFFER_SIZE; > + temp_params->use_queue_event_buf =3D false; > + } else if (!rxa_params->use_queue_event_buf && > + rxa_params->event_buf_size =3D=3D 0) { > + RTE_EDEV_LOG_ERR("event buffer size can't be zero\n"); > return -EINVAL; > - } else if (!rxa_params->use_queue_event_buf) { > + } else if (rxa_params->use_queue_event_buf && > + rxa_params->event_buf_size !=3D 0) { > + RTE_EDEV_LOG_ERR("event buffer size needs to be configure= d " > + "as part of queue add\n"); > + return -EINVAL; > + } else { > + *temp_params =3D *rxa_params; > /* adjust event buff size with BATCH_SIZE used for fetchi= ng > * packets from NIC rx queues to get full buffer utilizat= ion > * and prevent unnecessary rollovers. > */ > - > - rxa_params->event_buf_size =3D > - RTE_ALIGN(rxa_params->event_buf_size, BATCH_SIZE)= ; > - rxa_params->event_buf_size +=3D (BATCH_SIZE + BATCH_SIZE)= ; > + if (!temp_params->use_queue_event_buf) { > + temp_params->event_buf_size =3D > + RTE_ALIGN(temp_params->event_buf_size, BA= TCH_SIZE); > + temp_params->event_buf_size +=3D (BATCH_SIZE + BA= TCH_SIZE); > + } > } > > - pc =3D rte_malloc(NULL, sizeof(*pc), 0); > - if (pc =3D=3D NULL) > - return -ENOMEM; > - > - *pc =3D *port_config; > + return 0; > +} > > - ret =3D rxa_create(id, dev_id, rxa_params, rxa_default_conf_cb, p= c); > - if (ret) > - rte_free(pc); > +int > +rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, > + rte_event_eth_rx_adapter_conf_cb conf_cb, > + void *conf_arg, > + struct rte_event_eth_rx_adapter_params *rxa_param= s) > +{ > + struct rte_event_eth_rx_adapter_params temp_params =3D {0}; > + int ret; > > - rte_eventdev_trace_eth_rx_adapter_create_with_params(id, dev_id, > - port_config, rxa_params, ret); > + ret =3D rxa_config_params_validate(rxa_params, &temp_params); > + if (ret !=3D 0) > + return ret; > > - return ret; > + return rxa_create(id, dev_id, &temp_params, conf_cb, conf_arg); > } > > int > rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id, > - struct rte_event_port_conf *port_config) > + struct rte_event_port_conf *port_config, > + struct rte_event_eth_rx_adapter_params *rxa_param= s) > { > struct rte_event_port_conf *pc; > int ret; > + struct rte_event_eth_rx_adapter_params temp_params =3D {0}; > > if (port_config =3D=3D NULL) > return -EINVAL; > > - RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > + ret =3D rxa_config_params_validate(rxa_params, &temp_params); > + if (ret !=3D 0) > + return ret; > > pc =3D rte_malloc(NULL, sizeof(*pc), 0); > if (pc =3D=3D NULL) > return -ENOMEM; > + > *pc =3D *port_config; > > - ret =3D rte_event_eth_rx_adapter_create_ext(id, dev_id, > - rxa_default_conf_cb, > - pc); > + ret =3D rxa_create(id, dev_id, &temp_params, rxa_default_conf_cb,= pc); > if (ret) > rte_free(pc); > return ret; > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_e= vent_eth_rx_adapter.h > index fe2a6bdd2c..35bf303079 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > @@ -26,7 +26,6 @@ > * The ethernet Rx event adapter's functions are: > * - rte_event_eth_rx_adapter_create_ext() > * - rte_event_eth_rx_adapter_create() > - * - rte_event_eth_rx_adapter_create_with_params() > * - rte_event_eth_rx_adapter_free() > * - rte_event_eth_rx_adapter_queue_add() > * - rte_event_eth_rx_adapter_queue_del() > @@ -45,7 +44,7 @@ > * > * The application creates an ethernet to event adapter using > * rte_event_eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_cre= ate() > - * or rte_event_eth_rx_adapter_create_with_params() functions. > + * functions. > * > * The adapter needs to know which ethernet rx queues to poll for mbufs = as well > * as event device parameters such as the event queue identifier, event > @@ -399,8 +398,9 @@ typedef uint16_t (*rte_event_eth_rx_adapter_cb_fn)(ui= nt16_t eth_dev_id, > * - <0: Error code on failure > */ > int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, > - rte_event_eth_rx_adapter_conf_cb conf_cb, > - void *conf_arg); > + rte_event_eth_rx_adapter_conf_cb conf_cb, > + void *conf_arg, > + struct rte_event_eth_rx_adapter_params *rxa_param= s); > > /** > * Create a new ethernet Rx event adapter with the specified identifier. > @@ -440,32 +440,6 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, = uint8_t dev_id, > * - <0: Error code on failure > */ > int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id, > - struct rte_event_port_conf *port_config); > - > -/** > - * This is a variant of rte_event_eth_rx_adapter_create() with additiona= l > - * adapter params specified in ``struct rte_event_eth_rx_adapter_params`= `. > - * > - * @param id > - * The identifier of the ethernet Rx event adapter. > - * > - * @param dev_id > - * The identifier of the event device to configure. > - * > - * @param port_config > - * Argument of type *rte_event_port_conf* that is passed to the conf_cb > - * function. > - * > - * @param rxa_params > - * Pointer to struct rte_event_eth_rx_adapter_params. > - * In case of NULL, default values are used. > - * > - * @return > - * - 0: Success > - * - <0: Error code on failure > - */ > -__rte_experimental > -int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_= id, > struct rte_event_port_conf *port_config, > struct rte_event_eth_rx_adapter_params *rxa_param= s); > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > index b03c10d99f..1cf58f0d6c 100644 > --- a/lib/eventdev/version.map > +++ b/lib/eventdev/version.map > @@ -101,7 +101,6 @@ EXPERIMENTAL { > global: > > # added in 21.11 > - rte_event_eth_rx_adapter_create_with_params; > rte_event_eth_rx_adapter_queue_conf_get; > rte_event_eth_rx_adapter_queue_stats_get; > rte_event_eth_rx_adapter_queue_stats_reset; > -- > 2.25.1 >