From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33917A0577; Tue, 7 Apr 2020 07:49:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74C412BE9; Tue, 7 Apr 2020 07:49:54 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id F2DAE2BE2 for ; Tue, 7 Apr 2020 07:49:52 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id r5so2021815ilq.6 for ; Mon, 06 Apr 2020 22:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=URt2HykAApvs5RDSbd37Q56Z3z/oYsyZwMLnEHMsaKQ=; b=dpZ2KdtqwmUZdB8MVM57UEweIap+VzJEJw2hUbKQeD04dg8gYcuhhHq9Y/2bHWowde y50ZpPUkUeeTLdO7o845wjEi2x8oUpCM2w1SyWYMTb+A4yNeS88MbAEY8KX2OJtFxxLQ Qd8L/fPpg71RgNxbZUxYw/BDcFnkCA3u5haB+NNpl3+R0XWHW/+NoVjrYROuVBwwtvxm XzQEV9lkOFu6oyZEMhIXAvLyqnyokqCvlTFTNGleVwwbRuPt+1wyjAzQgxrAI03Ilnln S8XhC5/kRxwns2t1+4RN0Lazb3bmp+PGu5cb38QbQtqusANpMrsCLISMJvg99Jy6JB9B 04ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=URt2HykAApvs5RDSbd37Q56Z3z/oYsyZwMLnEHMsaKQ=; b=muT5MEWckB1qLeFmZb15iuktyt92p8qO8bSdd80V/it36quem85goIDzjQ5iQDDipc AFFSuC8NBOeXQHuUPfrZAsW3rbekCcNiLoO9r3OHKv/WR+6DdA9GVmwqT19ipXhULH1e 6CdF4clJS1x0Q/0bdUXY0gNeiIsNO4wPjKQ3u2NPpJK9pgLcbJ520L/Z/4OIpq0sBbl1 j5g8OeVxE9ab639YD/uSQ5GExEcLeHocUeuTsArUZTuAkm60R55HM/z/HRxLoJ8FoC4h DJa/A8DCugSxr3mW3WCvURqYZsuy9nXkoPd+Smr5mc5KOxMJBHGuu5amGH65BJGj48fc 7/iA== X-Gm-Message-State: AGi0Pub7xRFpPOpOH8Dmg0qtTkzVlsdiynPEj3BZfzcN1J0TkyKV6ITI FUjmCUhNViaTG/JNZMwOEd6dGLDuIVEXimmQBN0= X-Google-Smtp-Source: APiQypIhTI3jlOEFBC3efF4VaquDLjoIyOl9sKDdkBxTUbHdxyHyJFDm4PklLPiMIq4x9Ud/TuV48mC1kajxqBhaJkM= X-Received: by 2002:a05:6e02:c6e:: with SMTP id f14mr717968ilj.271.1586238592224; Mon, 06 Apr 2020 22:49:52 -0700 (PDT) MIME-Version: 1.0 References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2061995.157zFVKu8G@xps> In-Reply-To: From: Jerin Jacob Date: Tue, 7 Apr 2020 11:19:36 +0530 Message-ID: To: Ori Kam Cc: Thomas Monjalon , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > If it abstracts it properly adding vdev and PCI is a simple change. > > See > > > > lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > lib/librte_eventdev/rte_eventdev_pmd_pci.h > > > > I think, the common code should take from other matured subsystem instead if > > writing from scratch, > > > I agree with you about the rewrite, but this is why I don't want to add this code > until I know what this code should do and how it should be used. > I don't agree, that one subsystem is like other one by default, and that if something > is done for one subsystem it should be done for other. > Not always what was done before is the best. > > Some time back there was a long thread about ethdev and the rte device > where should it be released and by whom. > My basic thinking is that unless proven otherwise the code should be in the PMD > this is also why it is important for me to get this rte level API acked. > when starting to implement the code for the PMD it will be cleared what > is the shared code and how it is best to configure the system. > Also this is not external API so it can be changed at any time. > Saying that I don't think we should wait long before adding such code. > I think that when we will have our first PMD we know better if such > function is needed. > Also think about that maybe this PMD will be shared with the > net PMD so such function will also introduce more complexity. My thought process was I like this when I added the common code for eventdev. I have checked ethdev, cryptodev and followed a similar scheme wherever it applicable for eventdev. If we see the regexdev API, it is similar to ethdev. cryptodev and eventdev API. From the device API PoV, the framework needs to follow the same behavior to avoid having new behavior for regexdev, Especially in configure->queue_setup->start->rx_burst->tx_burst->stop->reconfigure->start sequence. Ethdev may be bloated by features, My request is to take cryptodev and eventdev as a base change to accordingly. That makes review process easy, As reviewer needs only think, The rationale behind, Why it regexdev common code chosen a different approach. Writing from scratch makes the reviewer's job difficult. We spend a lot of time reviewing and make mature cryptodev and eventdev common code, Please leverage that.