From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F43A00BE; Wed, 30 Oct 2019 17:26:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 250CF1C036; Wed, 30 Oct 2019 17:26:09 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id B9B361BFCC for ; Wed, 30 Oct 2019 17:26:07 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id d83so2669874ilk.7 for ; Wed, 30 Oct 2019 09:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lz77djqcV/BqlJh6qcYq8/AAh9F95L9s9RcY1KdPYdk=; b=UCqv0ZinfVEP+Sy5Q4YxMMRiJDe29DJDWc8Vwlh2tqyfVMDATfZ7Natrx4dNnOCCBQ FwGd3j5YXI7U8ibsVJ9uzzTc5hxJe8IVqSD9rSucWZXnxRVQpSQKQm0K+qI8opq8QDgK zYTxsair8rRpuNFb5IXyR9BfS62RSif6KRC/nw2xSCWScrJ5pxj4P7iAUMgYVba8mLGG JN5zPBnthhXhsGqnB2uIGC6Nz8Ad+AkHSety8zD6C4EVqUBMJTbhRxlmQqwkJ2mpCIbk eLMrUg2N2L44Gff1r1WMfXdUhaDsyAeX1mVFCVxz19LBY/oMoOjgFKnYve2hyCmQFUON Xx3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lz77djqcV/BqlJh6qcYq8/AAh9F95L9s9RcY1KdPYdk=; b=hVcH4EbtKqvRhdcwKO7SCcVzWLZXgadGKtpndu5UT6eJw0oJxYrWHGZ+Nk5Gt+sOhI MwJ28IJt6QS8ZJ0b8D+RJu1XqVz2xdClMOBIvMQwe8qW+KoalPCxuf0BoSJIk7re+2Fu kZhNaBIWoYqTxAwu6xw6ODdMM7Jvjxfz2+nsV6uQzF349vBPAdHzrN4a5Vs65Qj0j3tQ gBhoU/gCypTYHyp36zD5liESrdGrEIV2denaETzrhaeMVW6sSuJTQiH8Yn/CFwCZjs0g nw8ZGQSr6F0hlIgeysYw4mx5FIekvAqJ738eLUIouSPu4Oxyhe/epJ9beOZSiRlKykl5 GrFw== X-Gm-Message-State: APjAAAWSta8/jYIPA7T3ErMl5S1R9aJrvl8lPMXPVpj9ugpX2TcYZYr2 efOiyAJmDzXIBEp9cvN9reDw7vylst9O4/B5Ivs= X-Google-Smtp-Source: APXvYqyTnoE39MOfkXVeOB61YjJ55WikKae+inSMbyKk2SyVRN+RVOIzb5L6yFiar/WLq04fOxtDJgsbNwmnsq72Ts0= X-Received: by 2002:a92:5e49:: with SMTP id s70mr35122ilb.130.1572452766758; Wed, 30 Oct 2019 09:26:06 -0700 (PDT) MIME-Version: 1.0 References: <20191029180357.16986-1-vattunuru@marvell.com> <20191030055410.28395-1-vattunuru@marvell.com> In-Reply-To: <20191030055410.28395-1-vattunuru@marvell.com> From: Jerin Jacob Date: Wed, 30 Oct 2019 21:55:48 +0530 Message-ID: To: Vamsi Attunuru Cc: dpdk-dev , Jerin Jacob , hkalra@marvell.com, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: skip flow control on lbk ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 30, 2019 at 11:24 AM wrote: > > From: Vamsi Attunuru > > LBK interface does not support any flow control related > HW configurations. > > Skip flow control set requests on LBK bound ethports. > > Signed-off-by: Harman Kalra > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > V2 change: > * Updated log type. > > drivers/net/octeontx2/otx2_flow_ctrl.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/octeontx2/otx2_flow_ctrl.c b/drivers/net/octeontx2/otx2_flow_ctrl.c > index 1d00e46..1b84998 100644 > --- a/drivers/net/octeontx2/otx2_flow_ctrl.c > +++ b/drivers/net/octeontx2/otx2_flow_ctrl.c > @@ -50,6 +50,11 @@ otx2_nix_flow_ctrl_get(struct rte_eth_dev *eth_dev, > struct otx2_mbox *mbox = dev->mbox; > int rc; > > + if (otx2_dev_is_lbk(dev)) { > + fc_conf->mode = RTE_FC_NONE; > + return 0; > + } > + > req = otx2_mbox_alloc_msg_cgx_cfg_pause_frm(mbox); > req->set = 0; > > @@ -137,6 +142,11 @@ otx2_nix_flow_ctrl_set(struct rte_eth_dev *eth_dev, > uint8_t tx_pause, rx_pause; > int rc = 0; > > + if (otx2_dev_is_lbk(dev)) { > + otx2_info("No flow control support for LBK bound ethports"); > + return -ENOTSUP; > + } > + > if (fc_conf->high_water || fc_conf->low_water || fc_conf->pause_time || > fc_conf->mac_ctrl_frame_fwd || fc_conf->autoneg) { > otx2_info("Flowctrl parameter is not supported"); > @@ -189,6 +199,9 @@ otx2_nix_update_flow_ctrl_mode(struct rte_eth_dev *eth_dev) > struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > struct rte_eth_fc_conf fc_conf; > > + if (otx2_dev_is_lbk(dev)) > + return 0; > + > memset(&fc_conf, 0, sizeof(struct rte_eth_fc_conf)); > /* Both Rx & Tx flow ctrl get enabled(RTE_FC_FULL) in HW > * by AF driver, update those info in PMD structure. > -- > 2.8.4 >