From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: allow vfs to enable back pressure
Date: Thu, 3 Oct 2019 20:28:56 +0530 [thread overview]
Message-ID: <CALBAE1PA0YqVnd3qPN1fgfEqoOHayE6-sibV2f_3bu81zq7Umg@mail.gmail.com> (raw)
In-Reply-To: <20190830040443.6413-1-ndabilpuram@marvell.com>
On Fri, Aug 30, 2019 at 9:35 AM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Allow VFs to enable backpressure for performance reasons.
> The backpressure control is with kernel AF driver that will enable
> backpressure even if one PF/VF requests it and disable it only
> after all the PFs/VFs request for disable.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/octeontx2/otx2_flow_ctrl.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_flow_ctrl.c b/drivers/net/octeontx2/otx2_flow_ctrl.c
> index 419ad97..1d00e46 100644
> --- a/drivers/net/octeontx2/otx2_flow_ctrl.c
> +++ b/drivers/net/octeontx2/otx2_flow_ctrl.c
> @@ -14,9 +14,6 @@ otx2_nix_rxchan_bpid_cfg(struct rte_eth_dev *eth_dev, bool enb)
> struct nix_bp_cfg_rsp *rsp;
> int rc;
>
> - if (otx2_dev_is_vf(dev))
> - return 0;
> -
> if (enb) {
> req = otx2_mbox_alloc_msg_nix_bp_enable(mbox);
> req->chan_base = 0;
> @@ -53,9 +50,6 @@ otx2_nix_flow_ctrl_get(struct rte_eth_dev *eth_dev,
> struct otx2_mbox *mbox = dev->mbox;
> int rc;
>
> - if (otx2_dev_is_vf(dev))
> - return -ENOTSUP;
> -
> req = otx2_mbox_alloc_msg_cgx_cfg_pause_frm(mbox);
> req->set = 0;
>
> @@ -143,9 +137,6 @@ otx2_nix_flow_ctrl_set(struct rte_eth_dev *eth_dev,
> uint8_t tx_pause, rx_pause;
> int rc = 0;
>
> - if (otx2_dev_is_vf(dev))
> - return -ENOTSUP;
> -
> if (fc_conf->high_water || fc_conf->low_water || fc_conf->pause_time ||
> fc_conf->mac_ctrl_frame_fwd || fc_conf->autoneg) {
> otx2_info("Flowctrl parameter is not supported");
> @@ -198,9 +189,6 @@ otx2_nix_update_flow_ctrl_mode(struct rte_eth_dev *eth_dev)
> struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
> struct rte_eth_fc_conf fc_conf;
>
> - if (otx2_dev_is_vf(dev))
> - return 0;
> -
> memset(&fc_conf, 0, sizeof(struct rte_eth_fc_conf));
> /* Both Rx & Tx flow ctrl get enabled(RTE_FC_FULL) in HW
> * by AF driver, update those info in PMD structure.
> --
> 2.8.4
>
prev parent reply other threads:[~2019-10-03 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 4:04 Nithin Dabilpuram
2019-10-03 14:58 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PA0YqVnd3qPN1fgfEqoOHayE6-sibV2f_3bu81zq7Umg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).