From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17B98A051A; Thu, 16 Jan 2020 19:44:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CF1F1D441; Thu, 16 Jan 2020 19:44:03 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 3DA041C2F5; Thu, 16 Jan 2020 19:44:02 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id b10so23039806iof.11; Thu, 16 Jan 2020 10:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MC8rZv9813VQyyUDula+XJoXAUoKh92UpI2yjDAWn3A=; b=iWMyb+k2B4n7PRtx/2ZqP+Asku8vhuafxxwAuHcEgMBaTnIZIa4cuhw5MtdFsmth0K qIt0t3XP9uafEmBtWwuYrHOYs7Y3snB577Pp0D8D5u9T0+lCoC+WEZOEydn0puCfsqeZ Y597a6fcAmkbVqXhJW2l9p//PpTUzdwhXbvIp7E+GIEP7mW4rbmN0bY62cg1aUuGToVr ggyrvffUa2gt6FmTJEMylc7Ynv0L4/tJ+kk4ITNDjcOfZxKvb6MGj45Lc2KHQGb6R1iv Hep1opKPgl4fgy9kvz9mtr8L6XKBvGu44zvoqMvvm6DBzsNSvMU2Jju7auaNZ1/E6PnZ tSTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MC8rZv9813VQyyUDula+XJoXAUoKh92UpI2yjDAWn3A=; b=IZAKTHcqVRh3Yz48sijgBSKFJhKRWn/jmkUidbBGJWb7gxNQ53dFXXNhYOHcGj12uI eNXgMhH2JC0HxZXLeVnDdTGXP+hUFOTP5HJ60ObPJ3eTFszK4iOAjFiIN74n1wE0ZA85 eKFnuvVVMB9HbM84+cjuhwJn0sikD4n+jGBt5umusWYKk4E3NscrLtatpL4I6nKLUrXO mmX4V8wZ9EYMKj4HsobgKh+30PbFETedQbmhJGgOP0muwZTOlrGR2sANFEsUW5CVpJVQ yuq7djbgXs1yEcn+AbZBY0KfvOggGQsQpohxIJvudn3rPM17fnFc0leohjaThbm8Ew34 eNfA== X-Gm-Message-State: APjAAAUYtrwCcGbvnTPS7p6jORB3MGQPhh/UxxccgMIjgF8ew61uk+3X KzG2PPhahQvJ1Op5VHQtR0Wx4yCegbF6O7ITiSkzgVQtX8E= X-Google-Smtp-Source: APXvYqzVcOTq2iYAVhCMdplh8908FgYQQF97wRr+2gIbp5VNLQnbFfVFwy45rNx8M7GqNioQ/ID5ivmB6PiuV9WBVIs= X-Received: by 2002:a5d:8cce:: with SMTP id k14mr28833119iot.294.1579200241442; Thu, 16 Jan 2020 10:44:01 -0800 (PST) MIME-Version: 1.0 References: <20191212131302.1626130-1-jerinj@marvell.com> <898e1731-4921-721b-0e42-ada50ab2bf94@redhat.com> In-Reply-To: <898e1731-4921-721b-0e42-ada50ab2bf94@redhat.com> From: Jerin Jacob Date: Fri, 17 Jan 2020 00:13:45 +0530 Message-ID: To: Maxime Coquelin Cc: Jerin Jacob , dpdk-dev , Thomas Monjalon , techboard@dpdk.org, "Richardson, Bruce" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin wrote: > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > Ping. > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > >> > >> From: Jerin Jacob > >> > >> Based on the techboard meeting held on 2019-11-06, > >> It's been decided to disable all kmods by default from v20.02. > >> > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html > >> > >> Signed-off-by: Jerin Jacob > >> --- > >> config/common_linux | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/config/common_linux b/config/common_linux > >> index c5cf3d662..583efadc7 100644 > >> --- a/config/common_linux > >> +++ b/config/common_linux > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > >> > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > >> -CONFIG_RTE_EAL_IGB_UIO=y > >> CONFIG_RTE_EAL_VFIO=y > >> -CONFIG_RTE_KNI_KMOD=y > >> CONFIG_RTE_LIBRTE_KNI=y > >> CONFIG_RTE_LIBRTE_PMD_KNI=y > >> CONFIG_RTE_LIBRTE_VHOST=y > >> -- > >> 2.24.0 > >> > > > > Looks good for make build system, but what about Meson? > as per meson_options.txt, isn't it enabled by default? > $ grep -rn enable_kmods meson_options.txt > 7:option('enable_kmods', type: 'boolean', value: true, + Bruce, Since meson autodetect the presence of Linux kernel dependency for the kmod build, I thought of keeping as it is as there is no harm. I am fine with either way, let me the know the feedback, I will send the v2 based on the comment. > > Thanks, > Maxime >