From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CFBFA0561; Tue, 21 Apr 2020 07:48:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92AC61D6C3; Tue, 21 Apr 2020 07:48:05 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 3585E1D67F for ; Tue, 21 Apr 2020 07:48:04 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id s10so11545868iln.11 for ; Mon, 20 Apr 2020 22:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rjOX25l/4TJiPpfH7chAaAtLm3dOX0q0N/ypCZX6sCg=; b=iTF4n5nb6bgpJMSO7yg22q8n1v+WTbkChkku82EJY2dZnvJwiLk+e0Rkx5ccmQwXFV syrpDy6/GoGOetRdAayWf6ro8jBdip/6+oAzouISJjmLDA9pL7m2WcFXaSwzPZ8aBYp+ 7WEmej5JAyqjGCbZR5UvZfovyLjlZ071lZfazZJDXgXqvgn2AGc0YcczvelvpILkk5Ta kqQoIEScVcMiF9wRzNUDyMYhL9TNpire2gh5Zvk8E7COQoS0dhQEaIlQQhp5TwoNS/tf pMhXaBMPmFILJddabAUX4X5c1t7px6jIKQtjkoRsmqKm7E21+B4xiveRmNJkZ0NdHQRg VT3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rjOX25l/4TJiPpfH7chAaAtLm3dOX0q0N/ypCZX6sCg=; b=N+K2mBZLU+JA5X2EsICgdnLIxsknwB6MgZeIk378WbV3/FOxuu/QQT9jzYXKHQB4Pc ryAHURIUhyML+EYYroEHuOMukDT/Oce8mA94cRz2yBz2m0TCEhg7AHGNWSrF8j4xDU1m WcvjGr1ItLm6gXBn5tXGeBdZInLDCS1zed9ISriotCAeEM2xRezE2jCFqapobhsCtQRY 0dmYySyCsK437N5YvsIBdVRoBrzRj1Be3fzWNtSyT8c/IjHuvga7X54qmE9eXeL88555 2dzV6QMslp+K3FJhapWoCfMZGnC3WEZ0wbxVM91W5rN5CKNruoGh/ALAeFefFEBYaT5D ifhw== X-Gm-Message-State: AGi0PuaBRMuVscl3TVBhK2qfBWtEsmGY2el4sCOhClhNuTgOnrx1bon1 7hdtm0a1YUm9lBNakR0G5YoHTM4JsEl+dY8EWD0= X-Google-Smtp-Source: APiQypJ3A2p0Ma9aYcvoOTCuLLgd39n03JxSQTcVE66Drsxx2cWj5rSjTUDdPWqjbjHho7h1MFHoEvc00yxlPxgQ98o= X-Received: by 2002:a05:6e02:790:: with SMTP id q16mr18124012ils.60.1587448083342; Mon, 20 Apr 2020 22:48:03 -0700 (PDT) MIME-Version: 1.0 References: <20200413150116.734047-1-jerinj@marvell.com> <20200419100133.3232316-1-jerinj@marvell.com> <20200419100133.3232316-34-jerinj@marvell.com> <3354690.gORTcIGjah@thomas> In-Reply-To: <3354690.gORTcIGjah@thomas> From: Jerin Jacob Date: Tue, 21 Apr 2020 11:17:47 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , dpdk-dev , "Richardson, Bruce" , David Marchand , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > Hi, > > Below is a doc review. > General comment: it is better to split lines after punctuation signs > in order to make future patches easier to read. Thanks for the review. Except below two comments, Everything else accepted and fixed in v7. > > + > > +Register the tracepoint > > +~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +.. code-block:: c > > + > > + #define RTE_TRACE_POINT_REGISTER_SELECT /* Select trace point register macros */ > > I don't understand this #define. See the headerfile. /** * Macro to select rte_trace_point_emit_* definition for trace register function * * rte_trace_point_emit_* emits different definitions for trace function. * Application must define RTE_TRACE_POINT_REGISTER_SELECT before including * rte_trace_point.h in the C file where RTE_TRACE_POINT_REGISTER used. * * @see RTE_TRACE_POINT_REGISTER */ #define RTE_TRACE_POINT_REGISTER_SELECT > > > +Trace file location > > +------------------- > > + > > +On ``rte_trace_save()`` or ``rte_eal_cleanup()`` invocation, the library saves > > +the trace buffers to the filesystem. By default, library saves trace files at > > +``$HOME/dpdk-traces/rte-yyyy-mm-dd-[AP]M-hh-mm-ss/``. It can be overridden by > > Please don't create a specific directory, but use rte_eal_get_runtime_dir(). Trace files are huge in size, /var/run is not the correct place to store it. User needs to have control over where the trace file generated.It can be different than rte_eal_get_runtime_dir(). Multiple DPDK application running case has been taken care of by using eal_get_hugefile_prefix() in trace session creation. > > +the ``--trace-dir=`` EAL command line option. > > I don't think this option is needed. > XDG_RUNTIME_DIR environment variable can do the same.