From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5C51A034E; Wed, 9 Feb 2022 06:50:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9245B41101; Wed, 9 Feb 2022 06:50:39 +0100 (CET) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id 7E83E410F3 for ; Wed, 9 Feb 2022 06:50:38 +0100 (CET) Received: by mail-il1-f169.google.com with SMTP id c12so234134ilm.8 for ; Tue, 08 Feb 2022 21:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SPFwKoYaVcPDrmV4yjyi73Tk8DFfJ93zXkl1WNaNLj0=; b=LjDj36YqUBX3sCxBzhaQP77lC8ESSKT5zJ3tFO/mJ1pFLLNHKTIqM0/wmFZajNKDyG FA8JGKfrpVmPU3hNAiuo4Ff5qfHV2d10nDy1Rhanbq517ImhCFK3v+uWR+DFtbfHNz2j F+VwEe2Tr54DlGhny7FZdkbgRvJkHotIeOkUfmr5V8YMyD5OWq+UxPQ6+LH6Fd3aiypt QrdiES+mLlv9C6xewoHWvfza7oTn9mKCtOdbzd77O3nNNmCzWRBFQ2rh4a6YbYY2cc0p N94v/a0Sh0jg4AI92hTO3w0vN0Benw9htvucOd1C9t0Br5m2WrJSuoOz4PeYu4W/3yvB pmbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SPFwKoYaVcPDrmV4yjyi73Tk8DFfJ93zXkl1WNaNLj0=; b=xmu5IMvwWJ3iGwqGrfsHcrrGlICgs/xQYpk2dHSHz4jRHWCrP7J6IC2VeLZq/f/sel RYeJuinMRA04vhzR7R8qsqRx//IA0Y25MZ7vOf8ypC0GsesvIbTSM5BCqDFlSl3ipke0 DcR+wxmdAvoyANZPrZPdEiYUXCxwJSrNy2T9BeDY3cKyVT2e/PUvZ9urbHD7AZBeBrlK t2KiNS6wtQ17T5qdzQIfRtQUJOYtX1rt+Ek5YmnDmihzYIsZLPjz86+nwny+WnZVAkU7 5ERUCoheyZI07F/+iBObwWs09wvvS0cN6HKDlcRNJjW15OWX2Esj+haXkNkiSas2txnv g33g== X-Gm-Message-State: AOAM53208g9XpO8qod1C3oAHsEQPpZjxeOptiDCQatV7Vnp5kvSJB5Eo /2jrlYtGT/CXtII/S7lziDLR2XzWF4FHnZeNFVk= X-Google-Smtp-Source: ABdhPJwePZdmbBVy63qi4Fsa0SdaBBbZNTqLbGIGu7q4EcX0x+URvZ3Dm6UM/EoF0/L9a0Fyxpsek4BdPlkKKa4ctAM= X-Received: by 2002:a05:6e02:1ca4:: with SMTP id x4mr325241ill.262.1644385837825; Tue, 08 Feb 2022 21:50:37 -0800 (PST) MIME-Version: 1.0 References: <20220118153027.3947448-1-akozyrev@nvidia.com> <20220206032526.816079-1-akozyrev@nvidia.com> <20220206032526.816079-4-akozyrev@nvidia.com> In-Reply-To: From: Jerin Jacob Date: Wed, 9 Feb 2022 11:20:11 +0530 Message-ID: Subject: Re: [PATCH v3 03/10] ethdev: bring in async queue-based flow rules operations To: Alexander Kozyrev Cc: dpdk-dev , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ivan Malov , Andrew Rybchenko , Ferruh Yigit , "mohammad.abdul.awal@intel.com" , Qi Zhang , Jerin Jacob , Ajit Khaparde Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 8, 2022 at 7:42 PM Alexander Kozyrev wrote: > > > On Tuesday, February 8, 2022 5:57 Jerin Jacob wrote: > > On Sun, Feb 6, 2022 at 8:57 AM Alexander Kozyrev > > wrote: > > > > > +The asynchronous flow rule insertion logic can be broken into two phases. > > > + > > > +1. Initialization stage as shown here: > > > + > > > +.. _figure_rte_flow_q_init: > > > + > > > +.. figure:: img/rte_flow_q_init.* > > > + > > > +2. Main loop as presented on a datapath application example: > > > + > > > +.. _figure_rte_flow_q_usage: > > > + > > > +.. figure:: img/rte_flow_q_usage.* > > > > it is better to add sequence operations as text to understand the flow. > > I prefer keeping the diagram here, it looks more clean and concise. > Block of text gives no new information and harder to follow, IMHO. I forgot to reply yesterday on this specific item. IMO, The diagram is good. The request is, In the diagram, you can add items like [1] [2] etc and corresponding text can be added either in image or as text See example https://doc.dpdk.org/guides/prog_guide/event_crypto_adapter.html Fig. 49.2.