From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20412A2EEB for ; Mon, 7 Oct 2019 19:08:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06D6C1D14F; Mon, 7 Oct 2019 19:08:46 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by dpdk.org (Postfix) with ESMTP id 999931C20B for ; Mon, 7 Oct 2019 19:08:44 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id q1so30334452ion.1 for ; Mon, 07 Oct 2019 10:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z7QUaU9k+hHZqUNh9mXsAYNP2IIMJhzq8sy6NeuGn4g=; b=oYU4BWyDkfSa6hCcMcGRjVXFbvMjEfV5DS6+YPImluji4okTz1C/ZpQ3UvtuO4qk5M r8kWgIkKuQrWrDi1KdhpVRVDXZqRKvLYG3/xYLHPEADM4yGnoPloYmiSBGHnTZ5ykNBC xeUTZaGnv8+TaUd/DkO15SeIaCCCFoDla/QV9IiP+43JXY1Rn9wjvVeMRvwyXir9Ga1X Xor8n5R+CdX/DIzfiJoZFhpf3WGebEYsj9Hde4b1IVdzRBn/oyKB1SZwLWLjQotH+rkL nYIU1LMHu1m8ustbVzaGfvZFxmw7Jhsplaz8FGDZ+DWOBqy+lu7+3DNhXOCHIytUkHrN Q4IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z7QUaU9k+hHZqUNh9mXsAYNP2IIMJhzq8sy6NeuGn4g=; b=gnkfi6+cgHyUF2BpVKVacSHMznVudk+MHplwtPOfu47OB+Jv85dPDVsIGMgHMkzwcF R1E2J5noswdS21LkLKJbXFvWDLHMwGqgtrbdffOgTFdHhg3kXEG4Gx+vBJTMRhK+JdhW fL9qKcHDoDNvOb9Go2rmy3Tu+th2KqRn7kIcUnEFNA8vBMoQMuLjo3B+YNsDUcOTuZ5A WhzjBCRfnhmvSMyZx1uBhCvaQ+xTWlfcOmlaBidmxRkoW+uwYHER2jqRntySybCXTRmm kJ0StKhhGSO7cf6BmwZJhNv18ni16UuUjWWs1kOl+WHt3VG4KvXJFjeuGWb5hNkgtNVQ wwYA== X-Gm-Message-State: APjAAAV1oUtpRIN2Qxf4JEXxB6UfWFRM2NyaRxx4XulFYtf40vn91hea Mh64QA6BYZCE7zG0bl7ZGo9cW24BHtbm68pkSVVAQ3p5 X-Google-Smtp-Source: APXvYqxj7mnlqeucmssjcIkvNYg+xbDKZeYs+PDp0rJkvV8fgMAUqFOyv2ROOFRkBjXlOueyoSfMjWmNAizNujNGKrk= X-Received: by 2002:a5d:9f15:: with SMTP id q21mr12752602iot.130.1570468123569; Mon, 07 Oct 2019 10:08:43 -0700 (PDT) MIME-Version: 1.0 References: <20191007165232.14535-1-stephen@networkplumber.org> <20191007165232.14535-6-stephen@networkplumber.org> In-Reply-To: <20191007165232.14535-6-stephen@networkplumber.org> From: Jerin Jacob Date: Mon, 7 Oct 2019 22:37:43 +0530 Message-ID: To: Stephen Hemminger Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, wrote: > Simple classic BPF interpreter based off of libpcap. > > This is a copy of the BPF interpreter from libpcap which is > modified to handle mbuf meta data. The existing pcap_offline_filter > does not expose a way to match VLAN tags. Copying the BPF interpreter > also means that rte_pdump still does not have a hard dependency > on libpcap. > Why not use DPDK's librte_bpf library? Rather implementing cBPF interpreter. Currently it supports eBPF which is super set of cBPF.if is this features very specific to cBPF, we clould simply implement cBPF using eBPF or implement a new cBPF program type. That scheme could leverage existing JIT infrastructure also. Using JIT will improve filtering performance. > >