From: Jerin Jacob <jerinjacobk@gmail.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
dpdk stable <stable@dpdk.org>, Nalla Pradeep <pnalla@marvell.com>,
Radha Mohan Chintakuntla <radhac@marvell.com>,
Veerasenareddy Burru <vburru@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer
Date: Tue, 29 Jun 2021 23:39:48 +0530 [thread overview]
Message-ID: <CALBAE1PENhJuoCFow1VjBa6d7wwgCS9VVmLN37_-PeQADXFJig@mail.gmail.com> (raw)
In-Reply-To: <20210524085935.16403-1-thierry.herbelot@6wind.com>
On Mon, May 24, 2021 at 2:30 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> mz is known to be NULL: do not use it to print a memzone name.
>
> Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
> Cc: stable@dpdk.org
> Cc: Nalla Pradeep <pnalla@marvell.com>
> Cc: Radha Mohan Chintakuntla <radhac@marvell.com>
> Cc: Veerasenareddy Burru <vburru@marvell.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Changed the git log to following and Applied to
dpdk-next-net-mrvl/for-next-net. Thanks
Author: Thierry Herbelot <thierry.herbelot@6wind.com>
Date: Mon May 24 10:59:35 2021 +0200
net/octeontx_ep: fix null pointer access
mz is known to be NULL. Do not use it to print a memzone name.
Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
Cc: stable@dpdk.org
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> drivers/net/octeontx_ep/otx_ep_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> index 28ff74d2d5b0..a7d433547e36 100644
> --- a/drivers/net/octeontx_ep/otx_ep_rxtx.c
> +++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> @@ -27,7 +27,7 @@ otx_ep_dmazone_free(const struct rte_memzone *mz)
> int ret = 0;
>
> if (mz == NULL) {
> - otx_ep_err("Memzone %s : NULL\n", mz->name);
> + otx_ep_err("Memzone: NULL\n");
> return;
> }
>
> --
> 2.29.2
>
prev parent reply other threads:[~2021-06-29 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 8:59 Thierry Herbelot
2021-06-29 18:09 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PENhJuoCFow1VjBa6d7wwgCS9VVmLN37_-PeQADXFJig@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=pnalla@marvell.com \
--cc=radhac@marvell.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).