From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE6DEA0C46; Tue, 7 Sep 2021 11:37:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93205410ED; Tue, 7 Sep 2021 11:37:54 +0200 (CEST) Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by mails.dpdk.org (Postfix) with ESMTP id 525E3410EC for ; Tue, 7 Sep 2021 11:37:52 +0200 (CEST) Received: by mail-il1-f171.google.com with SMTP id l10so9302031ilh.8 for ; Tue, 07 Sep 2021 02:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oKEIH5gUIfkWyNinu/1gnGXxhxH3dG+LQ7poie9C/8w=; b=gYMrLh3ER7mLZohlRhHa/uMxOzdGLIYqbYbxC9K49uqLiBr7/Ljuz6aVx6iWtbCMUJ To6hfnIrmFA+YkrSgwvtH5n0rrP5AZr0Smvriq5py19g+l3eMKD83upbEA77JvQbXaqw 1AonHGv8y0uluCCXr4/yNoZfqggCAmktA55Ysnv8YJt2zB2Bl8UmXudhS2UrNiaOyz0b XBtrnuckMvBooQFlFzF+H3OGfMYt4Nuv9Bv1IMbYSDhnkW5vqEsN0EaDGA4EfrzdhYSN KKjEZzndUm0tNC2srWau78J4KMbuVKHsaaV8zZTCXmdcvjid5bZ9PBpK0ts27uePFA8+ xXCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oKEIH5gUIfkWyNinu/1gnGXxhxH3dG+LQ7poie9C/8w=; b=CK4QZ33fwKilDsLYyXuz5Wz3mnNW2JmSYi06uU8wryDfIp8E/Mq4d3GkuU9C/aN0sW NYonh64ieP0kWuo8NkXqy3+UbpqyUsyMb4VAu3IGHpR0mNYiANTFLGJVkU+BX+T7S8+c I58Ngrvd4GbyTIiyAV6MH8Qt4PLbCh556n22VI8nTjYBIknp9s0E42ewIdvnYSNcm06D oOahCjBwXL7AQZlinvBQP/ZBXe2UQcDFNDmSPs4QnZ/cYzgGGtxxbDq8xyGyvkckf7w6 lXRfzAPZWUJvQ6NwZrni1wKlByCkRnkA9xoSVVGA3uyMKzyLUSMPtilWV2yZYNY0MIGc uM9g== X-Gm-Message-State: AOAM532mZRFMiptyW0svza8UPkkpgMIq9Ew0n7rLAwJm3ksGajOof9qB 0IM8gewFt+4CLsmXG+l1mD0n3Epa5I3ZrngXKBs= X-Google-Smtp-Source: ABdhPJxNdiVBhsm5/yFQbAil05Fz6CEKOesm+Z2befVthIvw3Z427NNevP/Fb7q1/O/LuB0YB7S+ZJ6T31JSIwFEP7c= X-Received: by 2002:a05:6e02:1a4f:: with SMTP id u15mr11413909ilv.251.1631007471767; Tue, 07 Sep 2021 02:37:51 -0700 (PDT) MIME-Version: 1.0 References: <20210907053642.4093569-1-ganapati.kundapura@intel.com> <20210907064518.376652-1-ganapati.kundapura@intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 7 Sep 2021 15:07:24 +0530 Message-ID: To: "Kundapura, Ganapati" Cc: "Jayatheerthan, Jay" , dpdk-dev , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] eventdev: add rx queue info get api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 7, 2021 at 2:20 PM Kundapura, Ganapati wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: 07 September 2021 13:42 > > To: Kundapura, Ganapati > > Cc: Jayatheerthan, Jay ; dpdk-dev > > ; Pavan Nikhilesh > > Subject: Re: [PATCH v3 1/3] eventdev: add rx queue info get api > > > > in > > > > On Tue, Sep 7, 2021 at 12:15 PM Ganapati Kundapura > > wrote: > > > > > > Added rte_event_eth_rx_adapter_queue_info_get() API to get rx queue > > > information - event queue identifier, flags for handling received > > > packets, schedular type, event priority, polling frequency of the > > > receive queue and flow identifier in > > > rte_event_eth_rx_adapter_queue_info structure > > > > > > Signed-off-by: Ganapati Kundapura > > > > > > --- > > > v3: > > > * Split single patch into implementaion, test and document updation > > > patches separately > > > > > +struct rte_event_eth_rx_adapter_queue_info; > > > + > > > +/** > > > + * Retrieve information about Rx queue. This callback is invoked if > > > + * the caps returned from the eventdev_eth_rx_adapter_caps_get(, > > > +eth_port_id) > > > + * has RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT set. > > > > It will useful for !RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT case > > too. > > Missed this comment in v4 > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h > > > b/lib/eventdev/rte_event_eth_rx_adapter.h > > > index 182dd2e..75c0010 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > > > @@ -33,6 +33,7 @@ > > > * - rte_event_eth_rx_adapter_stop() > > > * - rte_event_eth_rx_adapter_stats_get() > > > * - rte_event_eth_rx_adapter_stats_reset() > > > + * - rte_event_eth_rx_adapter_queue_info_get() > > > * > > > * The application creates an ethernet to event adapter using > > > * rte_event_eth_rx_adapter_create_ext() or > > > rte_event_eth_rx_adapter_create() @@ -140,6 +141,56 @@ typedef int > > (*rte_event_eth_rx_adapter_conf_cb) (uint8_t id, uint8_t dev_id, > > > void *arg); > > > > > > /** > > > + * Rx queue info > > > + */ > > > +struct rte_event_eth_rx_adapter_queue_info { > > > > Can we avoid the duplication of this structure and use > > rte_event_eth_rx_adapter_queue_conf instead. > > > > API can be rte_event_eth_rx_adapter_queue_conf_get() to align the > > structure. > > > > Also instead of every driver duplicating this code, How about > > - common code stores the config in > > rte_event_eth_rx_adapter_queue_add() > > - common code stores the config in > > rte_event_eth_rx_adapter_queue_conf_get() > > - Addtional PMD level API can be given incase, something needs to > > overridden by Adapter. Missed addressing this comment in v4.