From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C535A04B4; Sat, 2 May 2020 12:32:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 137371D616; Sat, 2 May 2020 12:32:13 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 94CAD1D614 for ; Sat, 2 May 2020 12:32:11 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id z2so7258067iol.11 for ; Sat, 02 May 2020 03:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jkTHTvYR3t0hnWU4vYG0F8PgoTBazIMC9aqbSkx7/Lk=; b=kNVcyuh2L6S379Zx0ysRWm+cTiOStRikwCagDkES6UykKaQuL56F2NS+zfIQcBZcZm BoU2lN4o2bZRoTDYi4mGmV8YGkksv9nYhAcm6ujrz3M8uD9prJy9sE9VKQlb8hjE2blG 5zayvqgN1jiBqFCAwGPA8yfYvGcWrkHFK3bPP5UY5quUuK3ramy7c7BlMYErlWbuf1TE /hDuomMpaVeJLeinW1zrKCxwxg1JXhRvIsDy7O0GR13ADXCdbynmueW4b0s3EXSrutqW 5LBXqQWOOU47z/ubpunA2mEmrLZk0qRWfmNKPFqC13ItpUM82aP41yvX7c8omQ9pTmeM zs4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jkTHTvYR3t0hnWU4vYG0F8PgoTBazIMC9aqbSkx7/Lk=; b=j7xhj3vuwtGPz15TZd8XCQQqXB16SlyAuHrPNpr30zDRTeChHskosgHVHHtD4dSluP xvz151KSy9djZOSrs0OxDolZ/EWAupI+HBAZd1L9UbbhBnkygkjkWTqzLoMigN7AISCb mfUHUzhyGRvGE/NSGNNmJOa5dvRrsnFMzbDgD+yR1VcLsQdf1qRb1XP6w/08eb5dnKXb wAsFAre+p43IUO/ety5j0ZBnwcmuLGpDqOTdrP0rSwJA42VdwdueR31cdemXO4ClXTQ2 Jy7KPDV0HfNUnxS7fItX3GTN8lP8Oxbl1Vrxxfm93/iuW+OQ3Cwj0qTS/fzOhNTbXCBM ilrw== X-Gm-Message-State: AGi0Pua03VkC8+ElnsMJFjFyQDpsRUU+4Y+Zc/WTIDknUv5FtbONWkdL hoz7I3rhBgBQNnga1yYbBlCTNvzsB/PmUOui0+A= X-Google-Smtp-Source: APiQypJy0CwklpszXMxJKT9kfRuigX41Y0aRSXidvUDecZSBei/FZI0SAeyi6EBWREju1CcDhX/sSBZuhpfA2BKCJLk= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr6880609jal.60.1588415530896; Sat, 02 May 2020 03:32:10 -0700 (PDT) MIME-Version: 1.0 References: <20200427181039.1943-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Sat, 2 May 2020 16:01:54 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , Anatoly Burakov , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix device probe and remove for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 1, 2020 at 6:56 PM Jerin Jacob wrote: > > On Mon, Apr 27, 2020 at 11:40 PM wrote: > > > > From: Pavan Nikhilesh > > > > When probing event device in secondary process skip reinitializing > > the device data structure as it is already done in primary process. > > > > When removing event device in secondary process skip closing the > > event device as it should be done by primary process. > > > > Fixes: 322d0345c2bc ("eventdev: implement PMD registration functions") > > Cc: stable@dpdk.org > > > > > Signed-off-by: Pavan Nikhilesh > > > Acked-by: Jerin Jacob Applied to dpdk-next-eventdev/master. Thanks. > > > > > --- > > lib/librte_eventdev/rte_eventdev.c | 13 ++++++++----- > > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +++++--- > > 2 files changed, 13 insertions(+), 8 deletions(-) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > > index b987e0745..9aca7fbd5 100644 > > --- a/lib/librte_eventdev/rte_eventdev.c > > +++ b/lib/librte_eventdev/rte_eventdev.c > > @@ -1364,14 +1364,17 @@ rte_event_pmd_allocate(const char *name, int socket_id) > > > > eventdev->data = eventdev_data; > > > > - strlcpy(eventdev->data->name, name, RTE_EVENTDEV_NAME_MAX_LEN); > > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > > > > - eventdev->data->dev_id = dev_id; > > - eventdev->data->socket_id = socket_id; > > - eventdev->data->dev_started = 0; > > + strlcpy(eventdev->data->name, name, > > + RTE_EVENTDEV_NAME_MAX_LEN); > > > > - eventdev->attached = RTE_EVENTDEV_ATTACHED; > > + eventdev->data->dev_id = dev_id; > > + eventdev->data->socket_id = socket_id; > > + eventdev->data->dev_started = 0; > > + } > > > > + eventdev->attached = RTE_EVENTDEV_ATTACHED; > > eventdev_globals.nb_devs++; > > } > > > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > > index 8fb61386f..443cd38c2 100644 > > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > > @@ -112,9 +112,11 @@ rte_event_pmd_pci_remove(struct rte_pci_device *pci_dev, > > if (eventdev == NULL) > > return -ENODEV; > > > > - ret = rte_event_dev_close(eventdev->data->dev_id); > > - if (ret < 0) > > - return ret; > > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > > + ret = rte_event_dev_close(eventdev->data->dev_id); > > + if (ret < 0) > > + return ret; > > + } > > > > /* Invoke PMD device un-init function */ > > if (devuninit) > > -- > > 2.17.1 > >