From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67771A3168 for ; Wed, 16 Oct 2019 12:09:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F7681E8D6; Wed, 16 Oct 2019 12:09:12 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id D05C11DFEC for ; Wed, 16 Oct 2019 12:09:10 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id c4so2005922ilq.13 for ; Wed, 16 Oct 2019 03:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ywrif6aUpseojvlTrJ0PRgOi5AmICOJQ6Vb09JGzp6A=; b=E6QmvzbyhXSJJ1SELn4UldQ0IkaOSAoia4FZ6BhpTzVt/Yssd2sst6o+aXDlxflmSm p3Qamu1s88n3uB+YTziLbX8uEA93ySj2LSo5otJrik7qCca79MseXai+sDEoPhncEeAG E6xarwj4ZN2oVK3Ry0chqjLALwU9JrVrDiqdJMnlhj7xDJMOJOkJ46k/MD3OHrk05UL6 4G3PH9xNuoZKF3QwWswcEjkM/KMFH0q7NKgStIa7DJq27Rzc16y81q+llZDMGFmCZew7 PPEmHV/xrqNCjLHiRKKK7wmGhj0tyVeZ+xGFMJlY41QEWZKpuBtYYk/gNFQcpM4PiJQn z6kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ywrif6aUpseojvlTrJ0PRgOi5AmICOJQ6Vb09JGzp6A=; b=eP2Isydg+0fGcqmeebpSYW/tDSBk+60D5wNyclw/2MCTnO3BRnDaTUDAyxiQhjKfsl A3SOJvEclykzsbNSuYjJHUQRTAjnieS0kMRkBzFMDIaBZAtjpuYMDfmzcEBgdA/cwTR9 +fgR4LyCkzj/78rEc5Rlq2Pi3PJl0yJ6i3Ah1tB1Za/xNlj620W5VQqCQxQ/ioQy7Hxv Axv5IeAu6PPSDTs2wtENz/SMd1KoeBJ6wMLmxBNk0r+wAuBtB3+dRsskJLYHNDYNz002 zOpXPkX9im/ue69KKIPq4LUxS/GvYC/NDBOSjNheC4XuHlBB2o/vnoW8hqy+zeiISq7J EwxQ== X-Gm-Message-State: APjAAAV7W6aIDkgx+qcm4ITYFl6GS4UxQqq+kTPJSmxCxF+x5s5Z4n7n bY8muV6mZiuTLZyc0VuNOpPLTH5dZWP4dCVU1x0= X-Google-Smtp-Source: APXvYqxr2qC8UqvGjtGkScrDmKdsEtCb+AIupGvZvnBbapv/gk4JAOJ4TysOZw6yJjxHbLPmIErALQhvdrQK8XS0gaE= X-Received: by 2002:a92:ce41:: with SMTP id a1mr10682919ilr.60.1571220549823; Wed, 16 Oct 2019 03:09:09 -0700 (PDT) MIME-Version: 1.0 References: <20190730155726.26450-1-thomas@monjalon.net> <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> <06588c18-4931-1328-fafe-73c4c02f5c17@intel.com> <42a41fd3-cfa3-2806-f8c2-b6fff2232aa1@intel.com> In-Reply-To: <42a41fd3-cfa3-2806-f8c2-b6fff2232aa1@intel.com> From: Jerin Jacob Date: Wed, 16 Oct 2019 15:38:58 +0530 Message-ID: To: Ferruh Yigit Cc: Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon , John McNamara , Marko Kovacevic , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qi Zhang , Wenzhuo Lu , Rosen Xu , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Rasesh Mody , Shahed Shaikh , dpdk-dev , David Marchand , Adrien Mazarguil Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 16 Oct, 2019, 3:32 PM Ferruh Yigit, wrote: > On 10/15/2019 5:19 PM, Jerin Jacob wrote: > > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit > wrote: > >> > >> On 10/15/2019 3:16 PM, Jerin Jacob wrote: > >>>>>>> @@ -36,13 +36,6 @@ VMDq = > >>>>>>> SR-IOV = > >>>>>>> DCB = > >>>>>>> VLAN filter = > >>>>>>> -Ethertype filter = > >>>>>>> -N-tuple filter = > >>>>>>> -SYN filter = > >>>>>>> -Tunnel filter = > >>>>>>> -Flexible filter = > >>>>>>> -Hash filter = > >>>>>>> -Flow director = > >>>>>>> Flow control = > >>>>>>> Flow API = > >>>>>>> Rate limitation = > >>>>>> I suggest adding these features back! > >>>>>> > >>>>>> "Flow director" and other filters are features that device/driver > supports. > >>>>>> > >>>>>> And "Flow API" and "filter_ctrl" are methods used to implement > these features. > >>>>>> Indeed they are only different APIs to get input from > application/user. > >>>>>> > >>>>>> It doesn't really mean much to say "Flow API" is supported? So what > is really > >>>>>> supported? It matters more what feature is supported. > >>>>>> > >>>>>> Since we are saying old method is deprecated, we can update the > feature list of > >>>>>> drivers which implements filtering features using old method as not > supported. > >>>>>> And that is the case with this patch since old APIs are marked as > deprecated, > >>>>>> users can't use them to enable a filtering feature. > >>>>>> > >>>>>> Indeed I am for removing the "Flow API" from feature list, first it > is not a > >>>>>> feature, second if it is only method to enable a filtering, and if > filtering is > >>>>>> enabled in a driver, what is the point of redundant "Flow API" > listing? > >>>>>> > >>>>>> I can make a quick patch if there is no objection, thanks. > >>>>> > >>>>> As I understand it was a decision to avoid details about flow API > support > >>>>> in features matrix. Mainly because matrix would be really huge in > >>>>> attempt to represent it. The question is why filters/patterns > mentioned > >>>>> above are better than others and should be mentioned. > >>>>> I'm not against adding some details, just want to understand > criteria. > >>>>> Flexible and hash are definitely not well defined. > >>>>> What is flow director and which features should be supported to say > yes? > >>>>> > >>> > >>>> > >>>> The criteria I have is what users will be interested about a > device/driver. > >>>> > >>>> Will it be really huge to list filtering capabilities of the devices? > I believe > >>>> we can group them into a few groups like above. > >>>> Or at least keep existing one and improve it by time and +1 to > clarify them more > >>>> but that is something else. > >>>> > >>>> A device can have capabilities but it is not easy to find if that > capability has > >>>> been enabled via DPDK, this kind of feature matrix works for it, and > all > >>>> features together makes it much easier than digging datasheets and > code. > >>>> > >>>> Saying that "Flow API" is enabled for a driver doesn't really gives > any > >>>> information to the user if they are interested what kind of filtering > features > >>>> are supported by that device/driver. > >>> > >>> I agree. I think, we need to enumerate rte flow patterns and actions > >>> supported by the PMD. > >>> Since there was no single place such documentation, we added the same > >>> in PMD documentation > >>> See 39.8. RTE Flow Support at > https://doc.dpdk.org/guides/nics/octeontx2.html > >>> > >>> And IMO, We should not add deprecated features in the features matrix > as > >>> new PMDs are not planning to implement the deprecated APIs. That > >>> makes, matrix looks > >>> new PMDs do not implement a lot of features, but in reality, those are > >>> deprecated and never planning to implement if even though HW supports > it. > >>> > >> > >> +1 to not add deprecated features to the matrix, but those removed ones > [1] are > >> not deprecated. Implementing them via "filter_ctrl" is deprecated. Below > >> features still can be implemented via "Flow API", that is why I am for > adding > >> them back to default.ini. > > > > Got it. Instead of [1], Can we document it as in the form of rte_flow > > semantics(patterns and actions) so > > that for the end-user it is very clear. Reason being: > > # Expressing "Tunnel filter" or "N-tupe filter" or "Flexible filter" > > or "Flow director" etc is very vague in rte_flow semantics > > and function is not just limited with above-fixed functions > > # The new PMDs also can express the rte_flow aka "Flow API" support > > in the rte_flow semantics. > > rte_flow is implementation detail, as well as 'filter_ctrl', I believe > listing > rte_flow semantic will be too much detail for the feature table. > > And end user may be interested in features, as if that drive/device support > "Flow Director" or not, instead of rte_flow semantic. > > But I can see feature being vague is also problem, perhaps we can have > rte_flow > level details in features.rst file, will it work? > +1 for adding rte_flow level level details in features.rst IMO, Supported packet types(ptype) also good addition in features list. > > > > > >> And announce them as supported per PMD only if they are implemented via > Flow API. > >> > >> [1] > >> Ethertype filter = > >> N-tuple filter = > >> SYN filter = > >> Tunnel filter = > >> Flexible filter = > >> Hash filter = > >> Flow director = > >