From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80C83A058A; Thu, 2 Apr 2020 10:12:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AB901BEA8; Thu, 2 Apr 2020 10:12:19 +0200 (CEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by dpdk.org (Postfix) with ESMTP id E4E001BEA8 for ; Thu, 2 Apr 2020 10:12:16 +0200 (CEST) Received: by mail-il1-f182.google.com with SMTP id x16so2690329ilp.12 for ; Thu, 02 Apr 2020 01:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VZiEIxYaNZEmgeQqFd/rMsa5azD5t78ERV/ZjOz/95I=; b=jVg4PA+4VxpZ5OmtQbE12zQE1lX/KpKRPoLzh563DtJVDg6j8uWA6RnIACGMCpmGOD TEJ4tzTNHaBxSiE/8Tnrd+ZCdNqk64W7Ot64ibpBgHy7aACo8oWt8UeiYZKyHtIKE/dn y5zZVVtqVg5DZ+MvDu5onv5ufOd9FbXaGLP3eU9vatHOv1nglv5Atx7A3f12zIu6Hg34 eJ8XIXjjGdXfKn6knUmRobs63W1iADNwfVF0nP9EM4ldcifFfCgItdNE+dGZlOwa9Nc1 dTB+/KaW6y/+trPkAEVk8Y+YsyJQYyuELJBbr3S8HrdX7dbr/QXH4tgU0TPRuohNshMN i38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VZiEIxYaNZEmgeQqFd/rMsa5azD5t78ERV/ZjOz/95I=; b=PGzYMWo/dx6oBjLWaP4cbk78uEGEiL/yqZnoa3mZnDk6KJWqvO5gO6oOoXEqbrgFtq TSDFQ06y2ATHVmftmcoczd3p1Q7XTdbl2heFQvMD+Kk4xN/M/3jrkONZwplQDGFGAhKE DdyhAsuIIJtY749oAATzm+03a8KmKbV9Z9+kuGWqVx6SJz7O057/awIswYbVj6jgkfEt rGPtEGoFggBYhkyiv/X3UQfRxDQHXZledkq8YIliUDGGR2uz5RiSGOur8VDUvklkPxS9 XM4+mYFOIJGKGRPaj/Gua40dgSLlacWDoquci391iQepRyyoppXqp+w3zEEu8HQEITpu 9K0w== X-Gm-Message-State: AGi0PuYBHd5zVNEzaWYrszCGiK884aBeFX06YxTBek+QmSiRXc0Xh4GA y8sl2RjXdSivG18AuR2cdxl2ZOjVlJp67oBFViY= X-Google-Smtp-Source: APiQypL5w+gG8dIbC36nmMPDisCNihdl0FSsosAJJJw//4dTePqGdGaEiVz5wUUCXCVhWLQf+Z2aUdbuKRCB9pxzZcQ= X-Received: by 2002:a92:8159:: with SMTP id e86mr1962999ild.60.1585815136066; Thu, 02 Apr 2020 01:12:16 -0700 (PDT) MIME-Version: 1.0 References: <20200309095410.28983-1-joyce.kong@arm.com> <1989157.0RtB02Ng89@xps> <2838900.VqyquhjGfd@xps> In-Reply-To: <2838900.VqyquhjGfd@xps> From: Jerin Jacob Date: Thu, 2 Apr 2020 13:41:59 +0530 Message-ID: To: Thomas Monjalon Cc: Joyce Kong , Gavin Hu , "stephen@networkplumber.org" , "david.marchand@redhat.com" , "mb@smartsharesystems.com" , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , Honnappa Nagarahalli , Phil Yang , nd , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 2, 2020 at 1:37 PM Thomas Monjalon wrote: > > 02/04/2020 09:20, Gavin Hu: > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Wednesday, April 1, 2020 5:45 PM > > > To: Joyce Kong ; Gavin Hu > > > Cc: stephen@networkplumber.org; david.marchand@redhat.com; > > > mb@smartsharesystems.com; jerinj@marvell.com; > > > bruce.richardson@intel.com; ravi1.kumar@amd.com; rmody@marvell.com; > > > shshaikh@marvell.com; xuanziyang2@huawei.com; > > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Honnappa > > > Nagarahalli ; Phil Yang > > > ; nd ; dev@dpdk.org; nd > > > > > > Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD > > > bit operation APIs > > > > > > 01/04/2020 10:27, Gavin Hu: > > > > Hi Thomas, > > > > > > > > From: Thomas Monjalon > > > > > > > > > > Hi, > > > > > > > > > > 09/03/2020 10:54, Joyce Kong: > > > > > > Bitwise operation APIs are defined and used in a lot of PMDs, > > > > > > which caused a huge code duplication. > > > > > > > > > > Statistics of the series: 653 insertions(+), 326 deletions(-) > > > > > I would not say it is a huge duplication. > > > > We did not include all PMDs, just a few for piloting and seeking opinions. > > > > It is a huge duplication when counting all the PMDs. > > > > > > > > > > > To reduce duplication, > > > > > > this patch consolidates them into a common API family. > > > > > [...] > > > > > > +PMD Bitops > > > > > > +M: Joyce Kong > > > > > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h Change to lib/librte_eal/include/rte_pmd_bitops.h. Check top of tree. > > > > > > > > > > Why is it called PMD bitops and not simply bitops? > > > > > > > > The scope of these APIs are decreased to PMD use only, for > > > libraries/applications, it is recommended to use C11 directly as there are > > > complications of more ordering models involved. > > > > > > OK, but PMD means nothing, except this is where it is used *now*. > > > Please describe and name the API with memory ordering words. > > Will remove 'PMD' in v8. > > The APIs were already named with a '_relaxed' suffix, for example 'rte_get_bit64_relaxed'. > > According to Honnappa, this patch set just address PMD's requirement, and the current PMDs are not using C11, so only '_relaxed' version is offered. > > http://inbox.dpdk.org/dev/VE1PR08MB514983C3200859B27F166EBB983F0@VE1PR08MB5149.eurprd08.prod.outlook.com/ > > So why not calling this component "relaxed bitops"? In the future, we can extend to more memory orders as needed. IMO, Just changing to rte_bitops.h is enough. > > > >