From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF40DA04DD; Tue, 10 Nov 2020 19:05:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F3E22B93; Tue, 10 Nov 2020 19:05:42 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id BDC02F64 for ; Tue, 10 Nov 2020 19:05:39 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id r12so15230138iot.4 for ; Tue, 10 Nov 2020 10:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b5I8I6mM69MX+wulkn63P0motD+h/emWEO9sTIknCEs=; b=uHhmPq7u5nK6occXn5IQG4R677DjSiw/2xRAXNW2RTXAkfR6MjE9CtH3x3+NxTCeUW RNGerD8Z0rB+4eK3TqL6CrwRrlDP6Pl85T70xEB591n6bSfL3gFsVHqNFqLvR8VdaenU h29O4x8j8WxqUbTpJa6yObHpOczsGDiLlmD8zsGcrfCdUNVo5HNAKosjUYWNz1lf27HK NyuSoKa4KWArbFcGg948OsDGPfMRrmdZTX3lq4dVGogqWyoEYBIZIdE5am1j1CTK44zx 1xgi5oWorT+KEwJCtDXqpCC254uc1OKKmY/LFWkh3y5NpetWWZSIzgXDEnfqWFSGhigP YJ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b5I8I6mM69MX+wulkn63P0motD+h/emWEO9sTIknCEs=; b=SNc40hXEEmB+hGF+Qx3SIw/VQucxe15L6BJz8mRzIwTdgIcHo6LMZq5p5ioF23Rs2+ OxNLycN0r+dz+bC/vpsHaber94oLdXmNI2fMGLTDdeBCtBY7I/40f17DIeWZ2EubHDV5 BdsRxMoDcpczir19WChaVEa3eOclNPywC28nZJ8L2eHoxL8g05FiDvxhIP8ZNxqZNKMs 45KZsNAZsdi5h9ATmv/G6be3RTBv5fRW14LHmeS2YsNre1rREZnbJzwhUGmq6utU/WiL CsGn60tC7cbx1T9GhJdBWyEZtJ60uNr4nQZpjLZo67qLfqHpMaQ7kFLNVsjLhi3I9tE/ aWJw== X-Gm-Message-State: AOAM530yVbkvgm/37ORtflCDIs7nUV209gv9YpzDwUNeIPb+iJlo9Znu fJ7cc27dA4WkGkNYSVN90IarqURGvjF0wPlhyWI= X-Google-Smtp-Source: ABdhPJyckBj3Dg9PU+HhJwDE5UkXHa6uolOwACWuWQ5Nn1WFpEb8gxBSgjUKzAFJWHQH4F7+uBS6no6HI6AJNLCY378= X-Received: by 2002:a6b:5805:: with SMTP id m5mr14917894iob.1.1605031539013; Tue, 10 Nov 2020 10:05:39 -0800 (PST) MIME-Version: 1.0 References: <20201107155306.463148-1-thomas@monjalon.net> <20201109212937.989954-1-thomas@monjalon.net> <20201109212937.989954-2-thomas@monjalon.net> In-Reply-To: <20201109212937.989954-2-thomas@monjalon.net> From: Jerin Jacob Date: Tue, 10 Nov 2020 23:35:22 +0530 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , David Marchand , Ferruh Yigit , Olivier Matz , =?UTF-8?Q?Morten_Br=C3=B8rup?= , "Ananyev, Konstantin" , Andrew Rybchenko , Viacheslav Ovsiienko , Ajit Khaparde , Jerin Jacob , Hemant Agrawal , Nithin Dabilpuram , Ankur Dwivedi , Anoob Joseph , Pavan Nikhilesh , Kiran Kumar K , Guy Kaneti Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 3:00 AM Thomas Monjalon wrote: > > The drivers for OCTEON TX2 are not supported in 32-bit mode. > > Suggested-by: Jerin Jacob > Signed-off-by: Thomas Monjalon Acked-by: Jerin Jacob > --- > drivers/common/octeontx2/meson.build | 18 ++++++------------ > drivers/crypto/octeontx2/meson.build | 17 +++-------------- > drivers/event/octeontx2/meson.build | 18 ++++++------------ > drivers/mempool/octeontx2/meson.build | 18 ++++++------------ > drivers/net/octeontx2/meson.build | 11 ++++++----- > drivers/regex/octeontx2/meson.build | 22 +++------------------- > 6 files changed, 30 insertions(+), 74 deletions(-) > > diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build > index f2c04342e9..84fb11524d 100644 > --- a/drivers/common/octeontx2/meson.build > +++ b/drivers/common/octeontx2/meson.build > @@ -2,6 +2,12 @@ > # Copyright(C) 2019 Marvell International Ltd. > # > > +if not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit' > + subdir_done() > +endif > + > sources= files('otx2_dev.c', > 'otx2_irq.c', > 'otx2_mbox.c', > @@ -9,18 +15,6 @@ sources= files('otx2_dev.c', > 'otx2_sec_idev.c', > ) > > -extra_flags = [] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > -foreach flag: extra_flags > - if cc.has_argument(flag) > - cflags += flag > - endif > -endforeach > - > deps = ['eal', 'pci', 'ethdev', 'kvargs'] > includes += include_directories('../../common/octeontx2', > '../../mempool/octeontx2', '../../bus/pci') > diff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build > index 4e4522cace..0aad4e9a16 100644 > --- a/drivers/crypto/octeontx2/meson.build > +++ b/drivers/crypto/octeontx2/meson.build > @@ -1,9 +1,10 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright (C) 2019 Marvell International Ltd. > > -if not is_linux > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > build = false > - reason = 'only supported on Linux' > + reason = 'only supported on 64-bit Linux' > + subdir_done() > endif > > deps += ['bus_pci'] > @@ -21,18 +22,6 @@ sources = files('otx2_cryptodev.c', > 'otx2_cryptodev_ops.c', > 'otx2_cryptodev_sec.c') > > -extra_flags = [] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > -foreach flag: extra_flags > - if cc.has_argument(flag) > - cflags += flag > - endif > -endforeach > - > includes += include_directories('../../common/cpt') > includes += include_directories('../../common/octeontx2') > includes += include_directories('../../crypto/octeontx2') > diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build > index 724da2e6b7..22e7e4cb63 100644 > --- a/drivers/event/octeontx2/meson.build > +++ b/drivers/event/octeontx2/meson.build > @@ -2,6 +2,12 @@ > # Copyright(C) 2019 Marvell International Ltd. > # > > +if not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit' > + subdir_done() > +endif > + > sources = files('otx2_worker.c', > 'otx2_worker_dual.c', > 'otx2_evdev.c', > @@ -13,18 +19,6 @@ sources = files('otx2_worker.c', > 'otx2_tim_worker.c' > ) > > -extra_flags = [] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > -foreach flag: extra_flags > - if cc.has_argument(flag) > - cflags += flag > - endif > -endforeach > - > deps += ['bus_pci', 'common_octeontx2', 'crypto_octeontx2', 'mempool_octeontx2', 'net_octeontx2'] > > includes += include_directories('../../crypto/octeontx2') > diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build > index 0226f76d4b..0586321abe 100644 > --- a/drivers/mempool/octeontx2/meson.build > +++ b/drivers/mempool/octeontx2/meson.build > @@ -5,6 +5,12 @@ > if is_windows > build = false > reason = 'not supported on Windows' > + subdir_done() > +endif > +if not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit' > + subdir_done() > endif > > sources = files('otx2_mempool_ops.c', > @@ -13,16 +19,4 @@ sources = files('otx2_mempool_ops.c', > 'otx2_mempool_debug.c' > ) > > -extra_flags = [] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > -foreach flag: extra_flags > - if cc.has_argument(flag) > - cflags += flag > - endif > -endforeach > - > deps += ['eal', 'mbuf', 'kvargs', 'bus_pci', 'common_octeontx2', 'mempool'] > diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build > index 599ade6727..638c04a2fe 100644 > --- a/drivers/net/octeontx2/meson.build > +++ b/drivers/net/octeontx2/meson.build > @@ -2,6 +2,12 @@ > # Copyright(C) 2019 Marvell International Ltd. > # > > +if not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit' > + subdir_done() > +endif > + > sources = files('otx2_rx.c', > 'otx2_tx.c', > 'otx2_tm.c', > @@ -29,11 +35,6 @@ deps += ['bus_pci', 'cryptodev', 'eventdev', 'security'] > deps += ['common_octeontx2', 'mempool_octeontx2'] > > extra_flags = ['-flax-vector-conversions'] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > foreach flag: extra_flags > if cc.has_argument(flag) > cflags += flag > diff --git a/drivers/regex/octeontx2/meson.build b/drivers/regex/octeontx2/meson.build > index aada0b5601..34e51728c2 100644 > --- a/drivers/regex/octeontx2/meson.build > +++ b/drivers/regex/octeontx2/meson.build > @@ -2,9 +2,10 @@ > # Copyright(C) 2020 Marvell International Ltd. > # > > -if not is_linux > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > build = false > - reason = 'only supported on Linux' > + reason = 'only supported on 64-bit Linux' > + subdir_done() > endif > > lib = cc.find_library('librxp_compiler', required: false) > @@ -21,23 +22,6 @@ sources = files('otx2_regexdev.c', > 'otx2_regexdev_compiler.c' > ) > > -extra_flags = [] > -# This integrated controller runs only on a arm64 machine, remove 32bit warnings > -if not dpdk_conf.get('RTE_ARCH_64') > - extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -endif > - > -# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > -if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false > - ext_deps += cc.find_library('atomic') > -endif > - > -foreach flag: extra_flags > - if cc.has_argument(flag) > - cflags += flag > - endif > -endforeach > - > fmt_name = 'octeontx2_regex' > deps += ['bus_pci', 'common_octeontx2', 'regexdev'] > > -- > 2.28.0 >