From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17DB9A053A; Tue, 4 Aug 2020 13:37:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71D4A29D2; Tue, 4 Aug 2020 13:37:31 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id A8D0C255 for ; Tue, 4 Aug 2020 13:37:29 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id z3so23639789ilh.3 for ; Tue, 04 Aug 2020 04:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qgntTanEs8SkaaE6FEqqnr+bZSZQxlCvVjtpBup4sTE=; b=bllbo2O1noNav7xquX1k+kUi66qIeJI2dnFfrdKn62eBmcA3h8HX33zTPGuuq2lSt5 aV+4aw47lhALl83S1D+xh9tSkym0m3kuUSFiA87BgLLuGGf4B/mIkeLs+48aIr3PgZU8 tXt/0av11YmuI8gbY2mYrZmT2jqw7aChTuSSnVymQPaShscBPhObjaBOGY/YJDwffMd7 tlwVqpyi9bEuhOf0v+AGRcBoo8lNsVgEhKdnR3dW+/BYTitdjrve96wiWUhDAZW1FbLq oj4SU22F41wAEOSv0tfLjBKFltq6ubpDdJF9i2XxvoRQlutplWuxxn+T1s9G23gQY6gG 0Tkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qgntTanEs8SkaaE6FEqqnr+bZSZQxlCvVjtpBup4sTE=; b=HXY61IR9vRidXPSU0Guvf4GnNV0ZfmtFk7fcU1zHA3ti2ueT8LhZvnLVfbfGlL4b/K 3F3n7ngCHeJ20ANoRkFtPrXa+P+mAsWLt/kt9gmTrIR7Vmztii2SPMtExXW4BdKik/1R x485we0OkftRqaPaq+m1OuFE78CU1Px69kUdW+UcdhDqbNXan7lkSSPNC/20V3zaViid DgS3wFbQoBtS2/urmvZFGBXbRP1ZO6Ja8AvdM69glb6qLsYhkTw/OoJQJmFKgMTB/McY 3hmh/OCxfSyDbUq/zwLBoHPV0pc7tbSj3wotq+VmCJ7lD6HkNsK+T2pSm3OTWVFd/3j3 KADA== X-Gm-Message-State: AOAM531tWoF+v/JBXxRk1oXXsb5/VrHUGdllOqfmT0wXBMJGc0VpMIfF 4GNOTKReFbpyF2aFY4XxZT8gSQAxqALmGlqymTU= X-Google-Smtp-Source: ABdhPJyvDNVYNldf+VoO1Vwp27kea0vG9/Y7q32R1GzLT0PDWOJlkKqEQFjgEy7Qsy7St4HRXtSLFa97fyZgVJ9KbEo= X-Received: by 2002:a92:dcc8:: with SMTP id b8mr4081742ilr.60.1596541048907; Tue, 04 Aug 2020 04:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20200802105137.1666-1-pbhagavatula@marvell.com> <20200803072903.1209-1-pbhagavatula@marvell.com> <20200804104153.GA1464@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200804104153.GA1464@bricha3-MOBL.ger.corp.intel.com> From: Jerin Jacob Date: Tue, 4 Aug 2020 17:07:12 +0530 Message-ID: To: Bruce Richardson Cc: Pavan Nikhilesh , Jerin Jacob , Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , dpdk-dev , Thomas Monjalon , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 4, 2020 at 4:12 PM Bruce Richardson wrote: > > On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavatula@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add 64 byte padding at the end of event device public structure to allow > > future extensions. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Jerin Jacob > > --- > > v2 Changes: > > - Modify commit title. > > - Add patch reference to doc. > > > > doc/guides/rel_notes/deprecation.rst | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index ea4cfa7a4..ec5db68e9 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -151,3 +151,14 @@ Deprecation Notices > > Python 2 support will be completely removed in 20.11. > > In 20.08, explicit deprecation warnings will be displayed when running > > scripts with Python 2. > > + > > +* eventdev: A 64 byte padding is added at the end of the following structures > > + in event device library to support future extensions: > > + ``rte_event_crypto_adapter_conf``, ``rte_event_eth_rx_adapter_conf``, > > + ``rte_event_eth_rx_adapter_queue_conf``, ``rte_event_eth_tx_adapter_conf``, > > + ``rte_event_timer_adapter_conf``, ``rte_event_timer_adapter_info``, > > + ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_queue_conf``, > > + ``rte_event_port_conf``, ``rte_event_timer_adapter``, > > + ``rte_event_timer_adapter_data``. > > + Reference: > > + http://patches.dpdk.org/project/dpdk/list/?series=10728&archive=both&state=* > > -- > > I don't like this idea of adding lots of padding to the ends of these > structures. For some structures, such as the public arrays for devices it > may be necessary, but for all the conf structures passed as parameters to > functions I think we can do better. Since these structures are passed by > the user to various functions, function versioning can be used to ensure > that the correct function in eventdev is always called. From there to the > individual PMDs, we can implement ABI compatibility by either: > 1. including the length of the struct as a parameter to the driver. (This is > a bit similar to my proposal for rawdev [1]) > 2. including the ABI version as a parameter to the driver. But, Will the above solution work if the application is dependent on struct size? i.e change of s1 size will change offset of s3 i.e app_sepecific_struct_s3. Right? i.e DPDK version should not change the offset of s3. Right? example, struct app_struct { struct dpdk_public_struct_s1 s1; struct dpdk_public_struct_s2 s2; struct app_sepecific_struct_s3 s3; } > > Regards > /Bruce > > [1] http://inbox.dpdk.org/dev/?q=enhance+rawdev+APIs