From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B0E142CB3; Wed, 14 Jun 2023 16:42:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B95F240E0F; Wed, 14 Jun 2023 16:42:42 +0200 (CEST) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by mails.dpdk.org (Postfix) with ESMTP id 895FC40DDB for <dev@dpdk.org>; Wed, 14 Jun 2023 16:42:41 +0200 (CEST) Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-46e92a905bcso243896e0c.0 for <dev@dpdk.org>; Wed, 14 Jun 2023 07:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686753761; x=1689345761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NZOE1uo6zx5PDTAYQuyq8mCy2XhTDwWm9DlxnsFzhRM=; b=XeTJvjTUR1/E8f+6wvNHIgrJWUPVSKZAuFWmKAcO9n8S2QrTQrY2w7vLIcEV0uXUpt 6OSensDACMV9Wy8VDpz5qdimtlh641lpSW74+Y6HIo2dtAhs0WQrFJgRq+Mq7EnRVw/m cDtBFJHfJQo6SSpi5drmhVItWGd53QNbHukaIlBIXxVvv4uH1l2QJXhyW1CMZd/GsHfH hpq1+eQ59y2jFBMiEvvlCEgWApQ9kIXPza+Ua53YgXVeijJmRiy43QjovnHUWh21LY4X 78cu3Eu5L8D4Q7b/PgLNe9iPPO+xKLVXS5XvI+VC8PIpgzkNNvyy7iYRlMZqQj1P1I5V fwBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686753761; x=1689345761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NZOE1uo6zx5PDTAYQuyq8mCy2XhTDwWm9DlxnsFzhRM=; b=Nz4j7z/0TKpsmOlUboHPN40a23KUTMtQSlrFROUGyhy6WIjgiSed9gbstLb8tW7S0d U43GSG8yhNK7A3tdsQKKK3EVAuO6/AWPd8Z78WU3t46WFhiT4OFONE5+0i0M9+nC24to 2W/ohT+di6mO3cl9XgTyFdAk3dIH1zJqy/lTHelHYhnHtR9gP/4+4+pPvi9QlUR3XFfR oVXDKbu1j0taNccC0EK885c4TYzBVmHyxZsJBrdu4+zPOOlKm1RTmCc7bze6kfN0Gwh7 ocBodFz2YeJFiGsuw0y8pJiZ+IGNMJ96HfhCsL0ljAISPYHXPt9x5K8YmzC6RIy2WJSn X0wA== X-Gm-Message-State: AC+VfDyDRw5MZG0D6qUerqxtTWsa3zmTLwfSy1F0Z81D26TB354P6vgw j72ji9jDduM9pth7F7zLa8ucliCWAwCzGG3Xu6R1Kkwyu6qO/etK X-Google-Smtp-Source: ACHHUZ6v16VDph1qOsNy19W5f2wilhj4GFmqFdm1m5EZHFkZyVQckfoYFdAz9km2Ac9AjolzfXWBoUzYKf/CjFdjYaQ= X-Received: by 2002:a1f:3dc3:0:b0:46e:6eaf:9071 with SMTP id k186-20020a1f3dc3000000b0046e6eaf9071mr3083710vka.12.1686753760656; Wed, 14 Jun 2023 07:42:40 -0700 (PDT) MIME-Version: 1.0 References: <20230614142651.1456116-1-thomas@monjalon.net> In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 14 Jun 2023 20:12:14 +0530 Message-ID: <CALBAE1PKEUmC4tbONhSOOVSxG29Dz61dW9=wHCuwZ-T3dYssRw@mail.gmail.com> Subject: Re: [PATCH 0/5] cleanup in library header files To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 8:01=E2=80=AFPM Thomas Monjalon <thomas@monjalon.ne= t> wrote: > > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of comments. > As it is not critical, they are not marked for backport. > > While looking the header files, I've fixed some misuses of "extern". Thanks for the cleanup. IMO, it is better to update ./devtools/checkpatches.sh or so to flag these issue before getting to repo for new changes,