From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94C5EA04B5; Mon, 2 Dec 2019 05:11:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9BD92BD8; Mon, 2 Dec 2019 05:11:52 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 66FF1A3; Mon, 2 Dec 2019 05:11:50 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id u17so32093152ilq.5; Sun, 01 Dec 2019 20:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XC/dU3aSm/XIfN1KBCKs7I+BWmIftGqd+U49BFTlik4=; b=KEpKTsOKaCm5vPClCbB9A6C1kKQXeTDYa4QuCFd4+tvaobeWQ9aGkQGuuYHT5p8nik pD6t5niKC4jG4VT1EZHFpYeopjj6ga/JGhuqoi7SuS08/5hp0mwOMHMDaY8WYDLtpiku zQlbMaKtLEcjSXl05Gr9PDDznQJcGfwyIVLFJrHl1Y/wBLezQNHgAT/zbegzQhA8VZNL teibOC9XgUCT8+O5d2DICdhFs564QaPmkuda4Erysd726KGs5ukjMYVzCxaC0wZU+hUU RxoFRiHNkRwHpqyud/KruDseWHqITGFslpQwHAqBPlF3lK5P/J2jVqB59kSo0P3EVnTm blew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XC/dU3aSm/XIfN1KBCKs7I+BWmIftGqd+U49BFTlik4=; b=jhkCZSUUIuKSx6KP8a1S5zIMo2ejktGE8K9R4PPsquoS7kMHWKkdK4WxcVPJXFgF12 P80Tj2ULBRDt4BG8XSoGQSloKucmxaKpqKR4D+F0I7eOHnm7hnJTMSDjAuVkR8Yx5SV+ R+jUFVCByfQCn9b6FajFUNoO5VDQxPk2GJsy9V738ARP7pwZ/bKxvvyp26jXaHTt/uQz KclbmrlrVVWFMiNGzfMxokKd5BJkxZ9Kq3Ed0YPyYqLbXyDYkU6Dpm6DLrhW0013DVa6 PwKxkd+Sw9Uz8l5TjMVcDwD9B4rjDIpQhDNgLUR+fOhEcVp/PHf63lfEVKOE7RhvUX+i I/hA== X-Gm-Message-State: APjAAAXxup5a46la5SJGGYAEfiaWyIOw7RGg6N0Q2zF9eTVJRFspjjZ9 uRSCge9vvO/nppOKtmSPZJRllet20cSCYlfLtE8= X-Google-Smtp-Source: APXvYqwPBZIazdrAqADgPVoes9B3lvC7c/p6u5e3tOYVU5HhsZDOOyS0Xzxlih86iEp473oH5HaLtGfRNLXbGC2lJ28= X-Received: by 2002:a92:7983:: with SMTP id u125mr21033905ilc.60.1575259909359; Sun, 01 Dec 2019 20:11:49 -0800 (PST) MIME-Version: 1.0 References: <20191129091100.4252-1-lironh@marvell.com> In-Reply-To: From: Jerin Jacob Date: Mon, 2 Dec 2019 13:11:33 +0900 Message-ID: To: Liron Himi Cc: Jerin Jacob Kollanukkaran , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] config: update Marvell ARMADA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > ---------------------------------------------------------------------- > On Fri, Nov 29, 2019 at 3:55 PM wrote: > > > > From: Liron Himi > > > > disable more NXP modules that conflict with MUSDK > > # Please share more details on the conflict. > [L.H.] both components calls of_ APIs so when MUSDK is compiled statically it conflicts with NXP's code. If something implemented in the library, IMO, it should start with the library name to avoid namespace collision. Are we implementing of_x calls in MUSDK? Could you share the error logs? > Note that the original armada config already had some NXP flags disabled, but in recent version NXP moved the of_ code to be depends on 'CONFIG_RTE_LIBRTE_COMMON_DPAAX' so needed to update it. OK > # What about meson build? "make" will be deprecated soon. > [L.H.] only when compiling the MUSDK as static LIBs, we face this issue. In meson we need to compile MUSDK as shared LIBS. But nothing stopping us to compile MUSDK as static build with meson. Right? > # This scheme won't work for distro build, Please spend the effort to analyze the conflict and fix the conflict. IMO, That would be the correct solution. > > > > > > Signed-off-by: Liron Himi > > --- > > config/defconfig_arm64-armada-linuxapp-gcc | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/config/defconfig_arm64-armada-linuxapp-gcc > > b/config/defconfig_arm64-armada-linuxapp-gcc > > index 059180284..c09751cf0 100644 > > --- a/config/defconfig_arm64-armada-linuxapp-gcc > > +++ b/config/defconfig_arm64-armada-linuxapp-gcc > > @@ -19,6 +19,23 @@ CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y > > > > # Disable NXP as it is conflict with MUSDK > > CONFIG_RTE_LIBRTE_DPAA_BUS=n > > +CONFIG_RTE_LIBRTE_COMMON_DPAAX=n > > +CONFIG_RTE_LIBRTE_FSLMC_BUS=n > > +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n > > +CONFIG_RTE_LIBRTE_DPAA2_PMD=n > > +CONFIG_RTE_LIBRTE_DPAA_BUS=n > > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n > > +CONFIG_RTE_LIBRTE_DPAA_PMD=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=n > > +CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n > > +CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n > > +CONFIG_RTE_LIBRTE_PFE_PMD=n > > +CONFIG_RTE_LIBRTE_ENETC_PMD=n > > + > > > > # Doesn't support NUMA > > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n > > -- > > 2.23.0 > >