From: Jerin Jacob <jerinjacobk@gmail.com>
To: Sunil Kumar Kori <skori@marvell.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH] net/cnxk: fix crash during hotplug detach operation
Date: Mon, 2 May 2022 23:14:08 +0530 [thread overview]
Message-ID: <CALBAE1PLTMPZ2P-3NASthSrq07Vi7LVMvTkLyDFJGQm38KAVOg@mail.gmail.com> (raw)
In-Reply-To: <20220329102857.2872895-1-skori@marvell.com>
On Tue, Mar 29, 2022 at 3:59 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> hot_plug application does not perform any port setup
> configuration via rte_eth_dev_configure() API. All the probed
> Ethernet ports do not contain any Rx and Tx queues.
>
> While detaching a device via rte_eal_hotplug_remove(), CNXK
> driver expects Rx and Tx queues structures populated during
> reset of PFC. So application gets crashed as data->rx_queues
> and data->tx_queues are NULL.
>
> Fixes: 9544713564f5 ("net/cnxk: support priority flow control")
Cc: stable@dpdk.org
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/net/cnxk/cnxk_ethdev_ops.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c
> index f4a0562475..15d8e8efa6 100644
> --- a/drivers/net/cnxk/cnxk_ethdev_ops.c
> +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c
> @@ -1069,6 +1069,11 @@ nix_priority_flow_ctrl_configure(struct rte_eth_dev *eth_dev,
> rx_pause = (mode == RTE_ETH_FC_FULL) || (mode == RTE_ETH_FC_RX_PAUSE);
> tx_pause = (mode == RTE_ETH_FC_FULL) || (mode == RTE_ETH_FC_TX_PAUSE);
>
> + if (data->rx_queues == NULL || data->tx_queues == NULL) {
> + rc = 0;
> + goto exit;
> + }
> +
> /* Configure CQs */
> memset(&fc_cfg, 0, sizeof(struct roc_nix_fc_cfg));
> rxq = ((struct cnxk_eth_rxq_sp *)data->rx_queues[conf->rx_qid]) - 1;
> --
> 2.25.1
>
prev parent reply other threads:[~2022-05-02 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 10:28 skori
2022-05-02 17:44 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PLTMPZ2P-3NASthSrq07Vi7LVMvTkLyDFJGQm38KAVOg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).